----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127103/ -----------------------------------------------------------
Review request for Plasma. Repository: plasma-framework Description ------- Add some tests for IconItem. Also found one issue in animation when quickly changing source, first frame will be rendered with wrong icon. Diffs ----- autotests/CMakeLists.txt 258adb8 autotests/data/icons/hicolor/22x22/apps/bug359388.svg PRE-CREATION autotests/data/view.qml PRE-CREATION autotests/iconitemtest.h PRE-CREATION autotests/iconitemtest.cpp PRE-CREATION src/declarativeimports/core/iconitem.cpp 085f284 Diff: https://git.reviewboard.kde.org/r/127103/diff/ Testing ------- Tests pass localy, I used only icons that are shipped with plasma-framework breeze theme so it should work on CI too. There is also test that checks if animation is not running after the item was hidden. This needs https://git.reviewboard.kde.org/r/122859/, so this should land only after that. Thanks, David Rosca
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
