Re: Review Request 126968: Morphingpopups effect, to animate tooltips

2016-02-02 Thread Martin Gräßlin
> On Feb. 2, 2016, 5:40 p.m., Thomas Lübking wrote: > > effects/morphingpopups/package/contents/code/morphingpopups.js, line 29 > > > > > > backtrace? > > Martin Gräßlin wrote: > I just created a test case fo

Re: Review Request 126968: Morphingpopups effect, to animate tooltips

2016-02-02 Thread Thomas Lübking
> On Feb. 3, 2016, 12:18 a.m., Xuetian Weng wrote: > > I just wonder, does this change also fix: > > https://bugs.kde.org/show_bug.cgi?id=241557 ? > > > > Also, I have impression that if there's a big difference between the size > > of two tooltip window, it will look bad. No, completely unre

Re: Review Request 126968: Morphingpopups effect, to animate tooltips

2016-02-02 Thread Xuetian Weng
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126968/#review92000 --- I just wonder, does this change also fix: https://bugs.kde.o

Re: KActivities split, 2nd phase

2016-02-02 Thread Ivan Čukić
> if the library can confortably be tier1 yes it's important it is. If we fix the wallpaper thing, it will be tier1 even with qml imports > the problem would be users of an old workspace, updating frameworks and I'd rather find a better solution than having kamd in the same release schedule with

Re: Review Request 125266: Authentication with certificates / Make MRU/MTU editable / Dialog fix

2016-02-02 Thread René Fürst
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125266/ --- (Updated Feb. 2, 2016, 10:17 p.m.) Status -- This change has been ma

Re: KActivities split, 2nd phase

2016-02-02 Thread Marco Martin
On Tuesday 02 February 2016 23:01:38 Ivan Čukić wrote: > > I would prefer it together with the library.. > > I do agree, the only reason why I wanted to move it out is that > kactivities would not be able to be tier1 in that case - the QML > imports use i18n (this one could be easily removed), kio

Re: KActivities split, 2nd phase

2016-02-02 Thread Ivan Čukić
> Isn't all the stuff that uses the wallpaper is in plasma-desktop > (/imports/activitymanager) already? The activities model (in kactivities/imports) provides a wallpaper info. Ch ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/

Re: KActivities split, 2nd phase

2016-02-02 Thread Marco Martin
On Tuesday 02 February 2016 23:04:37 Kai Uwe Broulik wrote: > ‎> ‎if plasma provided > wallpapers via d-bus, it would not be a problem > > We should add something like this nonetheless as parsing the config files > broke more than once already. Also there's requests for setting a wallpaper > via D

Re: KActivities split, 2nd phase

2016-02-02 Thread David Edmundson
On Tue, Feb 2, 2016 at 10:01 PM, Ivan Čukić wrote: > > I would prefer it together with the library.. > > I do agree, the only reason why I wanted to move it out is that > kactivities would not be able to be tier1 in that case - the QML > imports use i18n (this one could be easily removed), kio an

Re: KActivities split, 2nd phase

2016-02-02 Thread Ivan Čukić
> We should add something like this nonetheless as parsing the config > files broke more than once already. Also there's requests for setting a Yes, this was one of the temporary quick-and-dirty solutions that stayed for far too long. :) > wallpaper via DBus. Unfortunately due to Plasma's modular

Re: KActivities split, 2nd phase

2016-02-02 Thread Kai Uwe Broulik
‎> ‎if plasma provided wallpapers via d-bus, it would not be a problem We should add something like this nonetheless as parsing the config files broke more than once already. Also there's requests for setting a wallpaper via DBus. Unfortunately due to Plasma's modular architecture wrt wallpapers

Re: Review Request 126968: Morphingpopups effect, to animate tooltips

2016-02-02 Thread Thomas Lübking
> On Feb. 2, 2016, 4:40 nachm., Thomas Lübking wrote: > > effects/morphingpopups/package/contents/code/morphingpopups.js, line 86 > > > > > > a) let's have AnimationEffect::retarget(id, values...)?! - progress is

Re: KActivities split, 2nd phase

2016-02-02 Thread Ivan Čukić
> I would prefer it together with the library.. I do agree, the only reason why I wanted to move it out is that kactivities would not be able to be tier1 in that case - the QML imports use i18n (this one could be easily removed), kio and kconfig (these two are for getting the activity wallpaper -

Re: Review Request 125266: Authentication with certificates / Make MRU/MTU editable / Dialog fix

2016-02-02 Thread René Fürst
> On Dec. 17, 2015, 1:43 a.m., Lamarque Souza wrote: > > Ship It! So how do i get this checked in? The tutorial just says "If your patch was accepted, congratulations! :)" ^^ https://techbase.kde.org/Contribute/Send_Patches - René ---

Re: Review Request 126968: Morphingpopups effect, to animate tooltips

2016-02-02 Thread Marco Martin
> On Feb. 2, 2016, 4:40 p.m., Thomas Lübking wrote: > > effects/morphingpopups/package/contents/code/morphingpopups.js, line 70 > > > > > > enums (KWin.* should work, but am not sure) doesn't seems to work > On

Re: Review Request 126968: Morphingpopups effect, to animate tooltips

2016-02-02 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126968/ --- (Updated Feb. 2, 2016, 8:51 p.m.) Review request for kwin and Plasma. B

Re: Review Request 126970: gtk.css points to nonexistent files (bad filename)

2016-02-02 Thread Gustavo Alvarez
> On Feb. 2, 2016, 8:14 p.m., Efrem McCrimon wrote: > > I tested this my making changes in > > /usr/share/themes/Breeze-Dark/gtk-3.0/gtk.css and in > > /usr/share/themes/Breeze/gtk-3.0/gtk.css > > > > There were two edits because of the name change. Furthermore, there were > > already three

Re: KActivities split, 2nd phase

2016-02-02 Thread Marco Martin
On Tuesday 02 February 2016 19:32:13 Ivan Čukić wrote: > Hi all, > > The libraries have mostly been split - we now have three repositories: > - kactivities (the framework) > - kactivities-stats (another framework, under review atm) > - kactivitymanagerd (the service) Good stuff! comments on where

Re: Review Request 126970: gtk.css points to nonexistent files (bad filename)

2016-02-02 Thread Efrem McCrimon
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126970/#review91990 --- I tested this my making changes in /usr/share/themes/Breeze-

Re: Review Request 126962: Animate lock screen initialization

2016-02-02 Thread Marco Martin
> On Feb. 2, 2016, 7:34 p.m., Marco Martin wrote: > > h, wait!!one!It's animated already, you are animating it two times :) > > look at LookScreenUi.qml. > > it's already fading in. It's not visible because it was units.shortDuration > > and that is a moment of high CPU load so frames are sk

Re: Review Request 126962: Animate lock screen initialization

2016-02-02 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126962/#review91987 --- h, wait!!one!It's animated already, you are animating it

Re: Review Request 126949: Remove Air and Oxygen themes

2016-02-02 Thread Marco Martin
> On Feb. 2, 2016, 9:17 a.m., Marco Martin wrote: > > maybe not oxygen, but i want to point out that i *do* maintain the Air theme > > Martin Klapetek wrote: > Then we got some fixing to do as this is how Air looks like here: > http://paste.opensuse.org/view/raw/6071be9f (also notice the bo

KActivities split, 2nd phase

2016-02-02 Thread Ivan Čukić
Hi all, The libraries have mostly been split - we now have three repositories: - kactivities (the framework) - kactivities-stats (another framework, under review atm) - kactivitymanagerd (the service) The kactivities repository still contains all the code. After 5.17 is tagged, I'll turn the flag

Re: Review Request 126949: Remove Air and Oxygen themes

2016-02-02 Thread Martin Klapetek
> On Feb. 2, 2016, 10:17 a.m., Marco Martin wrote: > > maybe not oxygen, but i want to point out that i *do* maintain the Air theme > > Martin Klapetek wrote: > Then we got some fixing to do as this is how Air looks like here: > http://paste.opensuse.org/view/raw/6071be9f (also notice the b

Re: Review Request 126949: Remove Air and Oxygen themes

2016-02-02 Thread Marco Martin
> On Feb. 2, 2016, 9:17 a.m., Marco Martin wrote: > > maybe not oxygen, but i want to point out that i *do* maintain the Air theme > > Martin Klapetek wrote: > Then we got some fixing to do as this is how Air looks like here: > http://paste.opensuse.org/view/raw/6071be9f (also notice the bo

Re: Review Request 126949: Remove Air and Oxygen themes

2016-02-02 Thread Martin Klapetek
> On Feb. 2, 2016, 10:17 a.m., Marco Martin wrote: > > maybe not oxygen, but i want to point out that i *do* maintain the Air theme > > Martin Klapetek wrote: > Then we got some fixing to do as this is how Air looks like here: > http://paste.opensuse.org/view/raw/6071be9f (also notice the b

Re: Review Request 126962: Animate lock screen initialization

2016-02-02 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126962/#review91981 --- lookandfeel/contents/lockscreen/LockScreen.qml (line 55)

Re: Review Request 126949: Remove Air and Oxygen themes

2016-02-02 Thread Marco Martin
> On Feb. 2, 2016, 9:17 a.m., Marco Martin wrote: > > maybe not oxygen, but i want to point out that i *do* maintain the Air theme > > Martin Klapetek wrote: > Then we got some fixing to do as this is how Air looks like here: > http://paste.opensuse.org/view/raw/6071be9f (also notice the bo

Re: Review Request 126968: Morphingpopups effect, to animate tooltips

2016-02-02 Thread Thomas Lübking
> On Feb. 2, 2016, 4:40 p.m., Thomas Lübking wrote: > > effects/morphingpopups/package/contents/code/morphingpopups.js, line 29 > > > > > > backtrace? > > Martin Gräßlin wrote: > I just created a test case fo

Re: Review Request 126962: Animate lock screen initialization

2016-02-02 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126962/#review91978 --- Ship it! Ship It! - Martin Gräßlin On Feb. 2, 2016, 4:1

Re: Review Request 126968: Morphingpopups effect, to animate tooltips

2016-02-02 Thread Martin Gräßlin
> On Feb. 2, 2016, 5:40 p.m., Thomas Lübking wrote: > > effects/morphingpopups/package/contents/code/morphingpopups.js, line 29 > > > > > > backtrace? I just created a test case for it: https://paste.kde.org/pywv

Re: Review Request 126949: Remove Air and Oxygen themes

2016-02-02 Thread Marco Martin
> On Feb. 2, 2016, 9:17 a.m., Marco Martin wrote: > > maybe not oxygen, but i want to point out that i *do* maintain the Air theme > > Martin Klapetek wrote: > Then we got some fixing to do as this is how Air looks like here: > http://paste.opensuse.org/view/raw/6071be9f (also notice the bo

Re: Review Request 126968: Morphingpopups effect, to animate tooltips

2016-02-02 Thread Thomas Lübking
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126968/#review91965 --- effects/morphingpopups/package/contents/code/morphingpopups.

Re: Review Request 126949: Remove Air and Oxygen themes

2016-02-02 Thread Marco Martin
> On Feb. 2, 2016, 9:17 a.m., Marco Martin wrote: > > maybe not oxygen, but i want to point out that i *do* maintain the Air theme > > Martin Klapetek wrote: > Then we got some fixing to do as this is how Air looks like here: > http://paste.opensuse.org/view/raw/6071be9f (also notice the bo

Re: Review Request 126949: Remove Air and Oxygen themes

2016-02-02 Thread Marco Martin
> On Feb. 2, 2016, 9:17 a.m., Marco Martin wrote: > > maybe not oxygen, but i want to point out that i *do* maintain the Air theme > > Martin Klapetek wrote: > Then we got some fixing to do as this is how Air looks like here: > http://paste.opensuse.org/view/raw/6071be9f (also notice the bo

Re: Review Request 126949: Remove Air and Oxygen themes

2016-02-02 Thread Martin Klapetek
> On Feb. 2, 2016, 10:17 a.m., Marco Martin wrote: > > maybe not oxygen, but i want to point out that i *do* maintain the Air theme > > Martin Klapetek wrote: > Then we got some fixing to do as this is how Air looks like here: > http://paste.opensuse.org/view/raw/6071be9f (also notice the b

Re: Review Request 126949: Remove Air and Oxygen themes

2016-02-02 Thread Marco Martin
> On Feb. 2, 2016, 9:17 a.m., Marco Martin wrote: > > maybe not oxygen, but i want to point out that i *do* maintain the Air theme > > Martin Klapetek wrote: > Then we got some fixing to do as this is how Air looks like here: > http://paste.opensuse.org/view/raw/6071be9f (also notice the bo

Review Request 126970: gtk.css points to nonexistent files (bad filename)

2016-02-02 Thread Gustavo Alvarez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126970/ --- Review request for Plasma. Bugs: 356395 https://bugs.kde.org/show_bug

Re: Review Request 126949: Remove Air and Oxygen themes

2016-02-02 Thread Martin Klapetek
> On Feb. 2, 2016, 10:17 a.m., Marco Martin wrote: > > maybe not oxygen, but i want to point out that i *do* maintain the Air theme > > Martin Klapetek wrote: > Then we got some fixing to do as this is how Air looks like here: > http://paste.opensuse.org/view/raw/6071be9f (also notice the b

Re: Review Request 126949: Remove Air and Oxygen themes

2016-02-02 Thread Martin Klapetek
> On Feb. 2, 2016, 10:17 a.m., Marco Martin wrote: > > maybe not oxygen, but i want to point out that i *do* maintain the Air theme > > Martin Klapetek wrote: > Then we got some fixing to do as this is how Air looks like here: > http://paste.opensuse.org/view/raw/6071be9f (also notice the b

Re: Review Request 126949: Remove Air and Oxygen themes

2016-02-02 Thread Marco Martin
> On Feb. 2, 2016, 9:17 a.m., Marco Martin wrote: > > maybe not oxygen, but i want to point out that i *do* maintain the Air theme > > Martin Klapetek wrote: > Then we got some fixing to do as this is how Air looks like here: > http://paste.opensuse.org/view/raw/6071be9f (also notice the bo

Re: Review Request 126949: Remove Air and Oxygen themes

2016-02-02 Thread Marco Martin
> On Feb. 2, 2016, 9:17 a.m., Marco Martin wrote: > > maybe not oxygen, but i want to point out that i *do* maintain the Air theme > > Martin Klapetek wrote: > Then we got some fixing to do as this is how Air looks like here: > http://paste.opensuse.org/view/raw/6071be9f (also notice the bo

Re: Review Request 126949: Remove Air and Oxygen themes

2016-02-02 Thread andreas kainz
> On Feb. 2, 2016, 9:17 vorm., Marco Martin wrote: > > maybe not oxygen, but i want to point out that i *do* maintain the Air theme > > Martin Klapetek wrote: > Then we got some fixing to do as this is how Air looks like here: > http://paste.opensuse.org/view/raw/6071be9f (also notice the b

Re: Review Request 126949: Remove Air and Oxygen themes

2016-02-02 Thread Thomas Pfeiffer
> On Feb. 1, 2016, 8:12 p.m., andreas kainz wrote: > > Hi, I know I say I will keep oxygen-icons5 up to date, and I hope I get the > > time I need the plasma oxygen theme too to give the user the one single > > click feature (look & feel package). Is there an space where you can move > > "unma

Re: Review Request 126961: Fix the infamous Plasma::Applet::Actions crash

2016-02-02 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126961/#review91962 --- Ship it! Ship It! - Sebastian Kügler On Feb. 2, 2016, 3

Re: Plasma Bugs - a stricter approach

2016-02-02 Thread Aleix Pol
On Mon, Feb 1, 2016 at 10:49 PM, David Edmundson wrote: > I am sick of the current distribution of Plasma bug triage/fixing. [1]. I've > brought it up many many times in every meeting and no-one has done anything > except talk. > > Bugs are the most important part of making a quality product, whic

Re: Review Request 126949: Remove Air and Oxygen themes

2016-02-02 Thread Boudhayan Gupta
> On Feb. 2, 2016, 1:42 a.m., andreas kainz wrote: > > Hi, I know I say I will keep oxygen-icons5 up to date, and I hope I get the > > time I need the plasma oxygen theme too to give the user the one single > > click feature (look & feel package). Is there an space where you can move > > "unma

Review Request 126962: Animate lock screen initialization

2016-02-02 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126962/ --- Review request for Plasma. Repository: plasma-workspace Description ---

Re: Review Request 126949: Remove Air and Oxygen themes

2016-02-02 Thread Martin Klapetek
> On Feb. 2, 2016, 10:17 a.m., Marco Martin wrote: > > maybe not oxygen, but i want to point out that i *do* maintain the Air theme Then we got some fixing to do as this is how Air looks like here: http://paste.opensuse.org/view/raw/6071be9f (also notice the bottom frame of the controls) I ca

Re: Review Request 126949: Remove Air and Oxygen themes

2016-02-02 Thread Thomas Pfeiffer
> On Feb. 1, 2016, 8:12 p.m., andreas kainz wrote: > > Hi, I know I say I will keep oxygen-icons5 up to date, and I hope I get the > > time I need the plasma oxygen theme too to give the user the one single > > click feature (look & feel package). Is there an space where you can move > > "unma

Re: Review Request 126961: Fix the infamous Plasma::Applet::Actions crash

2016-02-02 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126961/ --- (Updated Feb. 2, 2016, 3 p.m.) Review request for Plasma. Bugs: 351777

Re: Plasma Bugs - a stricter approach

2016-02-02 Thread Marco Martin
On Monday 01 February 2016 21:49:51 David Edmundson wrote: > I am sick of the current distribution of Plasma bug triage/fixing. [1]. > I've brought it up many many times in every meeting and no-one has done > anything except talk. > > Bugs are the most important part of making a quality product, w

[Powerdevil] [Bug 349750] Laptop does not suspend when lid closed in lock screen

2016-02-02 Thread Aleix Pol via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=349750 Aleix Pol changed: What|Removed |Added Status|UNCONFIRMED |NEEDSINFO Resolution|---

[Powerdevil] [Bug 349750] Laptop does not suspend when lid closed in lock screen

2016-02-02 Thread Aleix Pol via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=349750 Aleix Pol changed: What|Removed |Added CC||aleix...@kde.org --- Comment #4 from Aleix Pol ---

Re: Review Request 126961: Fix the infamous Plasma::Applet::Actions crash

2016-02-02 Thread Sebastian Kügler
> On Feb. 2, 2016, 12:43 p.m., Sebastian Kügler wrote: > > shell/shellcorona.cpp, line 629 > > > > > > m_screenConfiguration may still be a nullptr here, since it's set only > > after GetConfigOperation returns.

Re: Review Request 126961: Fix the infamous Plasma::Applet::Actions crash

2016-02-02 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126961/ --- (Updated Feb. 2, 2016, 3:17 p.m.) Review request for Plasma. Bugs: 3517

Minutes Monday Plasma Meeting

2016-02-02 Thread Sebastian Kügler
I entirely forgot sending the notes, here you go! Minutes Plasma 'hangout', 1-2-2016, 12:00 CET Present: notmart, kbroulik, mgraesslin, sebas Excused: bshah, others have been attending FOSDEM last weekend mgraesslin: - new shader cleanups are merged in kwin, not possible anymore to override sh

Re: Review Request 126968: Morphingpopups effect, to animate tooltips

2016-02-02 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126968/ --- (Updated Feb. 2, 2016, 2:04 p.m.) Review request for kwin and Plasma. B

Re: Review Request 126968: Morphingpopups effect, to animate tooltips

2016-02-02 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126968/#review91950 --- effects/morphingpopups/package/metadata.desktop (line 2)

Review Request 126968: Morphingpopups effect, to animate tooltips

2016-02-02 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126968/ --- Review request for kwin and Plasma. Repository: kwin Description --

Re: Review Request 126961: Fix the infamous Plasma::Applet::Actions crash

2016-02-02 Thread David Edmundson
> On Feb. 2, 2016, 12:43 p.m., Sebastian Kügler wrote: > > shell/shellcorona.cpp, line 629 > > > > > > m_screenConfiguration may still be a nullptr here, since it's set only > > after GetConfigOperation returns.

Re: Review Request 126961: Fix the infamous Plasma::Applet::Actions crash

2016-02-02 Thread Sebastian Kügler
> On Feb. 2, 2016, 12:43 p.m., Sebastian Kügler wrote: > > shell/shellcorona.cpp, line 629 > > > > > > m_screenConfiguration may still be a nullptr here, since it's set only > > after GetConfigOperation returns.

Re: Review Request 126961: Fix the infamous Plasma::Applet::Actions crash

2016-02-02 Thread David Edmundson
> On Feb. 2, 2016, 12:43 p.m., Sebastian Kügler wrote: > > shell/shellcorona.cpp, line 629 > > > > > > m_screenConfiguration may still be a nullptr here, since it's set only > > after GetConfigOperation returns.

Re: Review Request 126961: Fix the infamous Plasma::Applet::Actions crash

2016-02-02 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126961/#review91946 --- shell/shellcorona.cpp (line 629)

Re: Review Request 126960: [Calendar] Add proper back/forward buttons and a "Today" button

2016-02-02 Thread Sebastian Kügler
> On Feb. 2, 2016, 9:22 a.m., Marco Martin wrote: > > hmm, i don't think i like the back/forward buttons both at the right, it > > looked more nicely symmetric before > > Kai Uwe Broulik wrote: > It also reduces mouse travel :) Placing the "Previous" button left of the > month name would l

Re: Review Request 126946: ShowDesktop is not synchronized

2016-02-02 Thread Martin Gräßlin
> On Feb. 2, 2016, 1:54 a.m., Sebastian Kügler wrote: > > Ship It! > > Sebastian Kügler wrote: > For bonus points, you could check if there's any X11 usage in the applet > otherwise, and if not, remove the m_isX11 and HAVE_X11 conditionals. This is > nicely abstracted in KWindowSystem now,

Re: Review Request 126960: [Calendar] Add proper back/forward buttons and a "Today" button

2016-02-02 Thread Kai Uwe Broulik
> On Feb. 2, 2016, 9:22 vorm., Marco Martin wrote: > > hmm, i don't think i like the back/forward buttons both at the right, it > > looked more nicely symmetric before It also reduces mouse travel :) Placing the "Previous" button left of the month name would look strange. Not a huge fan of hav

Re: Review Request 126956: [Desktop Containment] Remove custom tooltip delegate

2016-02-02 Thread Marco Martin
> On Feb. 2, 2016, 9:24 a.m., Marco Martin wrote: > > what did custom tooltip offered over the standard ones? > > > > folder tooltips are full on folderview and i understand that. > > what was the particularity of standard tooltips? > > Kai Uwe Broulik wrote: > Nothing. They didn't have big

Re: Review Request 126961: Fix the infamous Plasma::Applet::Actions crash

2016-02-02 Thread Martin Gräßlin
> On Feb. 2, 2016, 10:25 a.m., Marco Martin wrote: > > Ship It! > > Marco Martin wrote: > related to this, what could be a timeframe to depend from 5.6 (and > finally use the famous qscreen patch?) best we discuss it on the mailing list. My suggestion would be ASAP, on the day of the rele

Re: Review Request 126956: [Desktop Containment] Remove custom tooltip delegate

2016-02-02 Thread Kai Uwe Broulik
> On Feb. 2, 2016, 9:24 vorm., Marco Martin wrote: > > what did custom tooltip offered over the standard ones? > > > > folder tooltips are full on folderview and i understand that. > > what was the particularity of standard tooltips? Nothing. They didn't have bigger thumbnails or more informati

Re: Review Request 126952: Set layout in kickoff config properly

2016-02-02 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126952/#review91931 --- applets/kickoff/package/contents/ui/ConfigGeneral.qml

Re: Review Request 126956: [Desktop Containment] Remove custom tooltip delegate

2016-02-02 Thread Marco Martin
> On Feb. 2, 2016, 3:13 a.m., Martin Klapetek wrote: > > > I don't see why we would need this. > > > > Eike will be back in 8 days, I guess we should wait for his input on why > > this is needed. +1 - Marco --- This is an automaticall

Re: Review Request 126961: Fix the infamous Plasma::Applet::Actions crash

2016-02-02 Thread Marco Martin
> On Feb. 2, 2016, 9:25 a.m., Marco Martin wrote: > > Ship It! related to this, what could be a timeframe to depend from 5.6 (and finally use the famous qscreen patch?) - Marco --- This is an automatically generated e-mail. To reply, v

Re: Review Request 126961: Fix the infamous Plasma::Applet::Actions crash

2016-02-02 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126961/#review91928 --- Ship it! Ship It! - Marco Martin On Feb. 1, 2016, 11:08

Re: Review Request 126956: [Desktop Containment] Remove custom tooltip delegate

2016-02-02 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126956/#review91927 --- what did custom tooltip offered over the standard ones? fold

Re: Review Request 126960: [Calendar] Add proper back/forward buttons and a "Today" button

2016-02-02 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126960/#review91926 --- hmm, i don't think i like the back/forward buttons both at th

Re: Review Request 126949: Remove Air and Oxygen themes

2016-02-02 Thread Marco Martin
> On Feb. 1, 2016, 8:12 p.m., andreas kainz wrote: > > Hi, I know I say I will keep oxygen-icons5 up to date, and I hope I get the > > time I need the plasma oxygen theme too to give the user the one single > > click feature (look & feel package). Is there an space where you can move > > "unma

Re: Review Request 126949: Remove Air and Oxygen themes

2016-02-02 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126949/#review91924 --- maybe not oxygen, but i want to point out that i *do* maintai

Re: Review Request 126953: Remove Theme Details KCM

2016-02-02 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126953/#review91923 --- Ship it! I always wanted to kill that thing! I was a bit s

Re: Review Request 126947: [Shell] Make Applet/ContainmentConfig transient for DesktopView

2016-02-02 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126947/#review91921 --- Ship it! Ship It! - Marco Martin On Feb. 1, 2016, 9:06

Re: Review Request 126949: Remove Air and Oxygen themes

2016-02-02 Thread andreas kainz
> On Feb. 1, 2016, 8:12 nachm., andreas kainz wrote: > > Hi, I know I say I will keep oxygen-icons5 up to date, and I hope I get the > > time I need the plasma oxygen theme too to give the user the one single > > click feature (look & feel package). Is there an space where you can move > > "un

Re: Review Request 126949: Remove Air and Oxygen themes

2016-02-02 Thread Kai Uwe Broulik
> On Feb. 1, 2016, 8:12 nachm., andreas kainz wrote: > > Hi, I know I say I will keep oxygen-icons5 up to date, and I hope I get the > > time I need the plasma oxygen theme too to give the user the one single > > click feature (look & feel package). Is there an space where you can move > > "un