----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126953/#review91923 -----------------------------------------------------------
Ship it! I always wanted to kill that thing! I was a bit scared of the potential reaction.. let's see :D - Marco Martin On Feb. 1, 2016, 8:15 p.m., Kai Uwe Broulik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126953/ > ----------------------------------------------------------- > > (Updated Feb. 1, 2016, 8:15 p.m.) > > > Review request for Plasma, KDE Usability and Andrew Lake. > > > Repository: plasma-desktop > > > Description > ------- > > This removes the theme editor thing in the Desktop Theme KCM. > > Most settings in there are either broken or useless nowadays. > > The only setting I would miss is different Analog Clock faces which could be > done in the Analog Clock directly. What I am missing in general is a custom > Panel color/texture or something like that which we don't have in here anyway. > > > Diffs > ----- > > kcms/desktoptheme/CMakeLists.txt 6168686 > kcms/desktoptheme/DesktopTheme.ui f57cdf8 > kcms/desktoptheme/DesktopThemeDetails.ui 9df3536 > kcms/desktoptheme/desktopthemedetails.h 475d893 > kcms/desktoptheme/desktopthemedetails.cpp ce5c856 > kcms/desktoptheme/kcm_desktoptheme_debug.h e3363f0 > kcms/desktoptheme/kcm_desktoptheme_debug.cpp e09e839 > kcms/desktoptheme/kcmdesktoptheme.h ac87862 > kcms/desktoptheme/kcmdesktoptheme.cpp 8991990 > kcms/desktoptheme/thememodel.cpp bb5bb94 > > Diff: https://git.reviewboard.kde.org/r/126953/diff/ > > > Testing > ------- > > Tab gone. > > While at it I also replaced the status label with a proper KMessageWidget > > > File Attachments > ---------------- > > Screenshot > > https://git.reviewboard.kde.org/media/uploaded/files/2016/02/01/ddff6657-da2d-4fef-8dc1-872588e967b5__simplifiedthemesettings.png > > > Thanks, > > Kai Uwe Broulik > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
