[Differential] [Commented On] D797: Require user to authenticate when trying to change lock screen settings

graesslin added a comment. I disagree on the point that if a malicious process is already running the lock screen is the least to worry about. It's one of the items to worry about and I'm trying to fix them all. It's just the first I picked. Why is this one important: because it doesn't need a

Re: Review Request 126730: cleanup sddm kcm

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126730/#review90984 --- Ship it! src/themesdelegate.cpp (line 134)

Re: Review Request 126730: cleanup sddm kcm

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126730/ --- (Updated Jan. 13, 2016, 12:21 a.m.) Review request for Plasma and Heiko T

Re: Review Request 126730: cleanup sddm kcm

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126730/ --- (Updated Jan. 13, 2016, 12:13 a.m.) Review request for Plasma and Heiko T

Review Request 126730: cleanup sddm kcm

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126730/ --- Review request for Plasma and Heiko Tietze. Repository: sddm-kcm Descri

[Differential] [Updated] D797: Require user to authenticate when trying to change lock screen settings

colomar added a comment. I must say that I am not happy with this solution, either. I agree with David: If there is a malicious process running, the lock screen is likely the least problem the user has to worry about. Why switch off lock screen and wait until I have unobserved //physical access/

[Differential] [Commented On] D797: Require user to authenticate when trying to change lock screen settings

davidedmundson added a comment. > I must agree with David on this, generally having root own files in /home is > a terrible idea. Note it's not actually root owned. It gets set back to being owned by the user but with "chattr -i" set by root. REPOSITORY rKSCREENLOCKER KScreenLocker REVISI

Re: Review Request 126727: [plasmaquick/dialog] Don't use KWindowEffects for Notification window type

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126727/#review90976 --- Ship it! Ship It! - David Edmundson On Jan. 12, 2016, 6:18

[Differential] [Commented On] D797: Require user to authenticate when trying to change lock screen settings

mak added a subscriber: mak. mak added a comment. In https://phabricator.kde.org/D797#15210, @davidedmundson wrote: > This breaks every user's backup script by having root files in the user's > home. So I am very much not happy with this idea at all. > Especially as it acheives very little anyw

[Differential] [Commented On] D797: Require user to authenticate when trying to change lock screen settings

davidedmundson added a comment. In fact with this, you can now never remove a user. That's definitely a blocker > When set, prevents, even the superuser, from erasing or changing the contents > of the file. INLINE COMMENTS auth-helper/kscreenlockerauthhelper.cpp:94 Unintuitively, you're b

Review Request 126727: [plasmaquick/dialog] Don't use KWindowEffects for Notification window type

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126727/ --- Review request for KDE Frameworks and Plasma. Repository: plasma-framewor

[Differential] [Updated] D797: Require user to authenticate when trying to change lock screen settings

davidedmundson added a comment. This breaks every user's backup script by having root files in the user's home. So I am very much not happy with this idea at all. Especially as it acheives very little anyway, if you have a malicious app on your system - why on Earth does it want to modify your l

Jenkins-kde-ci: plasma-workspace Plasma-5.5 stable-kf5-qt5 » Linux,gcc - Build # 44 - Still Failing!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-workspace%20Plasma-5.5%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/44/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 12 Jan 2016 14:43:29 + Build duration: 3 min 31 sec CHANGE SET Revision 5836e35732b1caa81f2

Re: Review Request 126524: Fixed custom wallpaper being not respected by sddm.

> On Dec. 27, 2015, 4:37 p.m., David Edmundson wrote: > > sddmauthhelper.cpp, line 74 > > > > > > Ideally we should check the *calling* user can read this file, as you > > technically have a security bug. > >

[Differential] [Accepted] D782: Require Qt 5.5

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMAINTEGRATION Integration for Qt applications in Plasma BRANCH qt-increase-version REVISION DETAIL https://phabricator.kde.org/D782 EMAIL PREFERENCES https://phabri

Re: Review Request 126688: RFC: [Device Notifier] Provide inline feedback

> On Jan. 11, 2016, 8:12 nachm., Kai Uwe Broulik wrote: > > Someone suggested to style it like this: https://i.imgur.com/nPVhWr9.png > > > > While I'm not a huge fan of that excessive green background I agree that > > perhaps the message should be more prominently displayed, ie. moving back >

Re: Review Request 126688: RFC: [Device Notifier] Provide inline feedback

> On Jan. 11, 2016, 8:12 nachm., Kai Uwe Broulik wrote: > > Someone suggested to style it like this: https://i.imgur.com/nPVhWr9.png > > > > While I'm not a huge fan of that excessive green background I agree that > > perhaps the message should be more prominently displayed, ie. moving back >

[Differential] [Updated] D797: Require user to authenticate when trying to change lock screen settings

graesslin added a reviewer: colomar. REPOSITORY rKSCREENLOCKER KScreenLocker REVISION DETAIL https://phabricator.kde.org/D797 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, bshah, davidedmundson, colomar Cc: plasma-devel _

[Differential] [Commented On] D797: Require user to authenticate when trying to change lock screen settings

graesslin added a comment. Another required change will be to mark the config file as immutable on startup if it isn't already. I haven't included this yet as I want to get the basic concept reviewed first. INLINE COMMENTS auth-helper/kscreenlockerauthhelper.cpp:34 As this is a linux-ism we

[Differential] [Request, 260 lines] D797: Require user to authenticate when trying to change lock screen settings

graesslin created this revision. graesslin added reviewers: bshah, davidedmundson. graesslin added a subscriber: plasma-devel. REVISION SUMMARY The idea behind this change is to make it impossible for a malicious process to just disable the lock screen. To achieve that modifying the lock scr

wallpaper and splash

Thanks for the 5.6 wallpaper Ken, is anyone remembering to update the splash screen to match? we always seem to get stuck doing that at the last minute Jonathan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plas

Re: Review Request 126720: Adds QML's PlasmaCore.SVG CustomColor feature

> On Jan. 11, 2016, 6:35 p.m., Marco Martin wrote: > > src/plasma/svg.cpp, line 164 > > > > > > coding style: > > void SvgPrivate::updateCustomStyleCrc() > > { > > Nico Rodsevich wrote: > I don't tot

Re: Review Request 126720: Adds QML's PlasmaCore.SVG CustomColor feature

On Jan. 12, 2016, 1:19 a.m., Nico Rodsevich wrote: > > Sorry if I missed something, but doesn't this patch makes themes creation > > even harder? :/ yes, pieces with an hardcoded color wouldn't be affected by the color in the themes, so would be to be used with care. that's also why i wanted t