----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126730/#review90984 -----------------------------------------------------------
Ship it! src/themesdelegate.cpp (line 134) <https://git.reviewboard.kde.org/r/126730/#comment62151> do't write "*1" just delete that bit - David Edmundson On Jan. 13, 2016, 12:21 a.m., andreas kainz wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126730/ > ----------------------------------------------------------- > > (Updated Jan. 13, 2016, 12:21 a.m.) > > > Review request for Plasma and Heiko Tietze. > > > Repository: sddm-kcm > > > Description > ------- > > remove the webpage and the author in the overview cause this is shown in the > preview section. > > > Diffs > ----- > > src/themesdelegate.cpp 1b528a0 > src/ui/advanceconfig.ui e7fcb97 > src/ui/themeconfig.ui 33cc685 > > Diff: https://git.reviewboard.kde.org/r/126730/diff/ > > > Testing > ------- > > after this cleanup there is one point open but therefore I need someone with > real coding skills. > > KCM HIG > https://community.kde.org/KDE_Visual_Design_Group/System_Settings_Application > > don't use tabs -> add an more button. > > So you have an select area and an preview area as in my point of view the > Auto Login is an "standard setting" I would add the auto login section on > bottom of the select area. > On the bottom page you have an botton > - use userdefined background > - advanced setting > - import from file (now not available) > - import from GHNS (now not available) > > > File Attachments > ---------------- > > sddm-kcm.png > > https://git.reviewboard.kde.org/media/uploaded/files/2016/01/13/483cf282-99b2-4c26-ab51-0d415d3fdf5e__sddm-kcm.png > > > Thanks, > > andreas kainz > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
