Re: Review Request 125266: Authentication with certificates / Make MRU/MTU editable / Dialog fix

> On Dez. 13, 2015, 12:50 vorm., Lamarque Souza wrote: > > vpn/l2tp/l2tpwidget.cpp, line 107 > > > > > > Use QStringLiteral("yes") instead of just "yes". Add brackets after the > > parentesis and space after if.

Re: Review Request 125266: Authentication with certificates / Make MRU/MTU editable / Dialog fix

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125266/#review89404 --- vpn/l2tp/l2twidget.cpp (line 107)

Re: Review Request 126320: Read KPluginMetada's property X-Plasma-ComponentTypes as a stringlist

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126320/#review89394 --- +1, this also fixes plasma on mobile CI - Bhushan Shah On D

Re: Review Request 126185: Make the KAppTemplate CMake module global

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126185/#review89391 --- Ooh, also, please write a unit test. I can help with that if y

Re: Review Request 126185: Make the KAppTemplate CMake module global

> On Dec. 12, 2015, 3:35 p.m., Alex Merry wrote: > > kde-modules/KDETemplateGenerator.cmake, line 52 > > > > > > Honestly, I'd just use ARG as the prefix - you're in a function, it's > > not going to leak anyway.

Re: Review Request 126185: Make the KAppTemplate CMake module global

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126185/#review89388 --- We're getting there :-). kde-modules/KDEInstallDirs.cmake (l