> On Dec. 12, 2015, 3:35 p.m., Alex Merry wrote: > > kde-modules/KDETemplateGenerator.cmake, line 52 > > <https://git.reviewboard.kde.org/r/126185/diff/4/?file=421458#file421458line52> > > > > Honestly, I'd just use ARG as the prefix - you're in a function, it's > > not going to leak anyway. That means you can refer to ARG_TEMPLATES, which > > is both shorter and more descriptive. > > > > You should also check for unparsed arguments, and for the TEMPLATES > > argument being missing or empty. See, eg, ECMAddAppIcon.cmake for how to do > > this.
Oops, missed one thing here - you need to ``include(CMakeParseArguments)`` earlier in the file. - Alex ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126185/#review89388 ----------------------------------------------------------- On Dec. 9, 2015, 12:12 p.m., Marco Martin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126185/ > ----------------------------------------------------------- > > (Updated Dec. 9, 2015, 12:12 p.m.) > > > Review request for Build System, KDE Frameworks, Plasma, Aleix Pol Gonzalez, > and Simon Wächter. > > > Repository: extra-cmake-modules > > > Description > ------- > > templates are very useful as teaching tool in order to make > a minimal application that uses a certain framework. > templates in the KAppTemplate repository will always get forgotten > (plus kapptemplate is not really necessary as they work in kdevelop as well) > An ideal situation would be frameworks having templates in their own repos > with templates of barebone apps using the main framework features. > In order to do that, the cmake stuff needed in order to correctly install > a template needs to be ported to a place avaiable to all frameworks > > > Diffs > ----- > > kde-modules/KDETemplateGenerator.cmake PRE-CREATION > kde-modules/KDEInstallDirs.cmake b7cd34d > > Diff: https://git.reviewboard.kde.org/r/126185/diff/ > > > Testing > ------- > > done some templates installed by plasma-framework > > > Thanks, > > Marco Martin > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
