Re: Review Request 125117: Moved check for all mount points excluded out of widget class

> On Sept. 16, 2015, 12:37 a.m., Vishesh Handa wrote: > > kcms/baloo/kcm.cpp, line 168 > > > > > > I'm really not too sure about this. So the display name is taken and > > that is compared with the mountPoint? >

Re: Review Request 125117: Moved check for all mount points excluded out of widget class

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125117/ --- (Updated Sept. 22, 2015, 10:24 p.m.) Review request for Baloo, Plasma and

Re: Review Request 125117: Moved check for all mount points excluded out of widget class

> On Sept. 15, 2015, 9:37 nachm., Vishesh Handa wrote: > > kcms/baloo/kcm.cpp, line 168 > > > > > > I'm really not too sure about this. So the display name is taken and > > that is compared with the mountPoint?

Re: Review Request 125117: Moved check for all mount points excluded out of widget class

> On Sept. 16, 2015, 12:37 a.m., Vishesh Handa wrote: > > kcms/baloo/kcm.cpp, line 168 > > > > > > I'm really not too sure about this. So the display name is taken and > > that is compared with the mountPoint? >

Re: Review Request 125307: Add option for desktoptheme to set preferred icon theme

> On Sept. 22, 2015, 11:55 a.m., Marco Martin wrote: > > not sure about it, as it would only change the behavior of IconItem but not > > QIconItem, that is the most used for various reasons, so the two would end > > up using different themes > > David Rosca wrote: > I found only 8 instance

Re: Review Request 125307: Add option for desktoptheme to set preferred icon theme

> On Sept. 22, 2015, 11:55 a.m., Marco Martin wrote: > > not sure about it, as it would only change the behavior of IconItem but not > > QIconItem, that is the most used for various reasons, so the two would end > > up using different themes > > David Rosca wrote: > I found only 8 instance

Re: Review Request 125307: Add option for desktoptheme to set preferred icon theme

> On Sept. 22, 2015, 11:55 a.m., Marco Martin wrote: > > not sure about it, as it would only change the behavior of IconItem but not > > QIconItem, that is the most used for various reasons, so the two would end > > up using different themes > > David Rosca wrote: > I found only 8 instance

Re: Review Request 125349: use a RowLayout for ToolbarLayout

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125349/ --- (Updated Sept. 22, 2015, 2:35 p.m.) Review request for Plasma. Reposito

Re: Review Request 125349: use a RowLayout for ToolbarLayout

> On Sept. 22, 2015, 1:22 p.m., David Edmundson wrote: > > src/declarativeimports/plasmacomponents/qml/ToolBarLayout.qml, line 37 > > > > > > I would avoiding setting width and heights whilst in a RowLayout > >

Re: Review Request 125307: Add option for desktoptheme to set preferred icon theme

> On Sept. 22, 2015, 11:55 a.m., Marco Martin wrote: > > not sure about it, as it would only change the behavior of IconItem but not > > QIconItem, that is the most used for various reasons, so the two would end > > up using different themes > > David Rosca wrote: > I found only 8 instance

Re: Review Request 125349: use a RowLayout for ToolbarLayout

> On Sept. 22, 2015, 1:22 p.m., David Edmundson wrote: > > src/declarativeimports/plasmacomponents/qml/ToolBarLayout.qml, line 48 > > > > > > So to make sure I'm clear we want to get > > > > child[0] > >

Re: Review Request 125349: use a RowLayout for ToolbarLayout

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125349/#review85751 --- src/declarativeimports/plasmacomponents/qml/ToolBarLayout.qml

Re: Review Request 125307: Add option for desktoptheme to set preferred icon theme

> On Sept. 22, 2015, 11:55 a.m., Marco Martin wrote: > > not sure about it, as it would only change the behavior of IconItem but not > > QIconItem, that is the most used for various reasons, so the two would end > > up using different themes > > David Rosca wrote: > I found only 8 instance

Re: Review Request 125307: Add option for desktoptheme to set preferred icon theme

> On Sept. 22, 2015, 11:55 a.m., Marco Martin wrote: > > not sure about it, as it would only change the behavior of IconItem but not > > QIconItem, that is the most used for various reasons, so the two would end > > up using different themes > > David Rosca wrote: > I found only 8 instance

Re: Review Request 125307: Add option for desktoptheme to set preferred icon theme

> On Sept. 22, 2015, 11:55 a.m., Marco Martin wrote: > > not sure about it, as it would only change the behavior of IconItem but not > > QIconItem, that is the most used for various reasons, so the two would end > > up using different themes > > David Rosca wrote: > I found only 8 instance

Re: Review Request 125307: Add option for desktoptheme to set preferred icon theme

> On Sept. 22, 2015, 11:55 vorm., Marco Martin wrote: > > not sure about it, as it would only change the behavior of IconItem but not > > QIconItem, that is the most used for various reasons, so the two would end > > up using different themes > > David Rosca wrote: > I found only 8 instanc

Re: Review Request 125307: Add option for desktoptheme to set preferred icon theme

> On Sept. 22, 2015, 11:55 a.m., Marco Martin wrote: > > not sure about it, as it would only change the behavior of IconItem but not > > QIconItem, that is the most used for various reasons, so the two would end > > up using different themes > > David Rosca wrote: > I found only 8 instance

Review Request 125349: use a RowLayout for ToolbarLayout

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125349/ --- Review request for Plasma. Repository: plasma-framework Description ---

Re: Review Request 125307: Add option for desktoptheme to set preferred icon theme

> On Sept. 22, 2015, 11:55 a.m., Marco Martin wrote: > > not sure about it, as it would only change the behavior of IconItem but not > > QIconItem, that is the most used for various reasons, so the two would end > > up using different themes > > David Rosca wrote: > I found only 8 instance

Re: Review Request 125307: Add option for desktoptheme to set preferred icon theme

> On Sept. 22, 2015, 11:55 a.m., Marco Martin wrote: > > not sure about it, as it would only change the behavior of IconItem but not > > QIconItem, that is the most used for various reasons, so the two would end > > up using different themes I found only 8 instances: plasma-desktop/applets (3

Re: Review Request 125307: Add option for desktoptheme to set preferred icon theme

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125307/#review85747 --- not sure about it, as it would only change the behavior of Ico

Re: Review Request 125187: Stop requiring Frameworks 5.15

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125187/ --- (Updated Sept. 22, 2015, 8:23 a.m.) Status -- This change has been d