----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125349/#review85751 -----------------------------------------------------------
src/declarativeimports/plasmacomponents/qml/ToolBarLayout.qml (line 37) <https://git.reviewboard.kde.org/r/125349/#comment59253> I would avoiding setting width and heights whilst in a RowLayout as the Rowlayout will be overriding these properties at runtime so they're effectively ignored. src/declarativeimports/plasmacomponents/qml/ToolBarLayout.qml (line 48) <https://git.reviewboard.kde.org/r/125349/#comment59255> So to make sure I'm clear we want to get child[0] spacer1 child[1.....n-1] spacer2 child[n] - David Edmundson On Sept. 22, 2015, 12:08 p.m., Marco Martin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125349/ > ----------------------------------------------------------- > > (Updated Sept. 22, 2015, 12:08 p.m.) > > > Review request for Plasma. > > > Repository: plasma-framework > > > Description > ------- > > more reliable. > also put the first and last buttons at the extremes, the others in the middle > as briefly discussed with the VDG in Randa > > > Diffs > ----- > > src/declarativeimports/plasmacomponents/qml/ToolBarLayout.qml 4206bed > > Diff: https://git.reviewboard.kde.org/r/125349/diff/ > > > Testing > ------- > > > Thanks, > > Marco Martin > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
