> On Sept. 22, 2015, 11:55 a.m., Marco Martin wrote: > > not sure about it, as it would only change the behavior of IconItem but not > > QIconItem, that is the most used for various reasons, so the two would end > > up using different themes > > David Rosca wrote: > I found only 8 instances: plasma-desktop/applets (3 - kickoff, kicker), > plasma-workspace/applets (2 - only in config ui), kdeplasma-addons/applets (3 > - only in QtQuick1 code). > > So it is only used in kickoff/kicker and it should be safe to change it > to PlasmaCore.IconItem there (if there is not some special reason to use > QIconItem). > > Marco Martin wrote: > no, it should stay qiconitem. > since in those cases shouldn't use the svg icons from the paasma theme > and being iconitem more complicated, the difference in time in loading > submenus in kicker is distinguishable
Also I can see in that case bugreports of people complaining that plasma refuses to use their $favoriteicontheme they did set on systemsettings - Marco ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125307/#review85747 ----------------------------------------------------------- On Sept. 19, 2015, 8:48 a.m., David Rosca wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125307/ > ----------------------------------------------------------- > > (Updated Sept. 19, 2015, 8:48 a.m.) > > > Review request for Plasma. > > > Repository: plasma-framework > > > Description > ------- > > It is now possible to set preferred icon theme in desktoptheme > metadata.desktop. > > As discussed on ML, this fixes using light breeze icon theme with breeze dark > desktoptheme. > > > Diffs > ----- > > src/plasma/theme.cpp c49ad4c > src/plasma/private/theme_p.cpp 31a6512 > src/plasma/theme.h 3f49719 > src/desktoptheme/breeze/metadata.desktop 07bbfc3 > src/plasma/private/theme_p.h 5b8f71c > src/declarativeimports/core/iconitem.h 3ef0306 > src/declarativeimports/core/iconitem.cpp 692cd8d > src/desktoptheme/breeze-dark/metadata.desktop 77647a4 > > Diff: https://git.reviewboard.kde.org/r/125307/diff/ > > > Testing > ------- > > Icon theme is picked correctly with PlasmaCore.IconItem. Changing the > desktoptheme updates the icons. > > > Thanks, > > David Rosca > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
