Re: Review Request 125120: [wip] support for the slide protocol

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125120/#review85083 --- What I miss in general is support for removing the "property"

Re: Review Request 125120: [wip] support for the slide protocol

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125120/#review85082 --- I just pulled in the patch, but didn't hit the assert - Marti

Re: Review Request 124980: Add org.kde.plasma.private.sessions with a SessionModel

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124980/#review85080 --- components/sessionsprivate/sessionsmodel.cpp (line 30)

Review Request 125129: Update baloo's D-Bus interface name in KCM

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125129/ --- Review request for Plasma and Vishesh Handa. Repository: plasma-desktop

[Breeze] [Bug 352506] Breeze High Contrast color scheme has defaults that are bad for people with low contrast sensitivity vision

https://bugs.kde.org/show_bug.cgi?id=352506 Andrew Lake changed: What|Removed |Added CC||jamboar...@gmail.com Status|UNCONFIRM

[Breeze] [Bug 352506] New: Breeze High Contrast color scheme has defaults that are bad for people with low contrast sensitivity vision

https://bugs.kde.org/show_bug.cgi?id=352506 Bug ID: 352506 Summary: Breeze High Contrast color scheme has defaults that are bad for people with low contrast sensitivity vision Product: Breeze Version: 5.4.0

Re: Review Request 125063: fix for Bug 260869

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125063/ --- (Updated Sept. 9, 2015, 10:17 p.m.) Status -- This change has been m

Re: Review Request 125127: add discover to favorties

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125127/ --- (Updated Sept. 9, 2015, 10:17 p.m.) Status -- This change has been m

Re: Review Request 125127: add discover to favorties

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125127/#review85075 --- Ship it! +1 LGTM - Aleix Pol Gonzalez On Sept. 10, 2015, 1

Re: Review Request 125063: fix for Bug 260869

> On Sept. 9, 2015, 9:26 p.m., Martin Klapetek wrote: > > > > Martin Klapetek wrote: > Btw. do you have commit access? > > Raphael Kugelmann wrote: > I haven't tried it yet. > But I think I have no further access rights for the repo. > > Raphael Kugelmann wrote: > sorry for thi

Review Request 125127: add discover to favorties

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125127/ --- Review request for Plasma, Aleix Pol Gonzalez and David Edmundson. Reposi

Re: Review Request 125063: fix for Bug 260869

> On Sept. 9, 2015, 7:26 nachm., Martin Klapetek wrote: > > > > Martin Klapetek wrote: > Btw. do you have commit access? > > Raphael Kugelmann wrote: > I haven't tried it yet. > But I think I have no further access rights for the repo. > > Raphael Kugelmann wrote: > sorry for t

[Powerdevil] [Bug 352497] laptop back light not coming back on after long period of lcd being in dpms power save mode.

https://bugs.kde.org/show_bug.cgi?id=352497 Vladi changed: What|Removed |Added URL||https://bpaste.net/show/8c7 |

[Powerdevil] [Bug 352497] New: laptop back light not coming back on after long period of lcd being in dpms power save mode.

https://bugs.kde.org/show_bug.cgi?id=352497 Bug ID: 352497 Summary: laptop back light not coming back on after long period of lcd being in dpms power save mode. Product: Powerdevil Version: 5.4.1 Platform: Gentoo Packages

Re: Review Request 125063: fix for Bug 260869

> On Sept. 9, 2015, 7:26 nachm., Martin Klapetek wrote: > > > > Martin Klapetek wrote: > Btw. do you have commit access? > > Raphael Kugelmann wrote: > I haven't tried it yet. > But I think I have no further access rights for the repo. sorry for this annoying question. How does thi

Re: Review Request 125063: fix for Bug 260869

> On Sept. 9, 2015, 7:26 nachm., Martin Klapetek wrote: > > > > Martin Klapetek wrote: > Btw. do you have commit access? I haven't tried it yet. But I think I have no further access rights for the repo. - Raphael --- This is an aut

Re: Review Request 124980: Add org.kde.plasma.private.sessions with a SessionModel

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124980/ --- (Updated Sept. 9, 2015, 8:28 nachm.) Review request for Plasma and Martin

Re: Review Request 125063: fix for Bug 260869

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125063/ --- (Updated Sept. 9, 2015, 8:26 nachm.) Review request for Plasma. Changes

Re: Review Request 124923: Plasma 5 color picker plasmoid

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124923/ --- (Updated Sept. 9, 2015, 8:21 p.m.) Status -- This change has been ma

Re: Review Request 125119: support for the slide protocol

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125119/#review85067 --- src/windowsystem/waylandintegration.cpp (line 125)

Re: Review Request 125119: support for the slide protocol

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125119/ --- (Updated Sept. 9, 2015, 7:43 p.m.) Status -- This change has been ma

Re: Review Request 125119: support for the slide protocol

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125119/#review85066 --- Ship it! I really like how straight forward we get these thin

Review Request 125120: [wip] support for the slide protocol

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125120/ --- Review request for kwin and Plasma. Repository: kwin Description --

Re: Review Request 125063: fix for Bug 260869

> On Sept. 9, 2015, 9:26 p.m., Martin Klapetek wrote: > > Btw. do you have commit access? - Martin --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125063/#review85064 ---

Re: Review Request 125063: fix for Bug 260869

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125063/#review85064 --- Ship it! gui/SensorDisplayLib/FancyPlotter.cpp (line 295)

Review Request 125119: support for the slide protocol

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125119/ --- Review request for kwin and Plasma. Repository: kwayland-integration De

Review Request 125118: [Icon widget] support dropping onto folder

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125118/ --- Review request for Plasma, Bhushan Shah, Emmanuel Pescosta, and Eike Hein.

Review Request 125063: fix for Bug 260869

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125063/ --- Review request for Plasma. Repository: ksysguard Description --- B

Re: Review Request 125117: Moved check for all mount points excluded out of widget class

> On Sept. 9, 2015, 9:11 p.m., Martin Klapetek wrote: > > kcms/baloo/kcm.cpp, lines 174-177 > > > > > > This can also stay like it was, just do > > > > return excluded.toSet() == mountPoints.toSet(); > >

Re: Review Request 125117: Moved check for all mount points excluded out of widget class

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125117/ --- (Updated Sept. 9, 2015, 9:53 p.m.) Review request for Baloo, Plasma and V

Re: Review Request 125117: Moved check for all mount points excluded out of widget class

> On Sept. 9, 2015, 8:11 p.m., Martin Klapetek wrote: > > kcms/baloo/kcm.cpp, lines 174-177 > > > > > > This can also stay like it was, just do > > > > return excluded.toSet() == mountPoints.toSet(); > >

Re: Review Request 125117: Moved check for all mount points excluded out of widget class

> On Sept. 9, 2015, 9:11 p.m., Martin Klapetek wrote: > > kcms/baloo/kcm.cpp, line 167 > > > > > > const QStorageInfo &si > > Ovidiu-Florin BOGDAN wrote: > If I do that I get this: > > > /home/ovid

Re: Review Request 125117: Moved check for all mount points excluded out of widget class

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125117/ --- (Updated Sept. 9, 2015, 9:47 p.m.) Review request for Baloo, Plasma and V

Re: Review Request 125117: Moved check for all mount points excluded out of widget class

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125117/ --- (Updated Sept. 9, 2015, 9:45 p.m.) Review request for Baloo, Plasma and V

Re: Review Request 125117: Moved check for all mount points excluded out of widget class

> On Sept. 9, 2015, 9:11 p.m., Martin Klapetek wrote: > > kcms/baloo/kcm.cpp, line 167 > > > > > > const QStorageInfo &si If I do that I get this: /home/ovidiu/kde-devel/src/kde/workspace/plasma-desktop/kcms/ba

Re: Review Request 125117: Moved check for all mount points excluded out of widget class

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125117/#review85057 --- kcms/baloo/kcm.cpp (line 165)

Review Request 125117: Moved check for all mount points excluded out of widget class

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125117/ --- Review request for Baloo, Plasma and Vishesh Handa. Repository: plasma-de

Re: Review Request 125107: Renamed functions and variables for better Qt compliance and better description

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125107/ --- (Updated Sept. 9, 2015, 5:07 p.m.) Status -- This change has been ma

Re: Review Request 125110: two small fixes for kwaylandScanner

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125110/ --- (Updated Sept. 9, 2015, 3:53 p.m.) Status -- This change has been ma

Re: Review Request 125018: Support for Dpms

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125018/ --- (Updated Sept. 9, 2015, 3:49 p.m.) Status -- This change has been ma

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 172 - Successful!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/172/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 09 Sep 2015 11:40:47 + Build duration: 7 min 43 sec CHANGE SET Revision f3b2ecfe0d287084fc1f5b2b74dc358

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 171 - Aborted!

GENERAL INFO BUILD ABORTED Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/171/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 09 Sep 2015 10:10:54 + Build duration: 5.5 sec CHANGE SET Revision 3631b2482a1bd279350becee081bcdd506ce

Re: Review Request 125041: Move kaccess into separate source directory

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125041/ --- (Updated Sept. 9, 2015, 10:10 a.m.) Status -- This change has been m

Re: Review Request 124954: Add support for modifier only shortcuts on Wayland

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124954/ --- (Updated Sept. 9, 2015, 8:42 a.m.) Status -- This change has been ma

Re: Review Request 125113: [startkde] Generate absolute path to ksmserver

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125113/ --- (Updated Sept. 9, 2015, 8:41 a.m.) Status -- This change has been ma

Re: Review Request 125114: Add dedicated destructor requests to blur and contrast interface

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125114/ --- (Updated Sept. 9, 2015, 8:41 a.m.) Status -- This change has been ma

Re: Review Request 124981: RFC: Move context menu out of panel

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124981/ --- (Updated Sept. 9, 2015, 8:36 a.m.) Status -- This change has been ma

Re: Review Request 124954: Add support for modifier only shortcuts on Wayland

> On Sept. 7, 2015, 4:59 p.m., Thomas Lübking wrote: > > Hold it. > > > > Implementationwise, this looks wonky - if it's possible to get unbalanced > > input events (ie. releases w/o ever a press or vv.) from the system since > > the counter will run out of sync. > > > > => Are such unbalance

[Powerdevil] [Bug 352462] PowerDevilUPowerBackend makes unconditional call to xrandr extension

https://bugs.kde.org/show_bug.cgi?id=352462 Kai Uwe Broulik changed: What|Removed |Added Status|UNCONFIRMED |CONFIRMED CC|

Re: Review Request 125113: [startkde] Generate absolute path to ksmserver

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125113/#review85042 --- Ship it! Ship It! - Marco Martin On Sept. 9, 2015, 6:57 a.

Re: Review Request 124954: Add support for modifier only shortcuts on Wayland

> On Sept. 7, 2015, 2:59 nachm., Thomas Lübking wrote: > > Hold it. > > > > Implementationwise, this looks wonky - if it's possible to get unbalanced > > input events (ie. releases w/o ever a press or vv.) from the system since > > the counter will run out of sync. > > > > => Are such unbalan

Re: Review Request 125114: Add dedicated destructor requests to blur and contrast interface

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125114/#review85041 --- Ship it! Ship It! - Marco Martin On Sept. 9, 2015, 7:42 a.

Re: Review Request 125111: Change system settings toolbar

> On Sept. 8, 2015, 11:08 p.m., Martin Klapetek wrote: > > +1 for the icon change, but I dunno, "Help" not being the last thing looks > > strange...? > > andreas kainz wrote: > Hi the help icon was changed yesterday in master (by me without > reviewboard) so help use the right icon. > > M

Re: Review Request 125111: Change system settings toolbar

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125111/#review85039 --- +1 from here as well - Marco Martin On Sept. 8, 2015, 10:59

Review Request 125114: Add dedicated destructor requests to blur and contrast interface

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125114/ --- Review request for Plasma and Marco Martin. Repository: kwayland Descri

Re: Review Request 124954: Add support for modifier only shortcuts on Wayland

> On Sept. 7, 2015, 4:59 p.m., Thomas Lübking wrote: > > Hold it. > > > > Implementationwise, this looks wonky - if it's possible to get unbalanced > > input events (ie. releases w/o ever a press or vv.) from the system since > > the counter will run out of sync. > > > > => Are such unbalance

Re: Review Request 124954: Add support for modifier only shortcuts on Wayland

> On Sept. 7, 2015, 4:59 p.m., Thomas Lübking wrote: > > Hold it. > > > > Implementationwise, this looks wonky - if it's possible to get unbalanced > > input events (ie. releases w/o ever a press or vv.) from the system since > > the counter will run out of sync. > > > > => Are such unbalance