----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125120/#review85083 -----------------------------------------------------------
What I miss in general is support for removing the "property" again. effects/slidingpopups/slidingpopups.cpp (line 277) <https://git.reviewboard.kde.org/r/125120/#comment58835> this connect is dangerous: it doesn't have a context. It will fire after slide is unloaded -> crash. And it might fire also when the EffectWindow for the Surface would get destroyed. I suggest to change it to something like: connect(surf, &slideOnShowHideChanged, this, [this, surf] { slotThingy(effects->findWindow(surf); }); effects/slidingpopups/slidingpopups.cpp (lines 433 - 434) <https://git.reviewboard.kde.org/r/125120/#comment58836> on X11 the time might also come from the property. - Martin Gräßlin On Sept. 9, 2015, 9:27 p.m., Marco Martin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125120/ > ----------------------------------------------------------- > > (Updated Sept. 9, 2015, 9:27 p.m.) > > > Review request for kwin and Plasma. > > > Repository: kwin > > > Description > ------- > > take and apply thhe informations from the wayland slide protocol in the > sliding popups effect > > > Diffs > ----- > > effects/slidingpopups/slidingpopups.h ac3cf10 > effects/slidingpopups/slidingpopups.cpp f6d9ec5 > > Diff: https://git.reviewboard.kde.org/r/125120/diff/ > > > Testing > ------- > > slide to appear works, slide out to disappear doesn't. > > the second time a popup is opened, kwin crashes and an assert is hit > > kwin_wayland: > /home/diau/git/kf5/kde/workspace/kwin/libkwineffects/kwineffects.cpp:908: > KWin::WindowQuad KWin::WindowQuad::makeSubQuad(double, double, double, > double) const: Assertion `x1 < x2 && y1 < y2 && x1 >= left() && x2 <= right() > && y1 >= top() && y2 <= bottom()' failed. > > > Thanks, > > Marco Martin > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
