> On Sept. 8, 2015, 11:08 p.m., Martin Klapetek wrote: > > +1 for the icon change, but I dunno, "Help" not being the last thing looks > > strange...? > > andreas kainz wrote: > Hi the help icon was changed yesterday in master (by me without > reviewboard) so help use the right icon. > > Martin Klapetek wrote: > I have no problem with the Help icon, I just think that Help button being > before Configure is strange. > > Fwiw, in Dolphin, the Configure is a menu which also has the Help inside, > here it is a dialog. So I'm not entirely sure that this change makes sense. > ...add usability?
in Dolphin in "Control": in that case would make sense to stuff also the help button in it, while Configure->help would make no sense - Marco ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125111/#review85030 ----------------------------------------------------------- On Sept. 8, 2015, 10:59 p.m., David Edmundson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125111/ > ----------------------------------------------------------- > > (Updated Sept. 8, 2015, 10:59 p.m.) > > > Review request for Plasma and andreas kainz. > > > Repository: systemsettings > > > Description > ------- > > Move configure to right to match dolphin, remove somewhat non-standard quit > button. > > As requested by Andreas Kainz from VDG > > > Diffs > ----- > > app/SettingsBase.cpp 16018e45efe603b2f24f15017d1872838cc9f31e > app/systemsettingsui.rc e5ba899bf19bad5c3f8b92263a13015c7bd85f32 > > Diff: https://git.reviewboard.kde.org/r/125111/diff/ > > > Testing > ------- > > > File Attachments > ---------------- > > snapshot_TJ1820.png > > https://git.reviewboard.kde.org/media/uploaded/files/2015/09/08/1b07d64d-799f-4a2d-88ff-b006bbc3dd49__snapshot_TJ1820.png > > > Thanks, > > David Edmundson > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
