[Powerdevil] [Bug 352462] PowerDevilUPowerBackend makes unconditional call to xrandr extension

https://bugs.kde.org/show_bug.cgi?id=352462 Thomas Lübking changed: What|Removed |Added CC||ba...@grussling.com, |

Review Request 125113: [startkde] Generate absolute path to ksmserver

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125113/ --- Review request for Plasma. Repository: plasma-workspace Description ---

[Powerdevil] [Bug 352462] New: PowerDevilUPowerBackend makes unconditional call to xrandr extension

https://bugs.kde.org/show_bug.cgi?id=352462 Bug ID: 352462 Summary: PowerDevilUPowerBackend makes unconditional call to xrandr extension Product: Powerdevil Version: unspecified Platform: Other OS: Linux

Re: Review Request 125110: two small fixes for kwaylandScanner

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125110/#review85036 --- Ship it! nice catches, thanks - Martin Gräßlin On Sept. 8,

Re: Review Request 125111: Change system settings toolbar

> On Sept. 9, 2015, 1:08 a.m., Martin Klapetek wrote: > > +1 for the icon change, but I dunno, "Help" not being the last thing looks > > strange...? > > andreas kainz wrote: > Hi the help icon was changed yesterday in master (by me without > reviewboard) so help use the right icon. I have

Re: Review Request 125111: Change system settings toolbar

> On Sept. 8, 2015, 11:08 p.m., Martin Klapetek wrote: > > +1 for the icon change, but I dunno, "Help" not being the last thing looks > > strange...? Hi the help icon was changed yesterday in master (by me without reviewboard) so help use the right icon. - andreas -

Re: Review Request 125111: Change system settings toolbar

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125111/#review85030 --- +1 for the icon change, but I dunno, "Help" not being the last

Review Request 125111: Change system settings toolbar

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125111/ --- Review request for Plasma and andreas kainz. Repository: systemsettings

Review Request 125110: two small fixes for kwaylandScanner

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125110/ --- Review request for kwin, Plasma and Martin Gräßlin. Repository: kwayland

Re: Review Request 125107: Renamed functions and variables for better Qt compliance and better description

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125107/#review85028 --- Ship it! - Vishesh Handa On Sept. 8, 2015, 7:02 p.m., Ovidi

Re: Review Request 124472: WIP: Implement drag and drop support for icon widget

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124472/#review85021 --- applets/icon/plugin/icon_p.cpp (line 111)

Re: Review Request 124986: [System Tray] Bring back shortcuts configuration

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124986/ --- (Updated Sept. 8, 2015, 7:42 p.m.) Status -- This change has been ma

Re: Review Request 125060: Added .gitignore

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125060/ --- (Updated Sept. 8, 2015, 10:03 p.m.) Status -- This change has been d

Re: Review Request 125062: Renamed variable for better description

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125062/ --- (Updated Sept. 8, 2015, 10:03 p.m.) Status -- This change has been d

Re: Review Request 125058: Cleanup and Add directories to index list

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125058/ --- (Updated Sept. 8, 2015, 10:03 p.m.) Status -- This change has been d

Review Request 125107: Renamed functions and variables for better Qt compliance and better description

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125107/ --- Review request for Baloo, Plasma and Vishesh Handa. Repository: plasma-de

Re: Review Request 124472: WIP: Implement drag and drop support for icon widget

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124472/ --- (Updated Sept. 8, 2015, 6:37 p.m.) Status -- This change has been ma

Re: Review Request 124986: [System Tray] Bring back shortcuts configuration

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124986/ --- (Updated Sept. 8, 2015, 6:35 nachm.) Review request for Plasma and KDE Us

[Powerdevil] [Bug 352442] extremely slow response on brightness hotkeys

https://bugs.kde.org/show_bug.cgi?id=352442 --- Comment #4 from Igor Poboiko --- (In reply to Martin Klapetek from comment #3) > Can you check if there's any process running at 100% cpu right after you > press the brightness key? Or perhaps if plasma is frozen (try moving your > mouse over taskba

[Powerdevil] [Bug 352442] extremely slow response on brightness hotkeys

https://bugs.kde.org/show_bug.cgi?id=352442 Martin Klapetek changed: What|Removed |Added Ever confirmed|0 |1 Status|RESOLVED

Re: Review Request 125105: Simplify getting associated apps list in AssociatedApplicationManager

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125105/ --- (Updated Sept. 8, 2015, 4:30 p.m.) Status -- This change has been ma

Re: Review Request 125105: Simplify getting associated apps list in AssociatedApplicationManager

> On Sept. 8, 2015, 5:46 p.m., David Faure wrote: > > I would split it the mimetype-determination into a separate line of code > > for readability, but other than that, this looks good, thanks for having > > made and tested the change. Alright, I'll move it out. - Martin --

[Powerdevil] [Bug 352442] extremely slow response on brightness hotkeys

https://bugs.kde.org/show_bug.cgi?id=352442 --- Comment #2 from Igor Poboiko --- I don't agree it is duplicate of bug 350676. It works even after single keypress, but its response to second keypress is either slow or none. Also it is the same for both brightness increase and decrease. -- You

[Powerdevil] [Bug 352442] extremely slow response on brightness hotkeys

https://bugs.kde.org/show_bug.cgi?id=352442 Bhushan Shah changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED CC|

[Powerdevil] [Bug 350676] Need to press key twice to decrease brightness

https://bugs.kde.org/show_bug.cgi?id=350676 Bhushan Shah changed: What|Removed |Added CC||igor.pobo...@gmail.com --- Comment #3 from Bhush

[Powerdevil] [Bug 352442] New: extremely slow response on brightness hotkeys

https://bugs.kde.org/show_bug.cgi?id=352442 Bug ID: 352442 Summary: extremely slow response on brightness hotkeys Product: Powerdevil Version: 5.4.0 Platform: Gentoo Packages OS: Linux Status: UNCONFIRMED

Re: Review Request 125105: Simplify getting associated apps list in AssociatedApplicationManager

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125105/#review85017 --- Ship it! I would split it the mimetype-determination into a s

Re: Review Request 123779: Include the mimetype itself when querying for KFileItemActions::associatedApplications

> On Sept. 7, 2015, 9:25 a.m., David Faure wrote: > > There's no need to call aliases() at all, trader queries (and in fact > > ksycoca already) do resolve aliases. > > David Faure wrote: > And since you're calling this for one URL at a time, you don't need > KFileItemActions, just do >

Review Request 125105: Simplify getting associated apps list in AssociatedApplicationManager

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125105/ --- Review request for Plasma and David Faure. Repository: plasma-framework

Plasma 5.4.1

Plasma 5.4.1 is now released https://www.kde.org/announcements/plasma-5.4.1.php ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125102: share the wayland connection between the effects and windowmanagement

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125102/ --- (Updated Sept. 8, 2015, 12:30 p.m.) Status -- This change has been m

Re: Review Request 125102: share the wayland connection between the effects and windowmanagement

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125102/#review85009 --- Ship it! Ship It! - Martin Gräßlin On Sept. 8, 2015, 2:06

Re: Review Request 125018: Support for Dpms

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125018/ --- (Updated Sept. 8, 2015, 2:18 p.m.) Review request for Plasma, Kai Uwe Bro

Re: Review Request 125102: share the wayland connection between the effects and windowmanagement

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125102/ --- (Updated Sept. 8, 2015, 12:06 p.m.) Review request for kwin and Plasma.

Re: Review Request 125018: Support for Dpms

> On Sept. 7, 2015, 4:48 p.m., Sebastian Kügler wrote: > > src/client/dpms.h, line 234 > > > > > > Perhaps carry the new mode in this signal? No, I decided against that when implementing it (I thought about it).

Re: Review Request 125102: share the wayland connection between the effects and windowmanagement

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125102/#review85007 --- It looks like this patch is no longer complete and like you on

Re: Review Request 125102: share the wayland connection between the effects and windowmanagement

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125102/ --- (Updated Sept. 8, 2015, 11:01 a.m.) Review request for kwin and Plasma.

Re: Review Request 125100: Fix typos

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125100/ --- (Updated Sept. 8, 2015, 10:55 a.m.) Status -- This change has been m

Re: Review Request 125102: share the wayland connection between the effects and windowmanagement

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125102/#review85006 --- src/windowsystem/waylandintegration.cpp (line 153)

Re: Review Request 125102: share the wayland connection between the effects and windowmanagement

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125102/#review85005 --- src/windowsystem/waylandintegration.cpp (lines 86 - 87)

Review Request 125102: share the wayland connection between the effects and windowmanagement

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125102/ --- Review request for kwin and Plasma. Repository: kwayland-integration De

Re: Review Request 125100: Fix typos

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125100/#review85004 --- Ship it! Ship It! - Sebastian Kügler On Sept. 8, 2015, 8:1

Re: Review Request 124954: Add support for modifier only shortcuts on Wayland

> On Sept. 7, 2015, 4:59 nachm., Thomas Lübking wrote: > > Hold it. > > > > Implementationwise, this looks wonky - if it's possible to get unbalanced > > input events (ie. releases w/o ever a press or vv.) from the system since > > the counter will run out of sync. > > > > => Are such unbalan

Re: Review Request 124954: Add support for modifier only shortcuts on Wayland

> On Sept. 7, 2015, 2:59 nachm., Thomas Lübking wrote: > > Hold it. > > > > Implementationwise, this looks wonky - if it's possible to get unbalanced > > input events (ie. releases w/o ever a press or vv.) from the system since > > the counter will run out of sync. > > > > => Are such unbalan

Review Request 125100: Fix typos

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125100/ --- Review request for Plasma and Sebastian Kügler. Repository: kwayland De

Re: Review Request 125018: Support for Dpms

> On Sept. 7, 2015, 4:48 nachm., Sebastian Kügler wrote: > > src/client/protocols/dpms.xml, line 30 > > > > > > I know these values make sense on an X11 level, not sure if there's > > really a difference between

Re: Review Request 125018: Support for Dpms

> On Sept. 7, 2015, 4:48 nachm., Sebastian Kügler wrote: > > Only minor things. Looking good otherwise. thanks for all the typos! As most are copy and pasted I'm going to fix them everywhere. New review request incoming ;-) - Martin --

Re: Review Request 124472: WIP: Implement drag and drop support for icon widget

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124472/#review84994 --- Ship it! Ship It! - Bhushan Shah On Sept. 8, 2015, 12:25 a