> On Sept. 7, 2015, 9:25 a.m., David Faure wrote: > > There's no need to call aliases() at all, trader queries (and in fact > > ksycoca already) do resolve aliases. > > David Faure wrote: > And since you're calling this for one URL at a time, you don't need > KFileItemActions, just do > > const KService::List apps = > KMimeTypeTrader::self()->query(i.value().first());
New patch at https://git.reviewboard.kde.org/r/125105/ please have a look. - Martin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123779/#review84938 ----------------------------------------------------------- On May 13, 2015, 7:05 p.m., Martin Klapetek wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/123779/ > ----------------------------------------------------------- > > (Updated May 13, 2015, 7:05 p.m.) > > > Review request for Plasma. > > > Bugs: 340326 > http://bugs.kde.org/show_bug.cgi?id=340326 > > > Repository: plasma-framework > > > Description > ------- > > This gets the current mimetype _and_ a list of its aliases, because aliases() > do not return the current mimetype in it, so it needs to be prepended, > especially for the cases where there are no aliases to be returned, > this would then just return an empty list, returning the generic action even > when there is a valid mimetype and an associated app. > > This fixes bug 340326. > > > Diffs > ----- > > src/plasma/private/associatedapplicationmanager.cpp 01dd319 > > Diff: https://git.reviewboard.kde.org/r/123779/diff/ > > > Testing > ------- > > Folderview now has proper context menu action. > > > Thanks, > > Martin Klapetek > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
