----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124986/ -----------------------------------------------------------
(Updated Sept. 8, 2015, 6:35 nachm.) Review request for Plasma and KDE Usability. Changes ------- - Right align KeySequenceItem, as discussed with Thomas - Ensure the "Keyboard Shortcut" heading isn't cut-off (resizeToContents only looks after column contents) Repository: plasma-workspace Description ------- In Plasma 4.x you could configure applet shortcuts from System Tray settings rather fiddling around with each individual applet. This restores this. - It uses a TableView like the 4.x did (TableView is a good candidate for pushing ComboBox off its throne of horribleness), including the item's icon - Shortcuts in System Tray are now handled through QKeySequence rather than QString - When checking "Always show all entries" the comboboxes become disabled (not the entire Table so you could still change shortcuts) Diffs (updated) ----- applets/systemtray/package/contents/ui/ConfigEntries.qml e848ae3 applets/systemtray/plugin/protocols/dbussystemtray/dbussystemtraytask.h f499a57 applets/systemtray/plugin/protocols/dbussystemtray/dbussystemtraytask.cpp 6486f18 applets/systemtray/plugin/protocols/plasmoid/plasmoidtask.h 74d1e1f applets/systemtray/plugin/protocols/plasmoid/plasmoidtask.cpp c9d98d7 Diff: https://git.reviewboard.kde.org/r/124986/diff/ Testing ------- I can set and unset applet shortcuts (did we have that for DBus tasks? There were stubs for that but I can't remember), as well as hide/show/auto entries. File Attachments ---------------- UI in action https://git.reviewboard.kde.org/media/uploaded/files/2015/08/29/795452f7-f817-49d5-a2bb-ba43234f4f91__systemtrayshortcuts.png Thanks, Kai Uwe Broulik
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
