Re: Review Request 124633: Parse formfactor in KService and KPluginInfo

2015-08-05 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124633/ --- (Updated Aug. 5, 2015, 10:41 p.m.) Review request for KDE Frameworks, Pla

Re: Review Request 124634: Filter applets by formFactor

2015-08-05 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124634/ --- (Updated Aug. 5, 2015, 10:35 p.m.) Status -- This change has been ma

Re: Review Request 124634: Filter applets by formFactor

2015-08-05 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124634/#review83469 --- Ship it! Ship It! - Marco Martin On Aug. 5, 2015, 9:45 p.m

Review Request 124634: Filter applets by formFactor

2015-08-05 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124634/ --- Review request for Plasma and Marco Martin. Repository: plasma-workspace

Re: Review Request 124633: Parse formfactor in KService and KPluginInfo

2015-08-05 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124633/#review83468 --- Looks good to me, just two small things. autotests/kservicet

Re: Review Request 123877: [digital-clock] Bring back font family option

2015-08-05 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123877/ --- (Updated Aug. 5, 2015, 9:29 p.m.) Status -- This change has been mar

Re: Review Request 124625: Filter out non-desktop formfactors in Kickoff's application model

2015-08-05 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124625/ --- (Updated Aug. 5, 2015, 9 p.m.) Review request for Plasma. Changes -

Review Request 124633: Parse formfactor in KService and KPluginInfo

2015-08-05 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124633/ --- Review request for KDE Frameworks, Plasma, Alex Richardson, and David Faure

Re: kgamma rename

2015-08-05 Thread Marco Martin
On Wednesday 05 August 2015, Jonathan Riddell wrote: > kgamma has already been released as part of applications with a > version number of 14.12. It's due to be released with plasma with a > 5.3.95 version. So it needs a rename to stop us from releasing a tar with > a smaller version than the pre

kgamma rename

2015-08-05 Thread Jonathan Riddell
kgamma has already been released as part of applications with a version number of 14.12. It's due to be released with plasma with a 5.3.95 version. So it needs a rename to stop us from releasing a tar with a smaller version than the previous release. I'm thinking kgamma-kf5. Any other suggest

Re: Review Request 124628: Fix loop on ButtonStyle

2015-08-05 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124628/ --- (Updated Aug. 5, 2015, 4:33 p.m.) Status -- This change has been mar

Re: Review Request 124628: Fix loop on ButtonStyle

2015-08-05 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124628/#review83463 --- Ship it! Ship It! - Marco Martin On Aug. 5, 2015, 3:29 p.m

Review Request 124628: Fix loop on ButtonStyle

2015-08-05 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124628/ --- Review request for KDE Frameworks and Plasma. Repository: plasma-framewor

[Breeze] [Bug 350500] I can't read white text on white background.

2015-08-05 Thread Martin Klapetek
https://bugs.kde.org/show_bug.cgi?id=350500 --- Comment #11 from Martin Klapetek --- Ah ok. This looks like a problem of the Glassified theme. I would suggest contacting the author and asking him to update the theme for Plasma 5 (if he hasn't already). Can you confirm that if you select Breeze

Re: Splitting (Muon) Discover from muon repository

2015-08-05 Thread Aleix Pol
On Wed, Aug 5, 2015 at 1:26 PM, Jonathan Riddell wrote: > On Wed, Aug 05, 2015 at 01:05:54PM +0200, Aleix Pol wrote: >> If the branching is today, we're probably too late already. On the >> other hand waiting for the stable branches will mean that some >> projects will disappear at some point on t

Re: Review Request 123877: [digital-clock] Bring back font family option

2015-08-05 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123877/#review83457 --- Ship it! Ship It! - Martin Klapetek On Aug. 3, 2015, 8:12

Re: Review Request 124625: Filter out non-desktop formfactors in Kickoff's application model

2015-08-05 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124625/#review83456 --- applets/kickoff/core/applicationmodel.cpp (line 152)

Jenkins-kde-ci: kinfocenter master kf5-qt5 » Linux,gcc - Build # 10 - Failure!

2015-08-05 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/kinfocenter%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/10/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 05 Aug 2015 12:35:29 + Build duration: 1 min 4 sec CHANGE SET Revision 8bfa62a9474cd70d8526201ad5d62ef74b6c

Jenkins-kde-ci: kinfocenter master kf5-qt5 » Linux,gcc - Build # 10 - Failure!

2015-08-05 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/kinfocenter%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/10/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 05 Aug 2015 12:35:29 + Build duration: 1 min 4 sec CHANGE SET Revision 8bfa62a9474cd70d8526201ad5d62ef74b6c

Jenkins-kde-ci: kinfocenter Plasma-5.3 stable-kf5-qt5 » Linux,gcc - Build # 3 - Failure!

2015-08-05 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/kinfocenter%20Plasma-5.3%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/3/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 05 Aug 2015 12:35:29 + Build duration: 57 sec CHANGE SET Revision 2682048c9f5c38dab3c6a8cc47f7ae8

Jenkins-kde-ci: kinfocenter Plasma-5.3 stable-kf5-qt5 » Linux,gcc - Build # 3 - Failure!

2015-08-05 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/kinfocenter%20Plasma-5.3%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/3/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 05 Aug 2015 12:35:29 + Build duration: 57 sec CHANGE SET Revision 2682048c9f5c38dab3c6a8cc47f7ae8

Re: Review Request 124453: [digital-clock] Provide a simple option for 24h clock

2015-08-05 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124453/ --- (Updated Aug. 5, 2015, 12:25 p.m.) Status -- This change has been ma

Re: Splitting (Muon) Discover from muon repository

2015-08-05 Thread Harald Sitter
On Wed, Aug 5, 2015 at 1:26 PM, Jonathan Riddell wrote: > On Wed, Aug 05, 2015 at 01:05:54PM +0200, Aleix Pol wrote: >> If the branching is today, we're probably too late already. On the >> other hand waiting for the stable branches will mean that some >> projects will disappear at some point on t

Re: Plasma Mobile IRC meeting

2015-08-05 Thread Sebastian Kügler
On Tuesday, August 04, 2015 10:21:43 Sebastian Kügler wrote: > Hi, > > There's a lot of activity in design and code for Plasma Mobile. I think it > would be good to give it some more structure, so let's sit down for a bit > and talk about our general approach and how we handle different workflows.

Re: Splitting (Muon) Discover from muon repository

2015-08-05 Thread Jonathan Riddell
On Wed, Aug 05, 2015 at 01:05:54PM +0200, Aleix Pol wrote: > If the branching is today, we're probably too late already. On the > other hand waiting for the stable branches will mean that some > projects will disappear at some point on the stable releases (or we'll > have to wait until right before

Re: Splitting (Muon) Discover from muon repository

2015-08-05 Thread Aleix Pol
On Tue, Aug 4, 2015 at 9:29 PM, Jonathan Riddell wrote: > > As discussed at Akademy that seems fine with me and pretty sensible. > Muon package manager does have a use case and users, maybe this will > help it find a maintainer. > >> Anyway, I'd like to leave 2 repositories: >> - muon, that will h

Plasma Mobile IRC meeting: Thu, 12:00 CEST #plasma

2015-08-05 Thread Sebastian Kügler
Hi all, The datetime for the IRC has been agreed upon on Thursday, 12:00 CEST (so 10:00 UTC) in #plasma on Freenode. Preliminary agenda: - Structuring design work: How do we get from idea to shipped implementation, design driven? - Phabricator for code reviews - Forums and welcoming contribu

Re: Review Request 124625: Filter out non-desktop formfactors in Kickoff's application model

2015-08-05 Thread Sebastian Kügler
> On Aug. 5, 2015, 3:01 a.m., Aleix Pol Gonzalez wrote: > > Would it be possible to get a test? Possible yes, but not very practical. This model doesn't have any unit tests yet, and testing it well would be quite some work, which I currently don't have the time for. This patch has revealed so