> On Aug. 5, 2015, 3:01 a.m., Aleix Pol Gonzalez wrote: > > Would it be possible to get a test?
Possible yes, but not very practical. This model doesn't have any unit tests yet, and testing it well would be quite some work, which I currently don't have the time for. This patch has revealed some problems in KService though (and works around it), which I'm going to fix separately (and with unit tests). I already have a patch for that which needs polishing. - Sebastian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124625/#review83446 ----------------------------------------------------------- On Aug. 5, 2015, 12:14 a.m., Sebastian Kügler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124625/ > ----------------------------------------------------------- > > (Updated Aug. 5, 2015, 12:14 a.m.) > > > Review request for Plasma. > > > Repository: plasma-desktop > > > Description > ------- > > Filter out non-desktop formfactors in Kickoff's application model > > > Diffs > ----- > > applets/kickoff/core/applicationmodel.cpp > 95f57128e85d4067f9edb459416704415c0c2958 > > Diff: https://git.reviewboard.kde.org/r/124625/diff/ > > > Testing > ------- > > Made sure a an app with X-KDE-FormFactors=handset,tablet doesn't show up, > made sure others do show up > > > Thanks, > > Sebastian Kügler > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
