----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124633/ -----------------------------------------------------------
Review request for KDE Frameworks, Plasma, Alex Richardson, and David Faure. Repository: kservice Description ------- Parse formfactor in KService and KPluginInfo Add an accessor QStringList KPluginInfo::formFactors() This corresponds to the X-KDE-FormFactors value in the .desktop file, and to the "FormFactors" value in the "KPlugin" block of the json metadata. We already have this in KPluginMetaData, this patch brings KPluginInfo and KService in line with that. Previously, the keys would not be recognized, and thus be missing from the KPluginMetaData if created through a KPluginInfo or a KService. This patch fixes this inconsistent behaviour. Also bump the sycoca version. Diffs ----- autotests/fakeplugin.desktop 200f02346d99caa585c39fc47ddb1d91e10a2a9d autotests/fakeplugin.json de4aed91f7b81af49f60a5bb4fed4c9c88807022 autotests/kplugininfotest.cpp d99b92a9523b97ee4a65f0a40c737c46275caeb6 autotests/kservicetest.h 380cf7b2df7fda7e2df0f37bdc0ee8a16971fc03 autotests/kservicetest.cpp 2c71331903eab6de6b6dcd440439c697e87f2a4a src/services/kplugininfo.h 7b98576a17ba4bb3b8e283e56c6cb1b2ff7fec73 src/services/kplugininfo.cpp 56dc0b43036a2a49804ff799360c29c2121dda54 src/services/kservice.cpp 3639a2875e5dbaefc6511d36d7b7f0fb7697ea74 src/services/kservice_p.h bf59f3850d7ff2343526973794d5a4605a8f7934 src/sycoca/ksycoca.cpp 32d1689ad9cd01d3a8adb5123a1848278714ca95 Diff: https://git.reviewboard.kde.org/r/124633/diff/ Testing ------- Added new tests, no problems. ksycocathreadtest currently fails, but this is unrelated (also in master without this patch). Thanks, Sebastian Kügler
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
