Re: plasma-mobile repository cleaned up

2015-06-04 Thread Sebastian Kügler
On Friday, June 05, 2015 03:18:08 Sebastian Kügler wrote: > Things that have been split out: > > - the angelfish webbrowser, now in the plasma-angelfish repo > - the settings app, now found in plasma-settings > - the samegame demo, now in plasma-samegame > - the camera app, now in plasma-camera >

plasma-mobile repository cleaned up

2015-06-04 Thread Sebastian Kügler
Howdy, The plasma-mobile repository has over time accumulated lots of "stuff", apps, engines, plugins, and has been on the way of becoming one hairy tarball. Before it all gets too interconnected, Marco and I have sat down and went over what's in there, keeping in mind the general direction of

Re: Review Request 124004: Add week numbers to calendar - Part 1

2015-06-04 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124004/#review81218 --- src/declarativeimports/calendar/calendar.cpp (line 264)

Re: Review Request 123992: Use upcoming version of libdbusmenu-qt

2015-06-04 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123992/#review81216 --- Ship it! 5.4 or 5.3.2? I've noticed that a bunch of smaller

Re: Review Request 124005: Add week numbers to calendar - Part 2

2015-06-04 Thread Sebastian Kügler
> On June 4, 2015, 9:59 a.m., Kai Uwe Broulik wrote: > > applets/digital-clock/package/contents/config/main.xml, line 43 > > > > > > Why not make it default? > > > > Yours looks much more beautiful and ti

Re: Review Request 124004: Add week numbers to calendar - Part 1

2015-06-04 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124004/ --- (Updated June 4, 2015, 10:29 p.m.) Review request for Plasma. Changes -

Re: Review Request 124005: Add week numbers to calendar - Part 2

2015-06-04 Thread Martin Klapetek
> On June 4, 2015, 11:59 a.m., Kai Uwe Broulik wrote: > > applets/digital-clock/package/contents/config/main.xml, line 43 > > > > > > Why not make it default? > > > > Yours looks much more beautiful and t

Re: Review Request 124005: Add week numbers to calendar - Part 2

2015-06-04 Thread Martin Gräßlin
> On June 4, 2015, 11:59 a.m., Kai Uwe Broulik wrote: > > applets/digital-clock/package/contents/config/main.xml, line 43 > > > > > > Why not make it default? > > > > Yours looks much more beautiful and t

Re: Review Request 124005: Add week numbers to calendar - Part 2

2015-06-04 Thread Martin Klapetek
> On June 4, 2015, 11:59 a.m., Kai Uwe Broulik wrote: > > applets/digital-clock/package/contents/config/main.xml, line 43 > > > > > > Why not make it default? > > > > Yours looks much more beautiful and t

Re: Review Request 124004: Add week numbers to calendar - Part 1

2015-06-04 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124004/ --- (Updated June 4, 2015, 10:14 p.m.) Review request for Plasma. Changes -

Re: Review Request 124005: Add week numbers to calendar - Part 2

2015-06-04 Thread Martin Gräßlin
> On June 4, 2015, 11:59 a.m., Kai Uwe Broulik wrote: > > applets/digital-clock/package/contents/config/main.xml, line 43 > > > > > > Why not make it default? > > > > Yours looks much more beautiful and t

Re: Review Request 124005: Add week numbers to calendar - Part 2

2015-06-04 Thread Sebastian Kügler
> On June 4, 2015, 9:59 a.m., Kai Uwe Broulik wrote: > > applets/digital-clock/package/contents/config/main.xml, line 43 > > > > > > Why not make it default? > > > > Yours looks much more beautiful and ti

Re: Review Request 124005: Add week numbers to calendar - Part 2

2015-06-04 Thread Martin Klapetek
> On June 4, 2015, 11:59 a.m., Kai Uwe Broulik wrote: > > applets/digital-clock/package/contents/config/main.xml, line 43 > > > > > > Why not make it default? > > > > Yours looks much more beautiful and t

Re: Review Request 124005: Add week numbers to calendar - Part 2

2015-06-04 Thread Kai Uwe Broulik
> On Juni 4, 2015, 9:59 vorm., Kai Uwe Broulik wrote: > > applets/digital-clock/package/contents/config/main.xml, line 43 > > > > > > Why not make it default? > > > > Yours looks much more beautiful and t

Re: Review Request 124005: Add week numbers to calendar - Part 2

2015-06-04 Thread David Edmundson
> On June 4, 2015, 9:59 a.m., Kai Uwe Broulik wrote: > > applets/digital-clock/package/contents/config/main.xml, line 43 > > > > > > Why not make it default? > > > > Yours looks much more beautiful and ti

Re: Review Request 124005: Add week numbers to calendar - Part 2

2015-06-04 Thread Kai Uwe Broulik
> On Juni 4, 2015, 9:59 vorm., Kai Uwe Broulik wrote: > > applets/digital-clock/package/contents/config/main.xml, line 43 > > > > > > Why not make it default? > > > > Yours looks much more beautiful and t

Re: Review Request 124005: Add week numbers to calendar - Part 2

2015-06-04 Thread David Edmundson
> On June 4, 2015, 9:59 a.m., Kai Uwe Broulik wrote: > > applets/digital-clock/package/contents/config/main.xml, line 43 > > > > > > Why not make it default? > > > > Yours looks much more beautiful and ti

Re: Review Request 124005: Add week numbers to calendar - Part 2

2015-06-04 Thread Sebastian Kügler
> On June 4, 2015, 9:59 a.m., Kai Uwe Broulik wrote: > > applets/digital-clock/package/contents/config/main.xml, line 43 > > > > > > Why not make it default? > > > > Yours looks much more beautiful and ti

Re: Review Request 124004: Add week numbers to calendar - Part 1

2015-06-04 Thread Aleix Pol Gonzalez
> On June 4, 2015, 12:14 p.m., Aleix Pol Gonzalez wrote: > > You can use QJSArray. In fact it's quite faster as I think it's what V4 > > uses internally, so no casting happens. > > Martin Klapetek wrote: > There is no QJSArray; you mean QJSValue? Or QJsonArray? > > Aleix Pol Gonzalez wrote

Re: Review Request 124004: Add week numbers to calendar - Part 1

2015-06-04 Thread Martin Klapetek
> On June 4, 2015, 12:14 p.m., Aleix Pol Gonzalez wrote: > > You can use QJSArray. In fact it's quite faster as I think it's what V4 > > uses internally, so no casting happens. > > Martin Klapetek wrote: > There is no QJSArray; you mean QJSValue? Or QJsonArray? > > Aleix Pol Gonzalez wrote

Re: Review Request 124004: Add week numbers to calendar - Part 1

2015-06-04 Thread Kai Uwe Broulik
> On Juni 4, 2015, 10:14 vorm., Aleix Pol Gonzalez wrote: > > You can use QJSArray. In fact it's quite faster as I think it's what V4 > > uses internally, so no casting happens. > > Martin Klapetek wrote: > There is no QJSArray; you mean QJSValue? Or QJsonArray? > > Aleix Pol Gonzalez wrot

Re: Review Request 124004: Add week numbers to calendar - Part 1

2015-06-04 Thread Aleix Pol Gonzalez
> On June 4, 2015, 12:14 p.m., Aleix Pol Gonzalez wrote: > > You can use QJSArray. In fact it's quite faster as I think it's what V4 > > uses internally, so no casting happens. > > Martin Klapetek wrote: > There is no QJSArray; you mean QJSValue? Or QJsonArray? QJsonArray I meant. We alrea

Re: Review Request 124004: Add week numbers to calendar - Part 1

2015-06-04 Thread Martin Klapetek
> On June 4, 2015, 11:57 a.m., Kai Uwe Broulik wrote: > > > Somehow the Repeater { model: } does not like QList > > > > I think that's a limitation of the JavaScript engine and/or type conversion > > thing. QVariantList and QStringList are converted to JS Arrays but I don't > > think it does t

Re: Review Request 124004: Add week numbers to calendar - Part 1

2015-06-04 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124004/ --- (Updated June 4, 2015, 7:48 p.m.) Review request for Plasma. Changes --

Re: bluez qt bic & sic - soversion regression

2015-06-04 Thread Harald Sitter
thanks, confirmed fixed :) On Thu, Jun 4, 2015 at 9:41 AM, David Rosca wrote: > Fixed now, sorry about that. > > David > > On Thu, Jun 4, 2015 at 6:24 PM, Harald Sitter wrote: >> alohas >> >> this commit >> http://quickgit.kde.org/?p=bluez-qt.git&a=commit&h=7e05a4a4fae19550b1dcc11e5a363a0884b5f8

Re: Review Request 124004: Add week numbers to calendar - Part 1

2015-06-04 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124004/#review81194 --- +1 looks good to me src/declarativeimports/calendar/qml/Days

Re: Review Request 124004: Add week numbers to calendar - Part 1

2015-06-04 Thread Martin Klapetek
> On June 4, 2015, 12:14 p.m., Aleix Pol Gonzalez wrote: > > You can use QJSArray. In fact it's quite faster as I think it's what V4 > > uses internally, so no casting happens. There is no QJSArray; you mean QJSValue? Or QJsonArray? - Martin -

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 31 - Fixed!

2015-06-04 Thread no-reply
We thank you for fixing your build!___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 124004: Add week numbers to calendar - Part 1

2015-06-04 Thread Kai Uwe Broulik
> On Juni 4, 2015, 9:57 vorm., Kai Uwe Broulik wrote: > > > Somehow the Repeater { model: } does not like QList > > > > I think that's a limitation of the JavaScript engine and/or type conversion > > thing. QVariantList and QStringList are converted to JS Arrays but I don't > > think it does t

Re: Review Request 124004: Add week numbers to calendar - Part 1

2015-06-04 Thread Martin Klapetek
> On June 4, 2015, 12:07 p.m., Kai Uwe Broulik wrote: > > src/declarativeimports/calendar/calendar.h, line 56 > > > > > > Oh, and I'd say you should use QVariantList so you can still store > > numbers and not bre

Re: Review Request 124004: Add week numbers to calendar - Part 1

2015-06-04 Thread Martin Klapetek
> On June 4, 2015, 11:57 a.m., Kai Uwe Broulik wrote: > > > Somehow the Repeater { model: } does not like QList > > > > I think that's a limitation of the JavaScript engine and/or type conversion > > thing. QVariantList and QStringList are converted to JS Arrays but I don't > > think it does t

Re: Review Request 124005: Add week numbers to calendar - Part 2

2015-06-04 Thread Martin Klapetek
> On June 4, 2015, 11:59 a.m., Kai Uwe Broulik wrote: > > applets/digital-clock/package/contents/config/main.xml, line 43 > > > > > > Why not make it default? > > > > Yours looks much more beautiful and t

Re: bluez qt bic & sic - soversion regression

2015-06-04 Thread David Rosca
Fixed now, sorry about that. David On Thu, Jun 4, 2015 at 6:24 PM, Harald Sitter wrote: > alohas > > this commit > http://quickgit.kde.org/?p=bluez-qt.git&a=commit&h=7e05a4a4fae19550b1dcc11e5a363a0884b5f8d8 > > removed the soversion6 which is needed as the present API is > incompatible with the

bluez qt bic & sic - soversion regression

2015-06-04 Thread Harald Sitter
alohas this commit http://quickgit.kde.org/?p=bluez-qt.git&a=commit&h=7e05a4a4fae19550b1dcc11e5a363a0884b5f8d8 removed the soversion6 which is needed as the present API is incompatible with the one released as 5.3.x needs to be brought back. kthxbai _

Re: Review Request 123991: Select lockscreenpassword not until user can type

2015-06-04 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123991/#review81188 --- Ship it! Ah yes, that makes perfect sense. Thanks! - Martin

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 30 - Failure!

2015-06-04 Thread no-reply
Check console output at https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/30/ to view the results. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 123999: Don't crash in XRandrBrightness if not on xcb

2015-06-04 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123999/ --- (Updated June 4, 2015, 2:09 p.m.) Status -- This change has been mar

Re: Review Request 123991: Select lockscreenpassword not until user can type

2015-06-04 Thread David Kahles
> On June 3, 2015, 5:58 p.m., Martin Klapetek wrote: > > Can you please explain once again what the problem is and why this solves > > it? > > David Kahles wrote: > I forgot to mention that this refers to the lockscreen, sorry. > > If the user types in the wrong password, a timer r

Re: Review Request 124004: Add week numbers to calendar - Part 1

2015-06-04 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124004/#review81169 --- You can use QJSArray. In fact it's quite faster as I think it'

Re: Review Request 124004: Add week numbers to calendar - Part 1

2015-06-04 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124004/#review81167 --- src/declarativeimports/calendar/calendar.h (line 56)

[plasmashell] [Bug 348693] "Logout dialog" triggers undesired system shutdowns.

2015-06-04 Thread Kai Uwe Broulik
https://bugs.kde.org/show_bug.cgi?id=348693 Kai Uwe Broulik changed: What|Removed |Added CC||k...@privat.broulik.de, |

Re: Review Request 123999: Don't crash in XRandrBrightness if not on xcb

2015-06-04 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123999/#review81165 --- Ship it! Ship It! - Kai Uwe Broulik On Juni 3, 2015, 11:08

[Powerdevil] [Bug 348693] New: "Logout dialog" triggers undesired system shutdowns.

2015-06-04 Thread aldo-public
https://bugs.kde.org/show_bug.cgi?id=348693 Bug ID: 348693 Summary: "Logout dialog" triggers undesired system shutdowns. Product: Powerdevil Version: 5.3.1 Platform: Kubuntu Packages OS: Linux Status: UNCONFIRMED

Re: Review Request 124004: Add week numbers to calendar - Part 1

2015-06-04 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124004/#review81164 --- src/declarativeimports/calendar/qml/DaysCalendar.qml (lines 1

Re: Review Request 124005: Add week numbers to calendar - Part 2

2015-06-04 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124005/#review81163 --- applets/digital-clock/package/contents/config/main.xml (line

Re: Review Request 124004: Add week numbers to calendar - Part 1

2015-06-04 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124004/#review81162 --- > Somehow the Repeater { model: } does not like QList I think

Review Request 124005: Add week numbers to calendar - Part 2

2015-06-04 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124005/ --- Review request for Plasma. Repository: plasma-workspace Description ---

Review Request 124004: Add week numbers to calendar - Part 1

2015-06-04 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124004/ --- Review request for Plasma. Repository: plasma-framework Description ---

Re: Review Request 123999: Don't crash in XRandrBrightness if not on xcb

2015-06-04 Thread Lukáš Tinkl
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123999/#review81161 --- Ship it! Ship It! - Lukáš Tinkl On Čer. 4, 2015, 1:08 dop.