----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124004/#review81218 -----------------------------------------------------------
src/declarativeimports/calendar/calendar.cpp (line 264) <https://git.reviewboard.kde.org/r/124004/#comment55616> QJsonArray +1 LGTM - Aleix Pol Gonzalez On June 4, 2015, 10:29 p.m., Martin Klapetek wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124004/ > ----------------------------------------------------------- > > (Updated June 4, 2015, 10:29 p.m.) > > > Review request for Plasma. > > > Repository: plasma-framework > > > Description > ------- > > One of the most requested features for Plasma5. The backend is all there*, it > just needs the frontend part. Optional, defaults to off. > > *Somehow the Repeater { model: } does not like QList<int>, it just doesn't > show anything while QStringList works just fine. Any ideas on that? > > > Diffs > ----- > > src/declarativeimports/calendar/calendar.h ea20bf5 > src/declarativeimports/calendar/calendar.cpp a766acb > src/declarativeimports/calendar/qml/DaysCalendar.qml 67b3a2e > src/declarativeimports/calendar/qml/MonthView.qml 6eaa8db > > Diff: https://git.reviewboard.kde.org/r/124004/diff/ > > > Testing > ------- > > > File Attachments > ---------------- > > Screenshot > > https://git.reviewboard.kde.org/media/uploaded/files/2015/06/04/2283789a-91e1-4a99-b341-bcaddaaeac85__calendar-weeks6.png > > > Thanks, > > Martin Klapetek > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
