Re: Review Request 123621: Fix reverse scroll setting in Mouse KCM

> On May 4, 2015, 6:40 p.m., Rajeesh K Nambiar wrote: > > Reverse scrolling works in KF5 based apps (tested with dolphin, konsole > > etc) and gtk+ apps like firefox here - using synaptics driver. Also see the > > discussion in bug report https://bugs.kde.org/show_bug.cgi?id=342929 where > > o

Re: Review Request 123626: port libplasma away from sycoca as much as possible

> On May 6, 2015, 10:54 p.m., Sebastian Kügler wrote: > > I've read and tested it, everything still works nicely. Good job! > > > > I like how the patch moves much of the query language into simple C++, > > avoids a lot of query parsing and moves some of the error paths to compile > > time. h

Reverting review 123473

We had an agreement that there would be no regressions when porting any KCMs to QML. The following regressions remain in the newly ported KCM: - combo boxes load in wrong places https://codereview.qt-project.org/#/c/111326/ isn't merged, and Qt 5.5 isn't a requirement for the Plasma 5.4 release.

Re: Review Request 123626: port libplasma away from sycoca as much as possible

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123626/#review7 --- Ship it! I've read and tested it, everything still works nice

Re: Review Request 123626: port libplasma away from sycoca as much as possible

> On May 6, 2015, 5:38 p.m., Hrvoje Senjan wrote: > > >I would keep this for safety until Plasma 5.4 is released, then try to > > >remove it again > > > > First, sorry for being the bad cop, i'd just like to avoid any future > > (irreversible) problems, and that distros delivering monthly KF5

Re: Review Request 123473: Port mouse theme kcm to QML

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123473/#review79996 --- Wait, what happened to no regressions? Your combo box patch is

Re: Review Request 123664: Find DBusAddons component explicitly

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123664/ --- (Updated May 6, 2015, 9:47 p.m.) Status -- This change has been mark

Re: Review Request 123664: Find DBusAddons component explicitly

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123664/#review79995 --- Ship it! Ship It! - Aleix Pol Gonzalez On May 6, 2015, 8:5

Review Request 123664: Find DBusAddons component explicitly

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123664/ --- Review request for Plasma. Repository: plasma-workspace Description ---

Re: Review Request 123626: port libplasma away from sycoca as much as possible

> On May 6, 2015, 5:38 p.m., Hrvoje Senjan wrote: > > >I would keep this for safety until Plasma 5.4 is released, then try to > > >remove it again > > > > First, sorry for being the bad cop, i'd just like to avoid any future > > (irreversible) problems, and that distros delivering monthly KF5

Re: Review Request 123626: port libplasma away from sycoca as much as possible

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123626/#review79977 --- >I would keep this for safety until Plasma 5.4 is released, th

Re: Review Request 123626: port libplasma away from sycoca as much as possible

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123626/ --- (Updated May 6, 2015, 5:21 p.m.) Review request for KDE Frameworks and Pl

Re: Review Request 123626: port libplasma away from sycoca as much as possible

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123626/ --- (Updated May 6, 2015, 5:20 p.m.) Review request for KDE Frameworks and Pl

Re: Review Request 123473: Port mouse theme kcm to QML

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123473/ --- (Updated May 6, 2015, 4:57 p.m.) Status -- This change has been mark

Re: Review Request 123626: port libplasma away from sycoca as much as possible

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123626/ --- (Updated May 6, 2015, 2:35 p.m.) Review request for KDE Frameworks and Pl

Re: Review Request 123653: New Minimize Windows Plasmoid

> On May 6, 2015, 1:55 p.m., Martin Gräßlin wrote: > > applets/minimizeall/plugin/minimizeall.cpp, line 57 > > > > > > suggestion: instead of reconnecting all the time: a QElapsedTimer to > > measure whether it's

Re: Review Request 123653: New Minimize Windows Plasmoid

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123653/#review79970 --- applets/minimizeall/plugin/minimizeall.cpp (line 57)

Re: Review Request 123653: New Minimize Windows Plasmoid

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123653/ --- (Updated May 6, 2015, 1:20 p.m.) Review request for Plasma. Changes ---

Re: Review Request 123653: New Minimize Windows Plasmoid

> On May 6, 2015, 6 a.m., Martin Gräßlin wrote: > > From experience with the show desktop feature and the problems when > > minimizing all windows I highly suggest to only minimize all windows. Don't > > even try to restore the minimized state when clicked again. > > Sebastian Kügler wrote: >

Re: Review Request 123653: New Minimize Windows Plasmoid

> On May 6, 2015, 6 a.m., Martin Gräßlin wrote: > > From experience with the show desktop feature and the problems when > > minimizing all windows I highly suggest to only minimize all windows. Don't > > even try to restore the minimized state when clicked again. > > Sebastian Kügler wrote: >

Re: Review Request 123653: New Minimize Windows Plasmoid

> On May 6, 2015, 6 a.m., Martin Gräßlin wrote: > > From experience with the show desktop feature and the problems when > > minimizing all windows I highly suggest to only minimize all windows. Don't > > even try to restore the minimized state when clicked again. > > Sebastian Kügler wrote: >

Re: Review Request 123653: New Minimize Windows Plasmoid

> On Mai 6, 2015, 6 vorm., Martin Gräßlin wrote: > > From experience with the show desktop feature and the problems when > > minimizing all windows I highly suggest to only minimize all windows. Don't > > even try to restore the minimized state when clicked again. > > Sebastian Kügler wrote: >

Re: Review Request 123653: New Minimize Windows Plasmoid

> On May 6, 2015, 6 a.m., Martin Gräßlin wrote: > > From experience with the show desktop feature and the problems when > > minimizing all windows I highly suggest to only minimize all windows. Don't > > even try to restore the minimized state when clicked again. > > Sebastian Kügler wrote: >

Re: Review Request 123653: New Minimize Windows Plasmoid

> On May 6, 2015, 8 a.m., Martin Gräßlin wrote: > > From experience with the show desktop feature and the problems when > > minimizing all windows I highly suggest to only minimize all windows. Don't > > even try to restore the minimized state when clicked again. > > Sebastian Kügler wrote: >

Re: Review Request 123653: New Minimize Windows Plasmoid

> On Mai 6, 2015, 6 vorm., Martin Gräßlin wrote: > > From experience with the show desktop feature and the problems when > > minimizing all windows I highly suggest to only minimize all windows. Don't > > even try to restore the minimized state when clicked again. > > Sebastian Kügler wrote: >

Re: Review Request 123653: New Minimize Windows Plasmoid

> On May 6, 2015, 6 a.m., Martin Gräßlin wrote: > > From experience with the show desktop feature and the problems when > > minimizing all windows I highly suggest to only minimize all windows. Don't > > even try to restore the minimized state when clicked again. That is kind of the point of t