> On May 6, 2015, 1:55 p.m., Martin Gräßlin wrote: > > applets/minimizeall/plugin/minimizeall.cpp, line 57 > > <https://git.reviewboard.kde.org/r/123653/diff/2/?file=366858#file366858line57> > > > > suggestion: instead of reconnecting all the time: a QElapsedTimer to > > measure whether it's in the "blocked" interval. > > > > I would also consider to add more conditions to break out. E.g. > > activities, window added/window removed
Rationale being here that we save a function call in most cases (namely when !m_active, performance win is probably negligible, but feels nicer. (I'm open to change it, just think that disconnecting and reconnecting is the cleaner thing to do here.) I'll add more reset conditions. - Sebastian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123653/#review79970 ----------------------------------------------------------- On May 6, 2015, 1:20 p.m., Sebastian Kügler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/123653/ > ----------------------------------------------------------- > > (Updated May 6, 2015, 1:20 p.m.) > > > Review request for Plasma. > > > Bugs: 346837 > http://bugs.kde.org/show_bug.cgi?id=346837 > > > Repository: kdeplasma-addons > > > Description > ------- > > New Minimize Windows Plasmoid > > This plasmoid allows to minimize windows on the current desktop. It does > not mess with the KWindowSystem::showingDesktop flag, just allows to hide > and show windows. > > > Diffs > ----- > > applets/CMakeLists.txt 7ada7ac > applets/minimizeall/CMakeLists.txt PRE-CREATION > applets/minimizeall/Messages.sh PRE-CREATION > applets/minimizeall/package/contents/config/main.xml PRE-CREATION > applets/minimizeall/package/contents/ui/main.qml PRE-CREATION > applets/minimizeall/package/metadata.desktop PRE-CREATION > applets/minimizeall/plugin/minimizeall.h PRE-CREATION > applets/minimizeall/plugin/minimizeall.cpp PRE-CREATION > applets/minimizeall/plugin/minimizeallplugin.h PRE-CREATION > applets/minimizeall/plugin/minimizeallplugin.cpp PRE-CREATION > applets/minimizeall/plugin/qmldir PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/123653/diff/ > > > Testing > ------- > > Used it for a while. > > > Thanks, > > Sebastian Kügler > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
