Re: Systemd kcm module - inclusion in Plasma?

2015-04-29 Thread Ragnar Thomsen
On Wed, Apr 29, 2015 at 6:43 PM, Matthias Klumpp wrote: > FYI, we patch this out of systemd-kcm in Debian at time, since > coredumps aren't (yet?) handled by our systemd. > So maybe instead of displaying an error, just hide the page for coredumpctl? > (Making a check for Debian is also not a good

Re: Review Request 123547: Task manager : New instances can now be opened by mid click.

2015-04-29 Thread Eike Hein
> On April 28, 2015, 11:48 p.m., Eike Hein wrote: > > People frequently request either "new instance" or "close window" for > > middle-click, so unfortunately I think this will have to be a config option > > and I won't accept a patch that only implements the one behavior. > > Martin Gräßlin

Re: Review Request 123544: kioclient ls: properly construct QUrl.

2015-04-29 Thread Aleix Pol Gonzalez
> On April 30, 2015, 1:02 a.m., Mark Gaiser wrote: > > Pushed. But slightly different then was reviewed here. > > I added the define which subsequently gave me two more issues of the same > > nature in kioclient (cat and openProperties). > > I've fixed those as well and changed the commit messag

Re: Review Request 123544: kioclient ls: properly construct QUrl.

2015-04-29 Thread Mark Gaiser
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123544/#review79701 --- Pushed. But slightly different then was reviewed here. I added

Re: Review Request 123544: kioclient ls: properly construct QUrl.

2015-04-29 Thread Mark Gaiser
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123544/ --- (Updated April 29, 2015, 10:56 p.m.) Status -- This change has been

Re: Review Request 123556: KPackage::findPackages with a filter callback

2015-04-29 Thread Alex Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123556/#review79698 --- src/kpackage/packageloader.cpp (line 273)

Re: Review Request 123544: kioclient ls: properly construct QUrl.

2015-04-29 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123544/#review79694 --- Ship it! Ship It! - David Faure On April 28, 2015, 6:18 p.

Re: Systemd kcm module - inclusion in Plasma?

2015-04-29 Thread Matthias Klumpp
2015-04-29 18:21 GMT+02:00 Ragnar Thomsen : > On Wed, Apr 29, 2015 at 4:10 PM, Martin Gräßlin wrote: >> Just run kdesrc-build and gave it a try and was greeted with an error >> message: >> http://paste.opensuse.org/54725251 >> >> That's on a Debian stable/testing system and the file does not exis

Re: Review Request 123547: Task manager : New instances can now be opened by mid click.

2015-04-29 Thread Yoann Laissus
> On avr. 28, 2015, 11:48 après-midi, Eike Hein wrote: > > People frequently request either "new instance" or "close window" for > > middle-click, so unfortunately I think this will have to be a config option > > and I won't accept a patch that only implements the one behavior. > > Martin Grä

Re: Systemd kcm module - inclusion in Plasma?

2015-04-29 Thread Ragnar Thomsen
On Wed, Apr 29, 2015 at 4:10 PM, Martin Gräßlin wrote: > Just run kdesrc-build and gave it a try and was greeted with an error message: > http://paste.opensuse.org/54725251 > > That's on a Debian stable/testing system and the file does not exist. As that > file is missing on that distribution an e

Re: Systemd kcm module - inclusion in Plasma?

2015-04-29 Thread Martin Gräßlin
On Wednesday 29 April 2015 15:22:56 Ragnar Thomsen wrote: > Hey all, > > The systemd kcm module is now setup at: > http://quickgit.kde.org/?p=systemd-kcm.git > > I hope some of you have found time to try it out and would like to > hear your opinions on whether this is suitable for inclusion in Pl

Re: Systemd kcm module - inclusion in Plasma?

2015-04-29 Thread Ragnar Thomsen
On Wed, Apr 29, 2015 at 3:45 PM, Aleix Pol wrote: > Some people mentioned that you might want to look into integrating it > in the current solutions, on the last thread. Did you have the > opportunity? Hey Aleix, I think you are confusing the systemd kcm module (systemd-kcm) with the systemd jou

Re: Systemd kcm module - inclusion in Plasma?

2015-04-29 Thread Aleix Pol
On Wed, Apr 29, 2015 at 3:22 PM, Ragnar Thomsen wrote: > Hey all, > > The systemd kcm module is now setup at: > http://quickgit.kde.org/?p=systemd-kcm.git > > I hope some of you have found time to try it out and would like to > hear your opinions on whether this is suitable for inclusion in Plasma

Re: Review Request 123555: Fix a crash in PowermanagementEngine::populateApplicationData when the given name is empty

2015-04-29 Thread Emmanuel Pescosta
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123555/ --- (Updated April 29, 2015, 1:24 p.m.) Status -- This change has been m

Systemd kcm module - inclusion in Plasma?

2015-04-29 Thread Ragnar Thomsen
Hey all, The systemd kcm module is now setup at: http://quickgit.kde.org/?p=systemd-kcm.git I hope some of you have found time to try it out and would like to hear your opinions on whether this is suitable for inclusion in Plasma (maybe in time for 5.4). If yes, can it be included in its current

Re: Review Request 123555: Fix a crash in PowermanagementEngine::populateApplicationData when the given name is empty

2015-04-29 Thread Lukáš Tinkl
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123555/#review79675 --- Ship it! Ship It! - Lukáš Tinkl On Dub. 29, 2015, 12:40 od

Re: Re: 5.4 kickoff meeting

2015-04-29 Thread Martin Gräßlin
On Wednesday 29 April 2015 13:22:47 David Edmundson wrote: > I have some things I want to add to the agenda > > > - dividing up the most major bugs in 5.3.0 between us for priority fixing > I can create that list. > > - we have one recurring piece of feedback about different wallpaperes on > d

Re: 5.4 kickoff meeting

2015-04-29 Thread Jonathan Riddell
I started an agenda doc, edits welcome https://notes.kde.org/p/plasma-5.4 Jonthan On Wed, Apr 29, 2015 at 01:22:47PM +0200, David Edmundson wrote: >I have some things I want to add to the agenda >A - dividing up the most major bugs in 5.3.0 between us for priority >fixing >I ca

Re: Review Request 123547: Task manager : New instances can now be opened by mid click.

2015-04-29 Thread Eike Hein
> On April 28, 2015, 11:48 p.m., Eike Hein wrote: > > People frequently request either "new instance" or "close window" for > > middle-click, so unfortunately I think this will have to be a config option > > and I won't accept a patch that only implements the one behavior. > > Martin Gräßlin

Re: Review Request 123556: KPackage::findPackages with a filter callback

2015-04-29 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123556/ --- (Updated April 29, 2015, 12:12 p.m.) Status -- This change has been

Review Request 123557: FindQalculate: Use FindPkgConfig instead of UsePkgConfig

2015-04-29 Thread Heiko Becker
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123557/ --- Review request for Plasma. Repository: plasma-workspace Description ---

Re: Review Request 123547: Task manager : New instances can now be opened by mid click.

2015-04-29 Thread Sebastian Kügler
> On April 28, 2015, 11:48 p.m., Eike Hein wrote: > > People frequently request either "new instance" or "close window" for > > middle-click, so unfortunately I think this will have to be a config option > > and I won't accept a patch that only implements the one behavior. > > Martin Gräßlin

Re: Review Request 123556: KPackage::findPackages with a filter callback

2015-04-29 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123556/#review79667 --- Ship it! Ship It! src/kpackage/packageloader.h (line 59)

Re: Review Request 123555: Fix a crash in PowermanagementEngine::populateApplicationData when the given name is empty

2015-04-29 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123555/#review79666 --- Ship it! Nice one! Please commit to Plasma/5.3 and then merg

Re: 5.4 kickoff meeting

2015-04-29 Thread David Edmundson
I have some things I want to add to the agenda - dividing up the most major bugs in 5.3.0 between us for priority fixing I can create that list. - we have one recurring piece of feedback about different wallpaperes on different virtual desktops. We should discuss it a bit.

Re: Review Request 123556: KPackage::findPackages with a filter callback

2015-04-29 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123556/ --- (Updated April 29, 2015, 10:51 a.m.) Review request for KDE Frameworks an

Review Request 123556: KPackage::findPackages with a filter callback

2015-04-29 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123556/ --- Review request for KDE Frameworks and Plasma. Repository: kpackage Desc

Review Request 123555: Fix a crash in PowermanagementEngine::populateApplicationData when the given name is empty

2015-04-29 Thread Emmanuel Pescosta
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123555/ --- Review request for Plasma and Kai Uwe Broulik. Repository: plasma-workspa

Re: Review Request 123547: Task manager : New instances can now be opened by mid click.

2015-04-29 Thread Martin Gräßlin
> On April 29, 2015, 1:48 a.m., Eike Hein wrote: > > People frequently request either "new instance" or "close window" for > > middle-click, so unfortunately I think this will have to be a config option > > and I won't accept a patch that only implements the one behavior. > > Martin Gräßlin w

Re: Review Request 123547: Task manager : New instances can now be opened by mid click.

2015-04-29 Thread Yoann Laissus
> On avr. 28, 2015, 11:48 après-midi, Eike Hein wrote: > > People frequently request either "new instance" or "close window" for > > middle-click, so unfortunately I think this will have to be a config option > > and I won't accept a patch that only implements the one behavior. > > Martin Grä

Re: Review Request 123547: Task manager : New instances can now be opened by mid click.

2015-04-29 Thread Yoann Laissus
> On avr. 28, 2015, 9:47 après-midi, David Edmundson wrote: > > applets/taskmanager/package/contents/ui/Task.qml, line 108 > > > > > > now shift + right click will also start a new instance, that's probably > >