----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123544/#review79701 -----------------------------------------------------------
Pushed. But slightly different then was reviewed here. I added the define which subsequently gave me two more issues of the same nature in kioclient (cat and openProperties). I've fixed those as well and changed the commit message accordingly. Yes, i did test them before pushing and they seem to work just fine now. http://quickgit.kde.org/?p=kde-cli-tools.git&a=commit&h=787bdf628fdf9f74c978363e07ddad0ae306d8bf - Mark Gaiser On apr 29, 2015, 10:56 p.m., Mark Gaiser wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/123544/ > ----------------------------------------------------------- > > (Updated apr 29, 2015, 10:56 p.m.) > > > Review request for Plasma and David Faure. > > > Repository: kde-cli-tools > > > Description > ------- > > The ls command was using direct user input as QUrl. That in turn caused the > QUrl to be constructed without a scheme. Constructing it via makeURL(...) > (like all the others do) makes it a valid QUrl with scheme. This allows for > example a command like "kioclient ls ~" to work again. Again because it > worked in the kdelibs version thus this was a regression. > > > Diffs > ----- > > kioclient/kioclient.cpp 74c9985 > > Diff: https://git.reviewboard.kde.org/r/123544/diff/ > > > Testing > ------- > > kioclient ls <path> works. No need to prefix the path with "file://" anymore. > > > Thanks, > > Mark Gaiser > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
