> On avr. 28, 2015, 9:47 après-midi, David Edmundson wrote: > > applets/taskmanager/package/contents/ui/Task.qml, line 108 > > <https://git.reviewboard.kde.org/r/123547/diff/1/?file=364298#file364298line108> > > > > now shift + right click will also start a new instance, that's probably > > unintended?
The right click was inhibitted in the press event (pressed != true) as it doesn't need a release event to be triggered. But I could add a check in release just to be safe. - Yoann ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123547/#review79647 ----------------------------------------------------------- On avr. 28, 2015, 8:45 après-midi, Yoann Laissus wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/123547/ > ----------------------------------------------------------- > > (Updated avr. 28, 2015, 8:45 après-midi) > > > Review request for Plasma. > > > Repository: plasma-desktop > > > Description > ------- > > Currently, only the shortcut Shift + Left click is available. > In KDE4, we had both. > > > Diffs > ----- > > applets/taskmanager/package/contents/ui/Task.qml f5fc723 > > Diff: https://git.reviewboard.kde.org/r/123547/diff/ > > > Testing > ------- > > Tested with classic task manager and the icon only one. > Tested with all mouse button combinaisons and keyboard modifiers. > > > Thanks, > > Yoann Laissus > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
