Re: Re: Papercuts from review at sprint

2015-02-25 Thread Martin Gräßlin
On Wednesday 25 February 2015 18:45:27 Sebastian Kügler wrote: > On Monday, February 23, 2015 08:00:40 Martin Gräßlin wrote: > > On Saturday 21 February 2015 17:56:38 Sebastian Kügler wrote: > > > * Whatsthis (?) button in the window decoration is almost never used > > > (can > > > this button be e

Review Request 122726: Make touchpad KCM optional depending on whether we find synaptics

2015-02-25 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122726/ --- Review request for Plasma. Repository: plasma-desktop Description -

Build failed in Jenkins: plasma-desktop_master_qt5 #1032

2015-02-25 Thread KDE CI System
See Changes: [kde] Build touchpad KCM as part of plasma-desktop -- [...truncated 251 lines...] PROJECT_VERSION_MAJOR This warning is for project developers. Use -Wno-dev to suppress it.

Re: Review Request 122717: Improve tooltip layouting

2015-02-25 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122717/#review76636 --- Ship it! Ship It! - David Edmundson On Feb. 25, 2015, 8:31

Re: Review Request 122717: Improve tooltip layouting

2015-02-25 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122717/#review76637 --- src/declarativeimports/core/private/DefaultToolTip.qml

Re: Review Request 122717: Improve tooltip layouting

2015-02-25 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122717/ --- (Updated Feb. 25, 2015, 8:31 p.m.) Review request for Plasma. Changes -

Re: Qt version dependency in workspace/

2015-02-25 Thread David Edmundson
On Wed, Feb 25, 2015 at 6:34 PM, Eike Hein wrote: > > Hi, > > after discussion in #plasma today and in light of kwin moving to > a Qt 5.4.0 dependency, we've decided to bump workspace to 5.4.0 > as a whole to reduce the support surface and avoid problems > creeping in in the wild. > > I've bumped

Re: Qt version dependency in workspace/

2015-02-25 Thread Jan Grulich
Hi, regarding libmm-qt, I still hope I'll make it as a framework before Plasma 5.3 gets released. I'm already working on missing unit-tests and after I'm done I'll submit it for review. Regards, Jan -- Jan Grulich Red Hat Czech, s.r.o jgrul...@redhat.com On Wednesday 25 of February 2015 18:3

Re: Review Request 122717: Improve tooltip layouting

2015-02-25 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122717/#review76633 --- src/declarativeimports/core/private/DefaultToolTip.qml

Re: Review Request 122667: Some tools for easily do qml based apps using KPackage

2015-02-25 Thread Marco Martin
On Feb. 23, 2015, 11:08 a.m., Marco Martin wrote: > > I like where this is going! :) > > Marco Martin wrote: > One thing i'm still not sure is what to export to it. it now sets the > application commandline arguments, that's not really possible to obtain > otherwise. > Another thing wo

Re: Papercuts from review at sprint

2015-02-25 Thread Eike Hein
On 02/21/2015 05:56 PM, Sebastian Kügler wrote: * Is the joystick KCM really useful, can it be killed? (If anybody can be found who is actually using a joystick, let's just kill it) I got a joystick as an xmas present, but haven't tested it with the KCM yet. Might take a look. Cheers, Eike

Qt version dependency in workspace/

2015-02-25 Thread Eike Hein
Hi, after discussion in #plasma today and in light of kwin moving to a Qt 5.4.0 dependency, we've decided to bump workspace to 5.4.0 as a whole to reduce the support surface and avoid problems creeping in in the wild. I've bumped the following repositories today: bluedevil kde-cli-tools kdecor

Re: Papercuts from review at sprint

2015-02-25 Thread Sebastian Kügler
On Monday, February 23, 2015 08:00:40 Martin Gräßlin wrote: > On Saturday 21 February 2015 17:56:38 Sebastian Kügler wrote: > > * Whatsthis (?) button in the window decoration is almost never used (can > > this button be either hidden, or shown conditionally) > > The button is only shown if the wi

Re: Papercuts from review at sprint

2015-02-25 Thread Sebastian Kügler
On Monday, February 23, 2015 00:12:08 Lukáš Tinkl wrote: > Dne 21.2.2015 v 17:56 Sebastian Kügler napsal(a): > > * "Application Color Scheme" KCM has "[ ] Apply colors to non-KDE4 > > applications" > > This is what krdb obeys and it basically applies color schemes and/or > themes to gtk apps. Or

Jenkins build is back to normal : plasma-desktop_master_qt5 #1028

2015-02-25 Thread KDE CI System
See ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122715: tooltip: Fix left margin in text-only tooltips

2015-02-25 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122715/ --- (Updated Feb. 25, 2015, 5:26 p.m.) Review request for Plasma. Changes -

Re: Review Request 122715: tooltip: Fix left margin in text-only tooltips

2015-02-25 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122715/ --- (Updated Feb. 25, 2015, 5:26 p.m.) Status -- This change has been di

Re: Review Request 122717: Improve tooltip layouting

2015-02-25 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122717/ --- (Updated Feb. 25, 2015, 5:27 p.m.) Review request for Plasma. Changes -

Re: Review Request 122717: Improve tooltip layouting

2015-02-25 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122717/ --- (Updated Feb. 25, 2015, 5:16 p.m.) Review request for Plasma. Changes -

Review Request 122668: port of comic applet to plasma5

2015-02-25 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122668/ --- Review request for Plasma. Repository: kdeplasma-addons Description ---

Re: Review Request 122717: Improve tooltip layouting

2015-02-25 Thread Marco Martin
> On Feb. 25, 2015, 10:23 a.m., David Edmundson wrote: > > src/declarativeimports/core/private/DefaultToolTip.qml, line 96 > > > > > > just set the Layout.preferredWidth instead of min and max. > > (and on the

Re: Review Request 122679: Show Desktop feature: refurbished

2015-02-25 Thread Kai Uwe Broulik
> On Feb. 25, 2015, 1:37 nachm., Marco Martin wrote: > > I like the idea, it would at least make the show desktop function actually > > usable. > > this would/could replace the dashboard as well? > > Martin Gräßlin wrote: > > this would/could replace the dashboard as well? > > Yes

Re: Review Request 122595: Make it possible to let plasmoids to load scripts outside the plasma package

2015-02-25 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122595/ --- (Updated Feb. 25, 2015, 3:28 p.m.) Status -- This change has been ma

Re: Review Request 122679: Show Desktop feature: refurbished

2015-02-25 Thread Thomas Lübking
> On Feb. 23, 2015, 8:25 vorm., Martin Gräßlin wrote: > > effects/presentwindows/presentwindows.cpp, line 1418 > > > > > > Maybe: whenever a fullscreen effect is used disable showingDesktoP? > > Thomas Lübking

Re: Review Request 122679: Show Desktop feature: refurbished

2015-02-25 Thread Thomas Lübking
> On Feb. 25, 2015, 1:37 nachm., Marco Martin wrote: > > I like the idea, it would at least make the show desktop function actually > > usable. > > this would/could replace the dashboard as well? > > Martin Gräßlin wrote: > > this would/could replace the dashboard as well? > > Yes

Re: Review Request 122717: Improve tooltip layouting

2015-02-25 Thread Sebastian Kügler
> On Feb. 25, 2015, 10:23 a.m., David Edmundson wrote: > > src/declarativeimports/core/private/DefaultToolTip.qml, line 96 > > > > > > just set the Layout.preferredWidth instead of min and max. > > (and on the

Re: Review Request 122679: Show Desktop feature: refurbished

2015-02-25 Thread Martin Gräßlin
> On Feb. 25, 2015, 2:37 p.m., Marco Martin wrote: > > I like the idea, it would at least make the show desktop function actually > > usable. > > this would/could replace the dashboard as well? > this would/could replace the dashboard as well? Yes this "should" replace dashboard. It is kind of

Re: Review Request 122679: Show Desktop feature: refurbished

2015-02-25 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122679/#review76600 --- I like the idea, it would at least make the show desktop funct

Re: Review Request 122679: Show Desktop feature: refurbished

2015-02-25 Thread Martin Gräßlin
> On Feb. 23, 2015, 9:25 a.m., Martin Gräßlin wrote: > > effects/presentwindows/presentwindows.cpp, line 1418 > > > > > > Maybe: whenever a fullscreen effect is used disable showingDesktoP? > > Thomas Lübking w

Re: Review Request 122667: Some tools for easily do qml based apps using KPackage

2015-02-25 Thread Aleix Pol Gonzalez
On Feb. 23, 2015, 12:08 p.m., Marco Martin wrote: > > I like where this is going! :) > > Marco Martin wrote: > One thing i'm still not sure is what to export to it. it now sets the > application commandline arguments, that's not really possible to obtain > otherwise. > Another thing wo

Re: Review Request 122717: Improve tooltip layouting

2015-02-25 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122717/#review76596 --- +1 I like how it makes use of layouts with this approach. - A

Build failed in Jenkins: plasma-desktop_master_qt5 #1027

2015-02-25 Thread KDE CI System
See Changes: [scripty] SVN_SILENT made messages (.desktop file) -- Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit Building remotely on LinuxSlave - 3 (PACKAGER LI

Jenkins build is still unstable: kde-gtk-config_stable_qt5 #6

2015-02-25 Thread KDE CI System
See ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Jenkins build is still unstable: kde-gtk-config_master_qt5 #6

2015-02-25 Thread KDE CI System
See ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122717: Improve tooltip layouting

2015-02-25 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122717/#review76591 --- +1 to the approach. It's a lot neater, and I love layouts

Re: Review Request 122667: Some tools for easily do qml based apps using KPackage

2015-02-25 Thread Marco Martin
> On Feb. 23, 2015, 11:08 a.m., Aleix Pol Gonzalez wrote: > > src/qmlpackagelauncher/CMakeLists.txt, line 8 > > > > > > Maybe it would make sense to call it "kpackagelauncher-qml"? renamed, but without the dash th

Re: Review Request 122667: Some tools for easily do qml based apps using KPackage

2015-02-25 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122667/ --- (Updated Feb. 25, 2015, 9:29 a.m.) Review request for KDE Frameworks and

Re: 5.2.1 tars for packagers

2015-02-25 Thread Martin Klapetek
On Tue, Feb 24, 2015 at 11:17 PM, Eric Hameleers wrote: > On Tue, 24 Feb 2015, Albert Astals Cid wrote: > > El Dimarts, 24 de febrer de 2015, a les 14:48:38, Harald Sitter va >> escriure: >> >>> On Tue, Feb 24, 2015 at 2:46 PM, Anke Boersma wrote: >>> FWIW, no such regressions here with Pl

Re: 5.2.1 tars for packagers

2015-02-25 Thread Eric Hameleers
On Tue, 24 Feb 2015, Albert Astals Cid wrote: El Dimarts, 24 de febrer de 2015, a les 14:48:38, Harald Sitter va escriure: On Tue, Feb 24, 2015 at 2:46 PM, Anke Boersma wrote: FWIW, no such regressions here with Plasma 5.2.1 Krunner/Alt-F2 works as should, focus of opened apps with krunner is