> On Feb. 23, 2015, 8:25 vorm., Martin Gräßlin wrote: > > effects/presentwindows/presentwindows.cpp, line 1418 > > <https://git.reviewboard.kde.org/r/122679/diff/1/?file=350838#file350838line1418> > > > > Maybe: whenever a fullscreen effect is used disable showingDesktoP? > > Thomas Lübking wrote: > That would eg. also affect invoking the cube to alter the VD, would it > not? > (I do not mean the cubeslide effect) > > Martin Gräßlin wrote: > yes, would also affect cube. That was actually my thought for it. I would > expect it to restore windows, otherwise the effect might be a little bit > pointless IMHO.
You still get the desktop name. While I'm willing to grant you the reason to exit SD w/ entering the cube, I'm really not sure whether setActiveFullscreenEffect (technical detail) should exit SD as unconditional side effect. Eg. one could have a FS effect to paint onto the desktop or whatnot. Also a cube effect to change activities or similar could be added and then there's no real implication to lower *this* desktop again. Assuming EffectsHandler::setActiveFullscreenEffect(Effect *e, quitShowingDesktop = true); one had an apparently pretty unrelated random parameter? - Thomas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122679/#review76450 ----------------------------------------------------------- On Feb. 22, 2015, 3:51 nachm., Thomas Lübking wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/122679/ > ----------------------------------------------------------- > > (Updated Feb. 22, 2015, 3:51 nachm.) > > > Review request for kwin, Plasma, Martin Gräßlin, and Marco Martin. > > > Bugs: 344083 > https://bugs.kde.org/show_bug.cgi?id=344083 > > > Repository: kwin > > > Description > ------- > > commit a1b80b4e310b2c75b4d9811af1d23f699bc658b5 > Author: Thomas Lübking > Date: Sun Feb 22 16:41:45 2015 +0100 > > add "MinimizeAll" script > > to compensate withdrawn core feature (which > though has been hidden so far) > > commit 983efb916e282d2263b4abcc92f714c06b3bfcc1 > Author: Thomas Lübking > Date: Wed Feb 18 02:09:00 2015 +0100 > > break showingDesktop w/ tabbox/PW/DG > > This is now crucial, because while before (the minimized) windows were > conditionally shown, but are now always behind the desktop. > Also, it makes the tabbox more consistent. > > commit ff531c8e2adc407da00bef88f18d03e3829b25fa > Author: Thomas Lübking > Date: Wed Feb 18 01:37:45 2015 +0100 > > implement showingDesktop by raising the desktop window > > commit 190a0cc022d9935d658a6218d0b3caa79b038563 > Author: Thomas Lübking > Date: Wed Feb 18 00:09:46 2015 +0100 > > remove secret showDesktopIsMinimizeAll feature > > > Diffs > ----- > > client.h f064041 > client.cpp 3e834f2 > effects/desktopgrid/desktopgrid.cpp 97cb2a3 > effects/presentwindows/presentwindows.cpp 07660c2 > kwin.kcfg 80ca365 > tabbox/tabbox.cpp f81a407 > scripts/minimizeall/metadata.desktop PRE-CREATION > scripts/minimizeall/contents/code/main.js PRE-CREATION > scripts/CMakeLists.txt 34dedb7 > options.cpp cdaa851 > options.h 67e5868 > layers.cpp 91edc04 > manage.cpp f302892 > workspace.h 4ecac3d > workspace.cpp 7cbe81e > > Diff: https://git.reviewboard.kde.org/r/122679/diff/ > > > Testing > ------- > > * The script (though mostly in KWin4, trouble w/ ksycoca5...) > * Obviously the supersecret key is now dead ;-) > * Been playing around with alternate desktop showing. > > > Thanks, > > Thomas Lübking > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
