> On Feb. 23, 2015, 11:08 a.m., Aleix Pol Gonzalez wrote: > > src/qmlpackagelauncher/CMakeLists.txt, line 8 > > <https://git.reviewboard.kde.org/r/122667/diff/1/?file=350611#file350611line8> > > > > Maybe it would make sense to call it "kpackagelauncher-qml"?
renamed, but without the dash that i don't like too much On Feb. 23, 2015, 11:08 a.m., Marco Martin wrote: > > I like where this is going! :) One thing i'm still not sure is what to export to it. it now sets the application commandline arguments, that's not really possible to obtain otherwise. Another thing would probably be the kaboutdata, which now is constructing one but not really doing anything with it. I would like to have an easy way to automatically have the various about application/about kde dialogs there too, even tough not depending from kxmlgui, but don't really know a clean way to do it atm - Marco ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122667/#review76459 ----------------------------------------------------------- On Feb. 25, 2015, 9:29 a.m., Marco Martin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/122667/ > ----------------------------------------------------------- > > (Updated Feb. 25, 2015, 9:29 a.m.) > > > Review request for KDE Frameworks and Plasma. > > > Repository: kdeclarative > > > Description > ------- > > This is still a bit rough but adding it there for early feedback. comes from > the fact that I would like a standard-ish way for KDE apps to do QML based > apps > > It adds 3 things: > * KPackage support to QmlObject: the class is done to easily load QML without > using qquickview, since I want to push loading qml from KPackages, adding > kpackage support to this class seems to make sense > * qmlpackagelauncher: tiny tool to launch qml apps from qml packages: > supports both the case the root object is a qquickitem or an > ApplicationWindow qtquickcomponent(that is a window in itself) puts proper > window title and icon, sets the kaboutdata from the metadata file, binds > commandline arguments in the context (kinda feel some other bindings/API > could be needed) > * KPackageView: is a qquickview that loads kpackages... seeing that the > direction from Qt of using ApplicationWindow as root item makes me a bit > unsure wether to add this tough > > > Diffs > ----- > > CMakeLists.txt 52a698a > src/CMakeLists.txt 32da8a5 > src/kdeclarative/CMakeLists.txt 052b9e2 > src/kdeclarative/qmlobject.h a0a74d3 > src/kdeclarative/qmlobject.cpp 00478b4 > src/kpackagelauncherqml/CMakeLists.txt PRE-CREATION > src/kpackagelauncherqml/main.cpp PRE-CREATION > src/quickaddons/CMakeLists.txt 8272f1f > tests/CMakeLists.txt a8abfaf > tests/helloworld/contents/ui/main.qml PRE-CREATION > tests/helloworld/metadata.desktop PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/122667/diff/ > > > Testing > ------- > > > Thanks, > > Marco Martin > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
