Re: Review Request 122382: [klipper] Sync history to disk after each change

> On Feb. 3, 2015, 8:36 a.m., Martin Gräßlin wrote: > > David E. just pointed out that this could become quite heavy for the system > > as the history size can be large (up to 2048 items). Unfortunately I couldn't find out why we support up to 2048 items. Commit message is just: commit da8394

Re: Review Request 122382: [klipper] Sync history to disk after each change

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122382/#review75264 --- David E. just pointed out that this could become quite heavy f

Re: Review Request 122392: Fix Klipper Performance issues

> On Feb. 3, 2015, 8:23 a.m., Martin Gräßlin wrote: > > could you please split the review in a per-commit review? I find it hard to > > review as there are so many changes to different areas. Especially I think > > there are a few no-brainer which could go in quickly, while the threaded > > fi

Re: Review Request 122392: Fix Klipper Performance issues

> On Feb. 3, 2015, 7:23 a.m., Martin Gräßlin wrote: > > could you please split the review in a per-commit review? I find it hard to > > review as there are so many changes to different areas. Especially I think > > there are a few no-brainer which could go in quickly, while the threaded > > fi

Re: Review Request 122392: Fix Klipper Performance issues

> On Feb. 3, 2015, 6:57 a.m., Martin Gräßlin wrote: > > As I worked on that just yesterday: you cannot filter in a different thread > > as Klipper is not thread save. Please see > > https://git.reviewboard.kde.org/r/122382/ for how I solved the problem. I > > suggest to rebase the patch on top

Re: Review Request 122392: Fix Klipper Performance issues

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122392/#review75260 --- could you please split the review in a per-commit review? I fi

Re: Review Request 122392: Fix Klipper Performance issues

> On Feb. 3, 2015, 7:57 a.m., Martin Gräßlin wrote: > > As I worked on that just yesterday: you cannot filter in a different thread > > as Klipper is not thread save. Please see > > https://git.reviewboard.kde.org/r/122382/ for how I solved the problem. I > > suggest to rebase the patch on top

Re: Review Request 122392: Fix Klipper Performance issues

> On Feb. 3, 2015, 6:57 a.m., Martin Gräßlin wrote: > > As I worked on that just yesterday: you cannot filter in a different thread > > as Klipper is not thread save. Please see > > https://git.reviewboard.kde.org/r/122382/ for how I solved the problem. I > > suggest to rebase the patch on top

Re: Review Request 122392: Fix Klipper Performance issues

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122392/#review75255 --- As I worked on that just yesterday: you cannot filter in a dif

Re: Review Request 122383: Remove internal copy of KXmlRpcClient

> On Feb. 2, 2015, 7:21 p.m., David Edmundson wrote: > > +1 as soon as it's a framework +1 to what David said - Martin --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122383/#review75229

Re: Review Request 122392: Fix Klipper Performance issues

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122392/ --- (Updated Feb. 3, 2015, 6:27 a.m.) Review request for Plasma. Repository

[Breeze] [Bug 343555] Breeze support for gtk2 and gtk3

https://bugs.kde.org/show_bug.cgi?id=343555 Weng Xuetian changed: What|Removed |Added CC||wen...@gmail.com --- Comment #7 from Weng Xuetia

Re: Review Request 122314: Sanitize whitespace in notification popups

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122314/#review75248 --- bump - Martin Klapetek On Jan. 30, 2015, 12:37 p.m., Martin

[Breeze] [Bug 343555] Breeze support for gtk2 and gtk3

https://bugs.kde.org/show_bug.cgi?id=343555 Hugo Pereira Da Costa changed: What|Removed |Added CC||hugo.pere...@free.fr --- Comment #6 fro

[Breeze] [Bug 343428] Checkbox on hover highlights are potentially confusing

https://bugs.kde.org/show_bug.cgi?id=343428 Hugo Pereira Da Costa changed: What|Removed |Added CC||hugo.pere...@free.fr Assignee

Review Request 122392: Fix the infinite event recursion in the klipper popup. See Bug 342947

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122392/ --- Review request for Plasma. Repository: plasma-workspace Description ---

Re: Review Request 122392: Fix Klipper Performance issues

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122392/ --- (Updated Feb. 2, 2015, 6:44 p.m.) Review request for Plasma. Summary (u

Re: Review Request 122342: Don't let notification popup accept focus

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122342/ --- (Updated Feb. 2, 2015, 6:31 p.m.) Status -- This change has been mar

Re: Review Request 122370: Prevent icon transition in tooltip

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122370/#review75230 --- So you're basically wiping the source whenever we set it to in

Re: Review Request 122383: Remove internal copy of KXmlRpcClient

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122383/#review75229 --- +1 as soon as it's a framework - David Edmundson On Feb. 2,

Re: Review Request 122384: Simplify and fix use of IconThemePath in StatusNotifierItems

> On Feb. 2, 2015, 3:43 p.m., Aleix Pol Gonzalez wrote: > > dataengines/statusnotifieritem/statusnotifieritemsource.cpp, line 221 > > > > > > Braces not needed. > > Marco Martin wrote: > I prefer doing like

Re: Review Request 122384: Simplify and fix use of IconThemePath in StatusNotifierItems

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122384/#review75226 --- This patch breaks other icons like Clementine and possibly oth

Re: Review Request 122387: Fix hardware shutdown button doing nothing on desktops

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122387/ --- (Updated Feb. 2, 2015, 4:39 p.m.) Status -- This change has been mar

Re: Review Request 122387: Fix hardware shutdown button doing nothing on desktops

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122387/#review75224 --- Ship it! Ship It! - Lukáš Tinkl On Úno. 2, 2015, 5:33 odp.

Review Request 122387: Fix hardware shutdown button doing nothing on desktops

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122387/ --- Review request for Plasma and Solid. Repository: powerdevil Description

Review Request 122386: [klipper] Adjust to new Prison API

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122386/ --- Review request for Plasma and Sune Vuorela. Repository: plasma-workspace

Re: Review Request 122384: Simplify and fix use of IconThemePath in StatusNotifierItems

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122384/ --- (Updated Feb. 2, 2015, 3:48 p.m.) Status -- This change has been mar

Re: Review Request 122384: Simplify and fix use of IconThemePath in StatusNotifierItems

> On Feb. 2, 2015, 3:43 p.m., Aleix Pol Gonzalez wrote: > > dataengines/statusnotifieritem/statusnotifieritemsource.cpp, line 221 > > > > > > Braces not needed. I prefer doing like kdelibs everywhere requiring b

Review Request 122383: Remove internal copy of KXmlRpcClient

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122383/ --- Review request for KDE Frameworks, Plasma and Rohan Garg. Repository: pla

Re: Review Request 122384: Simplify and fix use of IconThemePath in StatusNotifierItems

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122384/#review75221 --- dataengines/statusnotifieritem/statusnotifieritemsource.cpp <

Re: Review Request 122384: Simplify and fix use of IconThemePath in StatusNotifierItems

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122384/#review75220 --- Ship it! Ship It! - Marco Martin On Feb. 2, 2015, 3:38 p.m

Review Request 122384: Simplify and fix use of IconThemePath in StatusNotifierItems

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122384/ --- Review request for Plasma. Repository: plasma-workspace Description ---

Review Request 122382: [klipper] Sync history to disk after each change

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122382/ --- Review request for Plasma and Eike Hein. Bugs: 34 https://bugs.kd

Re: Minutes Monday Plasma Hangout

ivan: finishing main parts of libKActivitiesStats ResultSet testing suite. Working on the ResultWatcher. On 2 February 2015 at 13:23, Martin Klapetek wrote: > On Mon, Feb 2, 2015 at 1:02 PM, Marco Martin wrote: >> >> >> Martin G was at FOSDEM: cross-desktop Wayland meeting: >> - systray, notific

Re: Minutes Monday Plasma Hangout

On Mon, Feb 2, 2015 at 1:02 PM, Marco Martin wrote: > > Martin G was at FOSDEM: cross-desktop Wayland meeting: > - systray, notifications, no xembed for wayland enlightenment-> > statusnotificer > - gnome->persistent notifications extension, they don't want user > interacting > with systray > Ca

Minutes Monday Plasma Hangout

2th february 2015: David: - bugfixes for 5.2 - investigated a crash in kwin settings that triggers a weird qt bug - fixed mouse kcm Kai Uwe: - powerdevil fixes - fixed kded5 cpu eating bug - fixed some suspension issues (don't suspend when closong lid, shutting down) - icon chooser component in re

Re: Review Request 122370: Prevent icon transition in tooltip

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122370/#review75201 --- +1 - Martin Klapetek On Feb. 1, 2015, 8:36 p.m., Kai Uwe Br

Re: Review Request 122342: Don't let notification popup accept focus

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122342/#review75200 --- Ship it! Thanks!! Also I think there's a bug opened for this

Re: Review Request 122331: Add libinput support to kcm-touchpad

> On Feb. 2, 2015, 7:56 a.m., Martin Gräßlin wrote: > > src/backends/x11/libinputproperties.c, line 34 > > > > > > C++11 nitpick: nullptr instead of NULL It's a C file, declared as extern array in cpp files. Also

Re: Review Request 122332: KQuickControls IconDialog

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122332/#review75197 --- to do modality you have to use exec i guess - Marco Martin