> On Feb. 2, 2015, 7:56 a.m., Martin Gräßlin wrote: > > src/backends/x11/libinputproperties.c, line 34 > > <https://git.reviewboard.kde.org/r/122331/diff/1/?file=345765#file345765line34> > > > > C++11 nitpick: nullptr instead of NULL
It's a C file, declared as extern array in cpp files. Also see src/backends/x11/synclientproperties.c Tried changing to nullptr, but fails to compile. > On Feb. 2, 2015, 7:56 a.m., Martin Gräßlin wrote: > > src/backends/x11/xlibbackend.h, line 86 > > <https://git.reviewboard.kde.org/r/122331/diff/1/?file=345767#file345767line86> > > > > const-ref? using identifier.atom() in that function. Changing XcbAtom::atom() to return const is not quite possible as it modifies private attributes et al... - Rajeesh ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122331/#review75195 ----------------------------------------------------------- On Jan. 30, 2015, 7:41 p.m., Rajeesh K Nambiar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/122331/ > ----------------------------------------------------------- > > (Updated Jan. 30, 2015, 7:41 p.m.) > > > Review request for Plasma, Alexander Mezin and Martin Gräßlin. > > > Repository: kcm-touchpad > > > Description > ------- > > ibinput is a library to handle input devices in Wayland compositors and to > provide a generic X.Org input driver. Add libinput support to kcm-touchpad. > Patch authored by Peter Hutterer. > > > Diffs > ----- > > src/kcm/touchpad.kcfg 2afe642 > src/kcm/ui/tap.ui 8e081ad > src/touchpadbackend.cpp 93e3dc2 > src/backends/x11.cmake f208281 > src/backends/x11/libinputproperties.c PRE-CREATION > src/backends/x11/synclientproperties.h 5b32b9f > src/backends/x11/xlibbackend.h 3692a60 > src/backends/x11/xlibbackend.cpp 3b5e5be > src/kcm/customconfigdialogmanager.cpp 75b03ab > > Diff: https://git.reviewboard.kde.org/r/122331/diff/ > > > Testing > ------- > > Fedora 21 RPM built and tested with Plasma 5.2. > RPMs available here for testing: > https://copr-be.cloud.fedoraproject.org/results/rajeeshknambiar/kf5-kde-apps/fedora-21-x86_64/kf5-kcm_touchpad-5.1.96-1.fc21/ > > > Thanks, > > Rajeesh K Nambiar > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
