> On Feb. 2, 2015, 3:43 p.m., Aleix Pol Gonzalez wrote:
> > dataengines/statusnotifieritem/statusnotifieritemsource.cpp, line 221
> > <https://git.reviewboard.kde.org/r/122384/diff/1/?file=346430#file346430line221>
> >
> > Braces not needed.
>
> Marco Martin wrote:
> I prefer doing like kdelibs everywhere requiring braces even for one
> liners
he was referring to
QStringList( {} )
where the braces weren't needed for the intializer list.
- David
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122384/#review75221
-----------------------------------------------------------
On Feb. 2, 2015, 3:48 p.m., David Edmundson wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122384/
> -----------------------------------------------------------
>
> (Updated Feb. 2, 2015, 3:48 p.m.)
>
>
> Review request for Plasma.
>
>
> Repository: plasma-workspace
>
>
> Description
> -------
>
> Simplify and fix IconThemePath in StatusNotifierItems
>
> KIconLoader gained a second argument in KF5 that allows one to pass an
> absolute path to a icons to search.
>
> This saves trying to guess the app name, and adding that. This fixes
> certain application icons not loading (for example radiotray)
>
>
> Diffs
> -----
>
> dataengines/statusnotifieritem/statusnotifieritemsource.cpp 04cbc1a
>
> Diff: https://git.reviewboard.kde.org/r/122384/diff/
>
>
> Testing
> -------
>
> Ran radiotray on a system with libappindicator.
> Confirmed I got icons correctly
>
>
> Thanks,
>
> David Edmundson
>
>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
