Re: Review Request 121058: Don't put scripts from ~/.config/autostart in autostart kcm list.

2014-11-07 Thread Jeremy Whiting
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121058/ --- (Updated Nov. 7, 2014, 8:09 p.m.) Review request for Plasma and Luca Belt

Re: Review Request 121058: Don't put scripts from ~/.config/autostart in autostart kcm list.

2014-11-07 Thread Jeremy Whiting
> On Nov. 7, 2014, 3:34 p.m., Thomas Lübking wrote: > > kcms/autostart/autostart.cpp, line 174 > > > > > > I don't want to be annoyin, but "isAutostart" in "Autostart::load()" > > and below "autostartdir" is pro

Re: Review Request 121058: Don't put scripts from ~/.config/autostart in autostart kcm list.

2014-11-07 Thread Thomas Lübking
> On Nov. 7, 2014, 10:34 nachm., Thomas Lübking wrote: > > kcms/autostart/autostart.cpp, line 174 > > > > > > I don't want to be annoyin, but "isAutostart" in "Autostart::load()" > > and below "autostartdir" is

Re: Review Request 121058: Don't put scripts from ~/.config/autostart in autostart kcm list.

2014-11-07 Thread Thomas Lübking
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121058/#review70020 --- kcms/autostart/autostart.cpp

Re: Review Request 121058: Don't put scripts from ~/.config/autostart in autostart kcm list.

2014-11-07 Thread Jeremy Whiting
> On Nov. 7, 2014, 3:26 p.m., Thomas Lübking wrote: > > kcms/autostart/autostart.cpp, line 214 > > > > > > maybe cache that in a bool in the outer loop Good idea. - Jeremy ---

Re: Review Request 121058: Don't put scripts from ~/.config/autostart in autostart kcm list.

2014-11-07 Thread Jeremy Whiting
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121058/ --- (Updated Nov. 7, 2014, 3:31 p.m.) Review request for Plasma and Luca Belt

Re: Review Request 121058: Don't put scripts from ~/.config/autostart in autostart kcm list.

2014-11-07 Thread Thomas Lübking
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121058/#review70018 --- kcms/autostart/autostart.cpp

Review Request 121058: Don't put scripts from ~/.config/autostart in autostart kcm list.

2014-11-07 Thread Jeremy Whiting
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121058/ --- Review request for kdelibs, Plasma and Luca Beltrame. Repository: plasma-

Re: Autostart scripts (ksmserver problem)

2014-11-07 Thread Jeremy Whiting
Martin, After further testing yesterday evening it seems placing scripts (executable files) in ~/.config/plasma-workspace/env/ works fine. These also correctly appear in the autostart kcm. The only confusion left that I see is that scripts placed into ~/.config/autostart appear in the kcm, but we

Review Request 121057: Refactor JobDelegate

2014-11-07 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121057/ --- Review request for Plasma and Martin Klapetek. Repository: plasma-workspa

Re: Review Request 121033: Mark LibKWorkspace and ScreenSaverDBusInterface as REQUIRED

2014-11-07 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121033/ --- (Updated Nov. 7, 2014, 4:28 p.m.) Status -- This change has been mar

Re: Review Request 121033: Mark LibKWorkspace and ScreenSaverDBusInterface as REQUIRED

2014-11-07 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121033/#review70008 --- Ship it! Ship It! - Aleix Pol Gonzalez On Nov. 7, 2014, 2:

Re: Review Request 121033: Mark LibKWorkspace and ScreenSaverDBusInterface as REQUIRED

2014-11-07 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121033/ --- (Updated Nov. 7, 2014, 2:49 p.m.) Review request for Plasma, Àlex Fiestas

Re: Review Request 121016: [RFC] Make it possible to make plasmawindow live in a status notifier

2014-11-07 Thread Sebastian Kügler
> On Nov. 7, 2014, 11:20 a.m., Sebastian Kügler wrote: > > plasma-windowed/plasmawindowedview.cpp, line 44 > > > > > > I wonder if the background here should be transparant? > > Aleix Pol Gonzalez wrote: > We

Review Request 121033: Mark LibKWorkspace and ScreenSaverDBusInterface as REQUIRED

2014-11-07 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121033/ --- Review request for Plasma, Àlex Fiestas and Aleix Pol Gonzalez. Repositor

Re: Review Request 121016: [RFC] Make it possible to make plasmawindow live in a status notifier

2014-11-07 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121016/ --- (Updated Nov. 7, 2014, 2:08 p.m.) Status -- This change has been mar

Re: Review Request 121016: [RFC] Make it possible to make plasmawindow live in a status notifier

2014-11-07 Thread Aleix Pol Gonzalez
> On Nov. 7, 2014, 11:20 a.m., Sebastian Kügler wrote: > > plasma-windowed/plasmawindowedview.cpp, line 44 > > > > > > I wonder if the background here should be transparant? Well, what would you get instead? You

Re: Review Request 121016: [RFC] Make it possible to make plasmawindow live in a status notifier

2014-11-07 Thread Aleix Pol Gonzalez
> On Nov. 6, 2014, 7:36 p.m., Marco Martin wrote: > > I kinda like the idea, having a way to export systray plasmoids to other > > environments is nice. something that's a bit scary tough are the echos of > > ksystraycmd. I never understood the big fuss around ksystraycmd. It always sounded li

Re: Regressions in Plasma 5

2014-11-07 Thread Philipp A.
2014-11-07 14:04 GMT+01:00 Ivan Čukić : > Not really, when implementing a new plasmoid version (most of the time, it > is mostly about rewriting than porting), you don't actually know every > little thing that the old one does. good point. i thought that complex stuff like the taskbar is analyze

Re: Regressions in Plasma 5

2014-11-07 Thread Ivan Čukić
> hmm, if that’s the case, the widget porters should have filed those when > releasing their ports. Not really, when implementing a new plasmoid version (most of the time, it is mostly about rewriting than porting), you don't actually know every little thing that the old one does. Not even if y

Re: Regressions in Plasma 5

2014-11-07 Thread Eike Hein
On 11/07/2014 01:38 PM, Philipp A. wrote: people, seriously? you might notice that i posted a bugzilla link for everything but one item. why do you feel the need to tell /me/ (who obviously has done his homework) that knee-jerk response even if it doesn’t apply to me? No, you misunderstand -

Re: Regressions in Plasma 5

2014-11-07 Thread Philipp A.
2014-11-07 13:05 GMT+01:00 David Edmundson : > If it's on bugzilla and marked as confirmed, it means we're going to do it. > > If it's on bugzilla and marked as invalid/wontfix it means we're not going > to do it > > If it's on bugzilla and marked as unconfirmed, then we collectively suck. > hmm,

Re: Regressions in Plasma 5

2014-11-07 Thread Marco Martin
On Friday 07 November 2014 13:05:25 David Edmundson wrote: > If it's on bugzilla and marked as unconfirmed, then we collectively suck. And most important (just as a general reminder even tough that's not the case now), if is *not* on bugzilla, it's going to be forgotten, so always make sure to

Re: Regressions in Plasma 5

2014-11-07 Thread Kai Uwe Broulik
Hi, first of all, things like these belong directly into https://bugs.kde.org instead of on the ML because here things like that tend to be forgotten under the pile of mails that arrive daily. >- Icon-only task manager has no option to open new instances via middle >click. Shift-click h

Re: Review Request 120997: Add timestamp to notification history

2014-11-07 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120997/ --- (Updated Nov. 7, 2014, 12:06 p.m.) Status -- This change has been ma

Re: Regressions in Plasma 5

2014-11-07 Thread David Edmundson
>Is there some central overview of the screpped and to-be-restored functionality lost in Plasma 5? If it's on bugzilla and marked as confirmed, it means we're going to do it. If it's on bugzilla and marked as invalid/wontfix it means we're not going to do it If it's on bugzilla and marked as unc

Regressions in Plasma 5

2014-11-07 Thread Philipp A.
Hi, Is there some central overview of the screpped and to-be-restored functionality lost in Plasma 5? I’m unhappy about some things: - Icon-only task manager has no option to open new instances via middle click. Shift-click has been just implemented, though

Review Request 121031: keep libmolletnetwork private

2014-11-07 Thread Harald Sitter
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121031/ --- Review request for Plasma. Repository: kio-extras Description ---

Re: Review Request 121013: Plasmate-Kdev: Add plasma project manager

2014-11-07 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121013/#review69976 --- Ship it! Looks good, some minor stuff below. plasmate/plugi

Re: Review Request 121016: [RFC] Make it possible to make plasmawindow live in a status notifier

2014-11-07 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121016/#review69975 --- Ship it! Really cool idea! Some niggles inline. plasma-wind

Re: Review Request 120997: Add timestamp to notification history

2014-11-07 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120997/#review69974 --- Ship it! Ship It! - Martin Klapetek On Nov. 5, 2014, 7:10

Re: Autostart scripts (ksmserver problem)

2014-11-07 Thread Martin Yrjölä
On Fri, Nov 7, 2014 at 8:48 AM, Jeremy Whiting wrote: > IMO we have two problems here. > > 1. the autostart kcm is showing scripts from ~/.config/autostart which > kinit doesn't start. since ~/.config/autostart is an xdg path that is > only meant to start .desktop files we probably shouldn't be sh