> On Nov. 7, 2014, 10:34 nachm., Thomas Lübking wrote: > > kcms/autostart/autostart.cpp, line 174 > > <https://git.reviewboard.kde.org/r/121058/diff/2/?file=327177#file327177line174> > > > > I don't want to be annoyin, but "isAutostart" in "Autostart::load()" > > and below "autostartdir" is probably suboptimal ;-) > > > > "requiresServiceFile" or similar? > > Jeremy Whiting wrote: > how about "inScriptSupportedDir" ?
- try to avoid negations (you'd have one here and for the continue) - I won't try to teach you English, ;-) but would it not be "inScriptSupportingDir" (as not the dir is supported by scripts, but the dir supports holding scripts) I however do not maintain this code, so I don't care that much either (just wanted to point out that isAutostart is pretty confusing in this context) - Thomas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121058/#review70020 ----------------------------------------------------------- On Nov. 7, 2014, 10:31 nachm., Jeremy Whiting wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/121058/ > ----------------------------------------------------------- > > (Updated Nov. 7, 2014, 10:31 nachm.) > > > Review request for Plasma and Luca Beltrame. > > > Repository: plasma-desktop > > > Description > ------- > > KLauncher doesn't start these, so we shouldn't list them. > > > Diffs > ----- > > kcms/autostart/autostart.cpp 8fe81ad7fc752936cd8ba1c799ad06bafd2c4006 > > Diff: https://git.reviewboard.kde.org/r/121058/diff/ > > > Testing > ------- > > an executable script (ssh-add.sh) in ~/.config/autostart/ doesn't appear in > the kcm here anymore. > > > Thanks, > > Jeremy Whiting > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
