Re: Review Request 120936: [KInfoCenter] Set the correct version

2014-11-05 Thread Hrvoje Senjan
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120936/ --- (Updated Nov. 6, 2014, 7:59 a.m.) Status -- This change has been mar

Re: Review Request 121004: Fix logout: Remove uneeded code to stop alt+f4 killing the window

2014-11-05 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121004/#review69924 --- for the record: there was no change in KWin. I just had a look

Re: Review Request 120936: [KInfoCenter] Set the correct version

2014-11-05 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120936/#review69923 --- Ship it! Modules/infosummary/infosum.cpp

[Breeze] [Bug 340617] Breeze dark theme has bright breeze dialog background

2014-11-05 Thread a.pronobis
https://bugs.kde.org/show_bug.cgi?id=340617 --- Comment #4 from a.prono...@gmail.com --- The other bug is happening on VM and has been marked as resolved by simply claiming it is a VM's problem. My problem occurs on regular hardware i7-4558U/Iris 5100 and none of the solutions mentioned in the oth

Re: Review Request 120949: Add imageprovider to fifteenpuzzle.

2014-11-05 Thread Jeremy Whiting
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120949/ --- (Updated Nov. 5, 2014, 7:23 p.m.) Review request for Plasma. Changes --

Re: Help!! Missing symbol, possible ABI break?

2014-11-05 Thread Harald Sitter
And since I am bad at making myself clear false alarm. nothing to see here. move along. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Help!! Missing symbol, possible ABI break?

2014-11-05 Thread Harald Sitter
On Thu, Nov 6, 2014 at 1:28 AM, Scarlett Clark wrote: > Hello everyone, I may have my first possible ABI break and I need some > assistance determining this. Please be kind, I am still learning C++. > > Missing symbol: #MISSING: 5.4.0# _ZN6Plasma6Applet16destroyedChangedEb@Base > 5.3.0+git20141101

Re: Review Request 120936: [KInfoCenter] Set the correct version

2014-11-05 Thread Hrvoje Senjan
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120936/ --- (Updated Nov. 6, 2014, 1 a.m.) Review request for Plasma. Changes -

Re: Review Request 121006: Bring back Notifications applet settings

2014-11-05 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121006/#review69920 --- Ship it! +1 from me. Maybe wait for Martin before shipping.

Review Request 121006: Bring back Notifications applet settings

2014-11-05 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121006/ --- Review request for Plasma and Martin Klapetek. Repository: plasma-workspa

Re: Review Request 121005: Adopt kapptemplate to Plasma 5 plasmoids

2014-11-05 Thread Simon Wächter
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121005/#review69916 --- Ship it! Ship It! - Simon Wächter On Nov. 5, 2014, 8 nachm

Re: Review Request 121005: Adopt kapptemplate to Plasma 5 plasmoids

2014-11-05 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121005/ --- (Updated Nov. 5, 2014, 7 p.m.) Status -- This change has been marked

Re: Review Request 121005: Adopt kapptemplate to Plasma 5 plasmoids

2014-11-05 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121005/#review69914 --- Ship it! Makes sense. - David Edmundson On Nov. 5, 2014, 6

Re: Review Request 121002: Add a small utility to sync kde5 config's back into kde4 settings + backport component chooser settings

2014-11-05 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121002/ --- (Updated Nov. 5, 2014, 6:51 p.m.) Status -- This change has been mar

Re: Review Request 121002: Add a small utility to sync kde5 config's back into kde4 settings + backport component chooser settings

2014-11-05 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121002/#review69911 --- Ship it! Looks good! Maybe you can port the similar code to t

Review Request 121005: Adopt kapptemplate to Plasma 5 plasmoids

2014-11-05 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121005/ --- Review request for Plasma and Simon Wächter. Repository: kapptemplate D

Re: Review Request 120997: Add timestamp to notification history

2014-11-05 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120997/ --- (Updated Nov. 5, 2014, 6:10 nachm.) Review request for Plasma, KDE Usabil

Jenkins build is back to stable : plasma-workspace_master_qt5 #1034

2014-11-05 Thread KDE CI System
See ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 121004: Fix logout: Remove uneeded code to stop alt+f4 killing the window

2014-11-05 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121004/#review69906 --- [18:19] d__ed: IIRC Alt+F4 code was added due to bug I report

Re: Review Request 121004: Fix logout: Remove uneeded code to stop alt+f4 killing the window

2014-11-05 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121004/ --- (Updated Nov. 5, 2014, 5:21 p.m.) Status -- This change has been mar

Jenkins build became unstable: plasma-workspace_master_qt5 #1033

2014-11-05 Thread KDE CI System
See ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 121004: Fix logout: Remove uneeded code to stop alt+f4 killing the window

2014-11-05 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121004/#review69903 --- Ship it! It fixes the bug for me, and makes me really happy.

Re: Review Request 121004: Fix logout: Remove uneeded code to stop alt+f4 killing the window

2014-11-05 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121004/ --- (Updated Nov. 5, 2014, 5:15 p.m.) Review request for Plasma. Bugs: 3383

Re: Review Request 121004: Fix logout: Remove uneeded code to stop alt+f4 killing the window

2014-11-05 Thread Bhushan Shah
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121004/#review69901 --- Related to https://bugs.kde.org/show_bug.cgi?id=338360 ? - Bh

Review Request 121004: Fix logout: Remove uneeded code to stop alt+f4 killing the window

2014-11-05 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121004/ --- Review request for Plasma. Repository: plasma-workspace Description ---

Re: Review Request 120993: Cleanup Notifications.qml

2014-11-05 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120993/ --- (Updated Nov. 5, 2014, 3:06 p.m.) Status -- This change has been mar

Review Request 121002: Add a small utility to sync kde5 config's back into kde4 settings + backport component chooser settings

2014-11-05 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121002/ --- Review request for Plasma. Repository: plasma-desktop Description -

Re: Review Request 120993: Cleanup Notifications.qml

2014-11-05 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120993/#review69895 --- Ship it! applets/notifications/package/contents/ui/Jobs.qml

Re: Review Request 120993: Cleanup Notifications.qml

2014-11-05 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120993/ --- (Updated Nov. 5, 2014, 1:54 nachm.) Review request for Plasma and Martin

Re: bluedevil and bluez5

2014-11-05 Thread Sebastian Kügler
On Wednesday 05 November 2014 13:47:07 Raymond Wooninck wrote: > On Wednesday 05 November 2014 13:43:37 Sebastian Kügler wrote: > > On Wednesday 05 November 2014 12:34:32 Jonathan Riddell wrote: > > > Ubuntu is wanting to move to bluez5, is bluedevil ready for this at all? > > > > > > > > > > > >

Re: Review Request 119813: Show activity-linked files in folder view option

2014-11-05 Thread Ivan Čukić
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119813/ --- (Updated Nov. 5, 2014, 12:46 p.m.) Status -- This change has been ma

Re: bluedevil and bluez5

2014-11-05 Thread Raymond Wooninck
On Wednesday 05 November 2014 13:43:37 Sebastian Kügler wrote: > On Wednesday 05 November 2014 12:34:32 Jonathan Riddell wrote: > > Ubuntu is wanting to move to bluez5, is bluedevil ready for this at all? > > > > Are there any plans for a KF5 release of bluedevil? > > Data point: I've been using

Jenkins build is back to normal : plasma-workspace_master_qt5 #1031

2014-11-05 Thread KDE CI System
See ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: bluedevil and bluez5

2014-11-05 Thread Sebastian Kügler
On Wednesday 05 November 2014 12:34:32 Jonathan Riddell wrote: > Ubuntu is wanting to move to bluez5, is bluedevil ready for this at all? > > Are there any plans for a KF5 release of bluedevil? Data point: I've been using bluedevil based on KF5 for a few weeks now, and other than one buildsystem

bluedevil and bluez5

2014-11-05 Thread Jonathan Riddell
Ubuntu is wanting to move to bluez5, is bluedevil ready for this at all? Are there any plans for a KF5 release of bluedevil? Jonathan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Build failed in Jenkins: plasma-workspace_master_qt5 #1030

2014-11-05 Thread KDE CI System
See Changes: [notmart] don't consider packages without images [aleixpol] Fix possible crash. -- [...truncated 1726 lines...] [ 26%] Built target plasma_packagestructure_layoutemplate [ 26

Re: Review Request 120997: Add timestamp to notification history

2014-11-05 Thread Emmanuel Pescosta
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120997/#review69883 --- applets/notifications/package/contents/ui/NotificationItem.qm

Re: Plasma port to Wayland

2014-11-05 Thread Aleix Pol
On Wed, Nov 5, 2014 at 11:35 AM, Marco Martin wrote: > On Wednesday 05 November 2014, Pier Luigi Fiorini wrote: > > > in turn means that KWindowSystem cannot depend on it. This needs > > > thinking and discussion on the framework mailing list. At the moment I > > > don't consider KWayland as suit

Re: Plasma port to Wayland

2014-11-05 Thread Martin Graesslin
On Wednesday 05 November 2014 11:56:06 Pier Luigi Fiorini wrote: > 2014-11-05 11:41 GMT+01:00 Martin Graesslin : > > On Wednesday 05 November 2014 11:32:20 Pier Luigi Fiorini wrote: > >> Some issues with the protocol might go un-noticed until someone uses > >> them during the Plasma port. > >> We h

Re: Plasma port to Wayland

2014-11-05 Thread Pier Luigi Fiorini
2014-11-05 11:41 GMT+01:00 Martin Graesslin : > On Wednesday 05 November 2014 11:32:20 Pier Luigi Fiorini wrote: >> Some issues with the protocol might go un-noticed until someone uses >> them during the Plasma port. >> We had a first round of discussion and that lead to good results but >> the pro

Re: Plasma port to Wayland

2014-11-05 Thread Sebastian Kügler
On Wednesday 05 November 2014 11:40:10 Marco Martin wrote: > On Monday 03 November 2014, Pier Luigi Fiorini wrote: > > - plasma-framework > > > > > > git clone -b wayland > > kde:clones/plasma-framework/pierluigifiorini/wayland.git > > i'm interested in looking in this, but > > fatal: remote

Re: Plasma port to Wayland

2014-11-05 Thread Sebastian Kügler
On Wednesday 05 November 2014 11:19:07 Pier Luigi Fiorini wrote: > > Otherwise, we're waiting for the ECM to be merged? The RR has a shipit, so > > I guess that can go in, and we can proceed with merging other patches in. > > Do you need any help with that? > > We have several dependencies involve

Re: Plasma port to Wayland

2014-11-05 Thread Martin Graesslin
On Wednesday 05 November 2014 11:43:28 Marco Martin wrote: > On Wednesday 05 November 2014, Martin Graesslin wrote: > > > Having a lot of patches living in personal branches makes thing too > > > hard and slow IMHO. > > > > on that I agree, but the answer to that problem cannot be that we don't >

Re: Review Request 120993: Cleanup Notifications.qml

2014-11-05 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120993/#review69880 --- Sorry, I forgot to adjust the addNotification call in Jobs.qml

Re: Plasma port to Wayland

2014-11-05 Thread Marco Martin
On Wednesday 05 November 2014, Martin Graesslin wrote: > > > > Having a lot of patches living in personal branches makes thing too > > hard and slow IMHO. > > on that I agree, but the answer to that problem cannot be that we don't > provide ABI for KWayland::Client. There must be a solution which

Re: Plasma port to Wayland

2014-11-05 Thread Martin Graesslin
On Wednesday 05 November 2014 11:32:20 Pier Luigi Fiorini wrote: > Some issues with the protocol might go un-noticed until someone uses > them during the Plasma port. > We had a first round of discussion and that lead to good results but > the protocols evolved a little bit after that when I worked

Re: Plasma port to Wayland

2014-11-05 Thread Marco Martin
On Monday 03 November 2014, Pier Luigi Fiorini wrote: > - plasma-framework > > git clone -b wayland > kde:clones/plasma-framework/pierluigifiorini/wayland.git i'm interested in looking in this, but fatal: remote error: access denied or repository not exported: /clones/plasma- framework/pierlu

Re: Plasma port to Wayland

2014-11-05 Thread Marco Martin
On Wednesday 05 November 2014, Pier Luigi Fiorini wrote: > > in turn means that KWindowSystem cannot depend on it. This needs > > thinking and discussion on the framework mailing list. At the moment I > > don't consider KWayland as suited for a framework yet. > > KWayland shouldn't be considered a

Re: Plasma port to Wayland

2014-11-05 Thread Pier Luigi Fiorini
2014-11-05 11:01 GMT+01:00 Martin Graesslin : > On Wednesday 05 November 2014 10:37:59 Sebastian Kügler wrote: >> >> Otherwise, we're waiting for the ECM to be merged? The RR has a shipit, so I >> guess that can go in, and we can proceed with merging other patches in. Do >> you need any help with t

Re: Review Request 120997: Add timestamp to notification history

2014-11-05 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120997/#review69879 --- applets/notifications/package/contents/ui/NotificationItem.qm

Re: Plasma port to Wayland

2014-11-05 Thread Pier Luigi Fiorini
2014-11-05 10:37 GMT+01:00 Sebastian Kügler : > Hi Pier Luigi, > > Thanks for the updates, such a high-level overview is much appreciated. Some > question inline below. > > On Monday 03 November 2014 12:45:14 Pier Luigi Fiorini wrote: >> As some of you might know I've been working on the Plasma por

Re: Review Request 120997: Add timestamp to notification history

2014-11-05 Thread Martin Klapetek
> On Nov. 5, 2014, 10:41 a.m., Thomas Pfeiffer wrote: > > Great work, this looks very useful, and big bonus points for implementing > > the relative timestamps! > > > > One thing: What happens with notifications from previous days? This sounds > > a bit like an edge case, but for notifications

Re: Plasma port to Wayland

2014-11-05 Thread Martin Graesslin
On Wednesday 05 November 2014 10:37:59 Sebastian Kügler wrote: > Hi Pier Luigi, > > Thanks for the updates, such a high-level overview is much appreciated. Some > question inline below. > > On Monday 03 November 2014 12:45:14 Pier Luigi Fiorini wrote: > > As some of you might know I've been work

Re: Review Request 120997: Add timestamp to notification history

2014-11-05 Thread Thomas Pfeiffer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120997/#review69875 --- Great work, this looks very useful, and big bonus points for i

Re: Plasma port to Wayland

2014-11-05 Thread Sebastian Kügler
Hi Pier Luigi, Thanks for the updates, such a high-level overview is much appreciated. Some question inline below. On Monday 03 November 2014 12:45:14 Pier Luigi Fiorini wrote: > As some of you might know I've been working on the Plasma port to Wayland. > > I would like to give you some pointer

Re: [plasma-devel] Re: Release Schedule adjustments

2014-11-05 Thread Sebastian Kügler
On Tuesday 04 November 2014 15:48:52 Jonathan Riddell wrote: > On Tue, Nov 04, 2014 at 04:45:04PM +0100, Sebastian Kügler wrote: > > Tagging on Thursday means release on Tuesday, 27th January, right? Should > > I add it to the schedule? > > That's right but it is already part of the table on the