> On Nov. 5, 2014, 10:41 a.m., Thomas Pfeiffer wrote: > > Great work, this looks very useful, and big bonus points for implementing > > the relative timestamps! > > > > One thing: What happens with notifications from previous days? This sounds > > a bit like an edge case, but for notifications that stay indefinitely and > > users (mostly devs and admins I guess) that don't reboot their computer > > daily, ir would be relevant. > > > > We could then just write "Yesterday", "2 days ago" etc. If this is not too > > much work, I'd switch from time to "Yesterday" at t-24h. Users should be > > able to realuze that a timestamp which is later than the current time is > > likely from yesterday, but beyond 24hrs, it could be confusing.
There is actually a timer that will remove the notification from the history after 10 minutes when the computer is not idle (ie. when you are present at the computer). So having a notification stick around for 2 days would happen only if you haven't touched the mouse and/or any other input device for two days .) - Martin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120997/#review69875 ----------------------------------------------------------- On Nov. 4, 2014, 10:33 p.m., Kai Uwe Broulik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/120997/ > ----------------------------------------------------------- > > (Updated Nov. 4, 2014, 10:33 p.m.) > > > Review request for Plasma, KDE Usability and Martin Klapetek. > > > Repository: plasma-workspace > > > Description > ------- > > This simple patch shows the time when a notification was added to the history. > > Of course would be fancy to have "1min ago", "5min ago" etc but that's much > more complicated since we cannot listen to changes of a Date() object but > would need to pull in the dataengine and then we get timezone sync issues and > what not. So this just stores a Date() object and displays it as hours. > > > Diffs > ----- > > applets/notifications/package/contents/ui/Notifications.qml 47a475a > applets/notifications/package/contents/ui/NotificationDelegate.qml 75bcfd5 > applets/notifications/package/contents/ui/NotificationItem.qml 724cc13 > > Diff: https://git.reviewboard.kde.org/r/120997/diff/ > > > Testing > ------- > > Pretty nifty! The looks could be improved a bit I guess. > > > File Attachments > ---------------- > > Notification history with timestamp > > https://git.reviewboard.kde.org/media/uploaded/files/2014/11/04/20f3c850-0f64-4807-bbde-064bf730d830__notificationtimestamp.png > Multiple notifications with relative time > > https://git.reviewboard.kde.org/media/uploaded/files/2014/11/04/f4979255-2971-4458-bf2c-ec05819591e5__notificationtimestamp1.png > > > Thanks, > > Kai Uwe Broulik > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
