----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120993/#review69895 -----------------------------------------------------------
Ship it! applets/notifications/package/contents/ui/Jobs.qml <https://git.reviewboard.kde.org/r/120993/#comment48911> Now seeing it, it should be "i18n("Open...")", ie. it should have the "..." at the end - Martin Klapetek On Nov. 5, 2014, 2:54 p.m., Kai Uwe Broulik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/120993/ > ----------------------------------------------------------- > > (Updated Nov. 5, 2014, 2:54 p.m.) > > > Review request for Plasma and Martin Klapetek. > > > Repository: plasma-workspace > > > Description > ------- > > This cleans up the code in Notifications.qml a bit > - Some minor code style stuff > - new Array() ? [] > - Pass the notification object we get from the data engine to > addNotification directly to avoid this ugly function with dozen parameters > and creating the object ourselves which we alredy almost get for free already > - Push actions into array directly instead of creating a new Object, > settings its properties and then pushing it > > > Diffs > ----- > > applets/notifications/package/contents/ui/Jobs.qml e48a466 > applets/notifications/package/contents/ui/Notifications.qml 47a475a > > Diff: https://git.reviewboard.kde.org/r/120993/diff/ > > > Testing > ------- > > Didn't notice anything unusual after running knotificationsdbustest > > > Thanks, > > Kai Uwe Broulik > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
