Re: Review Request 120542: Plasmate-Kdev: Add packagemanagerview

2014-10-09 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120542/#review68192 --- I know I've said that before, but I'm a stubborn person. It w

Re: Should favourites be shared between launchers, and launcher instances?

2014-10-09 Thread David Edmundson
How are we doing with: >regardless what method will be used, there should be an api for that in the scripting api I don't want this missed, as it will mess up certain important distros that configure their favourites. ___ Plasma-devel mailing list Plas

Re: Plasma 5.1.0

2014-10-09 Thread Albert Astals Cid
El Dijous, 9 d'octubre de 2014, a les 14:26:48, Jonathan Riddell va escriure: > Plasma 5.1.0 tars up now at > http://starsky.19inch.net/~jr/tmp/plasma-5.1.0/ > and coming soon to depot > > sha256 sums at > https://www.kde.org/info/source-plasma-5.1.0.inc > > Release due on Tuesday. 4.14.2 rele

Re: Review Request 120526: Strip PowerDevilCore, PowerDevilUI and PowerDevil's kded from kdelibs4support

2014-10-09 Thread Àlex Fiestas
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120526/#review68180 --- Looks good, the qDebug though has to be ported to QCDebug so w

Review Request 120542: Plasmate-Kdev: Add packagemanagerview

2014-10-09 Thread Giorgos Tsiapaliokas
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120542/ --- Review request for Plasma. Repository: plasmate Description --- Th

Re: Review Request 120038: Plasmate-Kdev: Port plasmate to KDevPlatform's shell part 2

2014-10-09 Thread Giorgos Tsiapaliokas
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120038/ --- (Updated Oct. 9, 2014, 4:03 p.m.) Status -- This change has been mar

Plasma 5.1.0

2014-10-09 Thread Jonathan Riddell
Plasma 5.1.0 tars up now at http://starsky.19inch.net/~jr/tmp/plasma-5.1.0/ and coming soon to depot sha256 sums at https://www.kde.org/info/source-plasma-5.1.0.inc Release due on Tuesday. Enjoy Jonathan ___ Plasma-devel mailing list Plasma-devel@k

Re: Should favourites be shared between launchers, and launcher instances?

2014-10-09 Thread Marco Martin
eww, that was actually the thread i wanted to reply to. re-pasting here: Hi all, since now 5.1 is branched, i would like to revert commit c8adae02c993a Revert "Support per-activity favourites in Kickoff" to have it again in master and start to iron out possible problems in master in the meantim

Re: Review Request 119515: Support per-activity favourites

2014-10-09 Thread Marco Martin
Hi all, since now 5.1 is branched, i would like to revert commit c8adae02c993a Revert "Support per-activity favourites in Kickoff" to have it again in master and start to iron out possible problems in master in the meantime -- Marco Martin ___ Plasma

Re: Review Request 120538: Update default applications in kickoff

2014-10-09 Thread Sebastian Kügler
> On Oct. 9, 2014, 9:06 a.m., Kai Uwe Broulik wrote: > > Can't this be deduced from the default browser or default application to > > handle text/html? That way it will always be the distribution's preferred > > browser. > > Sebastian Kügler wrote: > The default browser is known by executa

Re: Review Request 120538: Update default applications in kickoff

2014-10-09 Thread Eike Hein
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120538/#review68140 --- Please hold off on committing this to the 5.1 branch until the

Re: Review Request 120538: Update default applications in kickoff

2014-10-09 Thread Eike Hein
> On Oct. 9, 2014, 9:06 a.m., Kai Uwe Broulik wrote: > > Can't this be deduced from the default browser or default application to > > handle text/html? That way it will always be the distribution's preferred > > browser. > > Sebastian Kügler wrote: > The default browser is known by executa

Re: Review Request 120538: Update default applications in kickoff

2014-10-09 Thread Martin Klapetek
> On Oct. 9, 2014, 11:06 a.m., Kai Uwe Broulik wrote: > > Can't this be deduced from the default browser or default application to > > handle text/html? That way it will always be the distribution's preferred > > browser. > > Sebastian Kügler wrote: > The default browser is known by execut

Re: Review Request 120538: Update default applications in kickoff

2014-10-09 Thread Sebastian Kügler
> On Oct. 9, 2014, 9:06 a.m., Kai Uwe Broulik wrote: > > Can't this be deduced from the default browser or default application to > > handle text/html? That way it will always be the distribution's preferred > > browser. > > Sebastian Kügler wrote: > The default browser is known by executa

Re: Review Request 120538: Update default applications in kickoff

2014-10-09 Thread Martin Klapetek
> On Oct. 9, 2014, 11:06 a.m., Kai Uwe Broulik wrote: > > Can't this be deduced from the default browser or default application to > > handle text/html? That way it will always be the distribution's preferred > > browser. > > Sebastian Kügler wrote: > The default browser is known by execut

Re: Review Request 120538: Update default applications in kickoff

2014-10-09 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120538/#review68131 --- applets/kickoff/core/favoritesmodel.cpp

Re: Review Request 120538: Update default applications in kickoff

2014-10-09 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120538/#review68130 --- Ship it! Ship It! - Sebastian Kügler On Oct. 9, 2014, 8:41

Re: Review Request 120538: Update default applications in kickoff

2014-10-09 Thread Sebastian Kügler
> On Oct. 9, 2014, 9:37 a.m., Jonathan Riddell wrote: > > I'd also like to proposed changing kwrite to kate, the only difference > > seems to be the sidebar with tabs for open files, but all users have known > > how to use tabs for years No problem with that, and I think nowadays, they're in t

Re: Review Request 120538: Update default applications in kickoff

2014-10-09 Thread Sebastian Kügler
> On Oct. 9, 2014, 9:06 a.m., Kai Uwe Broulik wrote: > > Can't this be deduced from the default browser or default application to > > handle text/html? That way it will always be the distribution's preferred > > browser. The default browser is known by executable name, so we'd still need to ge

Re: Review Request 120538: Update default applications in kickoff

2014-10-09 Thread Jonathan Riddell
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120538/#review68113 --- I'd also like to proposed changing kwrite to kate, the only di

Re: Review Request 120538: Update default applications in kickoff

2014-10-09 Thread Eike Hein
> On Oct. 9, 2014, 8:58 a.m., Jonathan Riddell wrote: > > discussion also at: > > https://forum.kde.org/viewtopic.php?f=285&t=123201 If this gets in a similar patch has to be written for Kicker, they should be in sync. - Eike --- This

Re: Review Request 120538: Update default applications in kickoff

2014-10-09 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120538/#review68111 --- Can't this be deduced from the default browser or default appl

Re: Review Request 120538: Update default applications in kickoff

2014-10-09 Thread Jonathan Riddell
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120538/#review68110 --- discussion also at: https://forum.kde.org/viewtopic.php?f=285&

Review Request 120538: Update default applications in kickoff

2014-10-09 Thread Jonathan Riddell
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120538/ --- Review request for Plasma. Repository: plasma-desktop Description -

Re: Jenkins build is still unstable: plasma-desktop_master_qt5 #688

2014-10-09 Thread Marco Martin
On Wednesday 08 October 2014 21:54:31 David Edmundson wrote: > This is a legitimate warning from Jenkins, we changed the lookandfeel KCM's > colour saving, and that test then broke. There's no point having a CI > system if we just ignore the errors. > > I don't understand the patch that broke it: