-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120038/
-----------------------------------------------------------
(Updated Oct. 9, 2014, 4:03 p.m.)
Status
------
This change has been marked as submitted.
Review request for Plasma.
Repository: plasmate
Description
-------
This is the second part of the review 'Port plasmate to KDevPlatform's shell'.
This review contains various removes from plasmate's source code.
The removed code is either depracated due to the port to KDevPlatform
or it hasn't been used by anyone AFAIK since 2011.
Also this review changes the directory structure of plasmate's repository.
This change makes sense with the new plugins that will be added and it reflects
the KDevelop's one.
So the new directory structure is something like
plasmate
-plasmate
--app (this is the place from which the plasmate binary will be created)
--plugins (It's not there yet because we don't have any yet :)
-plasmoidviewer
-engineexplorer
Here is the list of commits for this review
Commits:
The big cleanup.
Most of those stuff are deprecated due to the port to KDevPlatform
and the rest of them are leftover from years ago
----
Change the directory structure of plasmate/plasmate
* move all the Startpage related files to plasmate/plasmate/app/startpage
* move the Startpage related tests to plasmate/plasmate/app/tests
* move ProjectManager::exportProject to Publisher::exportProject.
the ProjectManager wasn't making any use of it and by moving the
method, the Publisher doesn't depend anymore to the ProjectManager
-----
Cleanup the packagehandler, plasmoidhandler and themehandler
We will use KDevelop::PackageModel which is a QAIM with its own
info so we don't need our nodes. What we need is a a way
(PackageModel::description) which will associate for example
the filename "main.qml" to "Mainscript".
Diffs
-----
plasmate/tests/modeltest.cpp d356b26
plasmate/tests/packagemodeltest.h 806d8f1
plasmate/tests/packagemodeltest.cpp 27907d6
plasmate/tests/plasmoidhandlertest.h e888c53
plasmate/tests/plasmoidhandlertest.cpp a6abc98
plasmate/tests/projecthandlertest.h 8f6b903
plasmate/tests/projecthandlertest.cpp afeca9c
plasmate/sidebartablewidget.cpp c9980e1
plasmate/startpage.h a81176c
plasmate/startpage.cpp ab94392
plasmate/startpage.ui
plasmate/test-kpart/CMakeLists.txt 761afcd
plasmate/test-kpart/kparttut1ui.rc a76749e
plasmate/test-kpart/main.cpp 9d67674
plasmate/test-kpart/mainwindow.h ea517b3
plasmate/test-kpart/mainwindow.cpp a18a66a
plasmate/tests/CMakeLists.txt 1b5632a
plasmate/tests/modeltest.h 45c68f4
plasmate/sidebardelegate.cpp 07992ac
plasmate/sidebaritem.cpp 40ffc99
plasmate/sidebartablewidget.h 73856e7
plasmate/projectmanager/projectmanager.cpp d691b44
plasmate/publisher/publisher.h 1faa149
plasmate/publisher/publisher.cpp 52173a9
plasmate/sidebar.h 08f26eb
plasmate/sidebar.cpp 7b7aff1
plasmate/sidebardelegate.h 09fc506
plasmate/projecthandler.cpp
plasmate/projectmanager/projectmanager.h 7a0f875
plasmate/plasmate.desktop
plasmate/plasmate.knsrc
plasmate/projecthandler.h
plasmate/packagemodel.h 2ac1cb2
plasmate/packagemodel.cpp 93f158a
plasmate/packagehandler/packagehandler.h 7dbc3bb
plasmate/packagehandler/packagehandler.cpp ead1f37
plasmate/packagehandler/plasmoidhandler.h 11ca4ae
plasmate/packagehandler/plasmoidhandler.cpp 60009c9
plasmate/packagehandler/themehandler.h 6c95d83
plasmate/packagehandler/themehandler.cpp 4d88361
plasmate/editors/svg/tests/battery-oxygen-inkscape.svgz ce87277
plasmate/editors/svg/tests/battery-oxygen.svgz ce87277
plasmate/editors/svg/tests/test_svg.cpp bc725ab
plasmate/editors/text/texteditor.h 4ab8eed
plasmate/editors/text/texteditor.cpp 2e346ca
plasmate/mainwindow.h a609750
plasmate/mainwindow.cpp c7c95a9
plasmate/modeltest/dynamictreemodel.h 6fbd02a
plasmate/modeltest/dynamictreemodel.cpp 2428ebe
plasmate/modeltest/modeltest.h a5a6777
plasmate/modeltest/modeltest.cpp a5f1fe1
plasmate/editors/svg/tests/background.svg ca130f2
plasmate/editors/svg/tests/background.svgz f9e4b1d
plasmate/editors/editpage.h 98a09ca
plasmate/editors/editpage.cpp f21ec25
plasmate/editors/metadata/metadataeditor.cpp c07fafd
plasmate/editors/svg/CMakeLists.txt 0214310
plasmate/editors/svg/svgviewer.h 01d4856
plasmate/editors/svg/svgviewer.cpp 469b3ff
plasmate/dockwidgetshandler.h 5a68554
plasmate/dockwidgetshandler.cpp 274bec8
plasmate/editors/CMakeLists.txt e8a11d0
plasmate/CMakeLists.txt 5415db7
plasmate/app/CMakeLists.txt PRE-CREATION
plasmate/app/main.cpp 3790ac2
plasmate/app/plasmateapp.cpp 46dda60
plasmate/app/tests/CMakeLists.txt PRE-CREATION
plasmate/tests/themehandlertest.h a080d14
plasmate/tests/themehandlertest.cpp 42dab7b
Diff: https://git.reviewboard.kde.org/r/120038/diff/
Testing
-------
Thanks,
Giorgos Tsiapaliokas
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
