> On Oct. 9, 2014, 9:06 a.m., Kai Uwe Broulik wrote: > > Can't this be deduced from the default browser or default application to > > handle text/html? That way it will always be the distribution's preferred > > browser. > > Sebastian Kügler wrote: > The default browser is known by executable name, so we'd still need to > get the service for it, and use that (for icon, readable name, and so on). So > I think this way of doing it is correct. > > Martin Klapetek wrote: > Right, but you'd get the default browser executable first rather than our > own predefined list (which I think was Kai's point) > > Sebastian Kügler wrote: > Can't say that I understand completely, but yes, there's a difference > between mimetype handler voor text/html and default browser? (They're set up > differently, at least.) > > Martin Klapetek wrote: > To reiterate then - find out the default browser either from the default > browser setting or from the first text/html handler, instead of setting > predefined priority to the browsers ourselves and choosing the first one that > was found. An example: user has Chromium as default but also has installed > Firefox, this code would put Firefox in his favorites even though his default > browser is Chromium. So it would make more sense to put Chromium there rather > than Firefox, which was simply before Chromium in the list in this patch. > > Eike Hein wrote: > It's worth noting that libtaskmanager supports a magic preferred:// URL > scheme to allow distros to make default Task Manager launchers that start > e.g. the preferred file manager or web browser. If I implement this for > Kicker I will likely reimplement the same approach there, because Kicker > cleanly uses KConfigXT <default> for defaults, and while KConfigXT supports > embedded C++ snippets for computed default values, those aren't possible in > the runtime-only KConfigXT implementation in Plasma.
Ah right, I misread the patch, just seeing that it will pick the first browser it finds, not compare it to the default browser. So yes, that would need fixing. (Though it probably works accidentally, since K is pretty late in the alphabet, both Firefox and Chromium are before it, and they're unlikely to be both already installed at first startup, when favourites are computed.) - Sebastian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120538/#review68111 ----------------------------------------------------------- On Oct. 9, 2014, 8:41 a.m., Jonathan Riddell wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/120538/ > ----------------------------------------------------------- > > (Updated Oct. 9, 2014, 8:41 a.m.) > > > Review request for Plasma. > > > Repository: plasma-desktop > > > Description > ------- > > instead of defaulting to konqueror find the first browser from a list > change konsole to ktp-contactlist, we want to appeal to non geeks > change kmail for kontact, we provide a lovely PIM suite so we should show it > by default > > > Diffs > ----- > > applets/kickoff/core/favoritesmodel.cpp > e26cf802a186b5a0f7627124ee1013e8b022bfe2 > > Diff: https://git.reviewboard.kde.org/r/120538/diff/ > > > Testing > ------- > > make a new user, start up plasma > > > Thanks, > > Jonathan Riddell > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
