Re: Review Request 114910: Patch for bug 317066 ("systray leaves garbage on the panel when resizing ")

2014-07-29 Thread Dmitry Ivanov
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114910/ --- (Updated July 29, 2014, 9:03 p.m.) Status -- This change has been ma

Re: Using more of our CI, Coverage and cppcheck

2014-07-29 Thread Àlex Fiestas
On Monday 28 July 2014 15:46:56 Aleix Pol wrote: > From the wiki: [1] > Do we need special powers to change these? > > Aleix > > [1] And add this option in the configuraiotn of your CI build: > http://quickgit.kde.org/?p=websites%2Fbuild-kde-org. [DEFAULT] > configureExtraArgs=-DBUILD_COVERAGE=ON

Re: Review Request 114910: Patch for bug 317066 ("systray leaves garbage on the panel when resizing ")

2014-07-29 Thread Albert Astals Cid
> On jul. 29, 2014, 5:12 p.m., Marco Martin wrote: > > Ship It! Marco, Dmitry doesn't have an account, can you please push this to 4.11? - Albert --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kd

Re: Review Request 119535: Move QML bindings for KUser to kdeclarative

2014-07-29 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119535/ --- (Updated July 29, 2014, 6:04 p.m.) Review request for KDE Frameworks and

Re: Review Request 119535: Move QML bindings for KUser to kdeclarative

2014-07-29 Thread Sebastian Kügler
> On July 29, 2014, 4:34 p.m., Bhushan Shah wrote: > > src/qmlcontrols/kcoreaddons/kcoreaddonsplugin.cpp, line 44 > > > > > > Maybe consider creating it a singleton type? > > Aleix Pol Gonzalez wrote: > Why?

Re: Review Request 119535: Move QML bindings for KUser to kdeclarative

2014-07-29 Thread Sebastian Kügler
> On July 29, 2014, 4:53 p.m., Bhushan Shah wrote: > > src/qmlcontrols/kcoreaddons/kuserproxy.h, line 96 > > > > > > why? nameChanged is not related here.. It's not visible API (the signal visible to QML has the

Re: Review Request 114910: Patch for bug 317066 ("systray leaves garbage on the panel when resizing ")

2014-07-29 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114910/#review63466 --- Ship it! Ship It! - Marco Martin On Jan. 8, 2014, 4:25 p.m

Re: Review Request 114910: Patch for bug 317066 ("systray leaves garbage on the panel when resizing ")

2014-07-29 Thread Marco Martin
> On July 29, 2014, 10:31 a.m., Marco Martin wrote: > > this would require some testing before pushing to 4.x, too delicate to just > > commit > > Dmitry Ivanov wrote: > Well, I've been living with this patch for half a year already, since > January 8 :) I used it with a number of KDE 4.x

Re: Review Request 114910: Patch for bug 317066 ("systray leaves garbage on the panel when resizing ")

2014-07-29 Thread Dmitry Ivanov
> On Июль 29, 2014, 2:31 п.п., Marco Martin wrote: > > this would require some testing before pushing to 4.x, too delicate to just > > commit Well, I've been living with this patch for half a year already, since January 8 :) I used it with a number of KDE 4.x versions from 4.11.3 to 4.13.1 (co

Re: Review Request 119535: Move QML bindings for KUser to kdeclarative

2014-07-29 Thread Bhushan Shah
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119535/#review63459 --- src/qmlcontrols/kcoreaddons/kuserproxy.h

Re: Minutes Monday Plasma Hangout

2014-07-29 Thread Marco Martin
On Tuesday 29 July 2014, Aleix Pol wrote: > > khintsettings should do something along the lines: > > * with some heuristics access the lookandfeel package (it's only a folder > > after all, wouldn't be very difficult) and open a config file with > > default icons/widget style etc > > * read the def

Re: Review Request 119535: Move QML bindings for KUser to kdeclarative

2014-07-29 Thread Bhushan Shah
> On July 29, 2014, 10:04 p.m., Bhushan Shah wrote: > > src/qmlcontrols/kcoreaddons/kcoreaddonsplugin.cpp, line 44 > > > > > > Maybe consider creating it a singleton type? > > Aleix Pol Gonzalez wrote: > Why?

Re: Review Request 119535: Move QML bindings for KUser to kdeclarative

2014-07-29 Thread Marco Martin
> On July 29, 2014, 2:33 p.m., Aleix Pol Gonzalez wrote: > > Can we consider including this in KCoreAddons? > > > > I know KCoreAddons should only depend on QtCore, but then we can make it an > > optional dependency. If Qt5::Qml is there, then build the Qml plugin too. > > Marco Martin wrote:

Re: Review Request 119535: Move QML bindings for KUser to kdeclarative

2014-07-29 Thread Aleix Pol Gonzalez
> On July 29, 2014, 4:34 p.m., Bhushan Shah wrote: > > src/qmlcontrols/kcoreaddons/kcoreaddonsplugin.cpp, line 44 > > > > > > Maybe consider creating it a singleton type? Why? In fact, I think it's usually harder

Re: Review Request 119535: Move QML bindings for KUser to kdeclarative

2014-07-29 Thread David Edmundson
> On July 29, 2014, 2:33 p.m., Aleix Pol Gonzalez wrote: > > Can we consider including this in KCoreAddons? > > > > I know KCoreAddons should only depend on QtCore, but then we can make it an > > optional dependency. If Qt5::Qml is there, then build the Qml plugin too. > > Marco Martin wrote:

Jenkins build is back to normal : plasma-workspace_master_qt5 #679

2014-07-29 Thread KDE CI System
See ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 119535: Move QML bindings for KUser to kdeclarative

2014-07-29 Thread Bhushan Shah
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119535/#review63453 --- src/qmlcontrols/kcoreaddons/kcoreaddonsplugin.cpp

Re: Review Request 119535: Move QML bindings for KUser to kdeclarative

2014-07-29 Thread Marco Martin
> On July 29, 2014, 2:33 p.m., Aleix Pol Gonzalez wrote: > > Can we consider including this in KCoreAddons? > > > > I know KCoreAddons should only depend on QtCore, but then we can make it an > > optional dependency. If Qt5::Qml is there, then build the Qml plugin too. KCoreAddons can depend f

Re: Review Request 119534: take defaults from a plasma look and feel package, if available

2014-07-29 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119534/ --- (Updated July 29, 2014, 4:22 p.m.) Review request for KDE Frameworks and

Build failed in Jenkins: plasma-workspace_master_qt5 #678

2014-07-29 Thread KDE CI System
See Changes: [aleixpol] Force OpenGLES when running on Qt 5.4 -- [...truncated 1265 lines...] Generating moc_fakebacktracegenerator.cpp [ 22%] Built target backtraceparsertest_automoc [ 22%

Re: Review Request 119524: Force OpenGLES if on Qt 5.4

2014-07-29 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119524/ --- (Updated July 29, 2014, 4:15 p.m.) Status -- This change has been ma

Re: Review Request 118180: slideshow BUG patch fix

2014-07-29 Thread TOM Harrison
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118180/#review63445 --- weird issue when using reviewboard with the chrome. that why t

Re: Review Request 118180: slideshow BUG patch fix

2014-07-29 Thread TOM Harrison
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118180/ --- (Updated July 29, 2014, 3:24 p.m.) Review request for kde-workspace and P

Re: Review Request 118180: slideshow BUG patch fix

2014-07-29 Thread TOM Harrison
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118180/ --- (Updated 七月 29, 2014, 3:19 p.m.) Status -- This change has been disc

Re: Review Request 119535: Move QML bindings for KUser to kdeclarative

2014-07-29 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119535/#review63443 --- Looks damn good, especially the documentation and example. Mi

Re: Review Request 119535: Move QML bindings for KUser to kdeclarative

2014-07-29 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119535/#review63441 --- Can we consider including this in KCoreAddons? I know KCoreAd

Re: Review Request 119535: Move QML bindings for KUser to kdeclarative

2014-07-29 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119535/ --- (Updated July 29, 2014, 2:31 p.m.) Review request for KDE Frameworks and

Re: Review Request 118180: slideshow BUG patch fix

2014-07-29 Thread TOM Harrison
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118180/ --- (Updated 七月 29, 2014, 2:15 p.m.) Review request for kde-workspace and Pla

Re: Review Request 119524: Force OpenGLES if on Qt 5.4

2014-07-29 Thread Aleix Pol Gonzalez
> On July 29, 2014, 2:01 p.m., Sebastian Kügler wrote: > > I'm all for this, as it means we reduce the set of features we use from the > > underlying stack. We're even focusing on the features that will get more > > testing (since it's mobile, and that's the hype). I consider it an > > advanta

Re: Review Request 119524: Force OpenGLES if on Qt 5.4

2014-07-29 Thread Sebastian Kügler
> On July 29, 2014, 2:01 p.m., Sebastian Kügler wrote: > > I'm all for this, as it means we reduce the set of features we use from the > > underlying stack. We're even focusing on the features that will get more > > testing (since it's mobile, and that's the hype). I consider it an > > advanta

Re: Review Request 119524: Force OpenGLES if on Qt 5.4

2014-07-29 Thread David Edmundson
> On July 29, 2014, 2:01 p.m., Sebastian Kügler wrote: > > I'm all for this, as it means we reduce the set of features we use from the > > underlying stack. We're even focusing on the features that will get more > > testing (since it's mobile, and that's the hype). I consider it an > > advanta

Re: Review Request 119524: Force OpenGLES if on Qt 5.4

2014-07-29 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119524/#review63437 --- Ship it! I'm all for this, as it means we reduce the set of f

Re: Review Request 100743: Add a system tray option to always show all items

2014-07-29 Thread David Edmundson
Either way this patch no longer applies. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 100743: Add a system tray option to always show all items

2014-07-29 Thread cyberbeat
Hi, I am sad about this. As there is disagreement about this patch, perhaps a voting (kde forums/..) would help? A positive vote could perhaps motivate to implement this for 5.x? Volker Am 29.07.2014 11:08, schrieb Jonathan Marten: This is an automatically generated e-mail. To reply, visi

Re: Review Request 119524: Force OpenGLES if on Qt 5.4

2014-07-29 Thread Eike Hein
> On July 28, 2014, 6:25 p.m., Eike Hein wrote: > > Can you recompile plasma-desktop with OpenGL ES and test if the drag pixmap > > for Folder icons works? > > > > I wrote the code in a way that ought to work on both desktop GL and ES, but > > it's worth testing. > > Aleix Pol Gonzalez wrote:

Re: Review Request 118540: Two patches required to build kde-cli-tools 20140603 snapshot on top of KDE Frameworks 4.100.0

2014-07-29 Thread Eric Hameleers
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118540/ --- (Updated July 29, 2014, 1:29 p.m.) Status -- This change has been di

Re: Reviews

2014-07-29 Thread Bhushan Shah
Some more, https://git.reviewboard.kde.org/r/118540/ - Already in codebase https://git.reviewboard.kde.org/r/105319/ - No activity so far https://git.reviewboard.kde.org/r/105932/ - No activity and can't be applied on top of plasma 5 https://git.reviewboard.kde.org/r/106123/ - No activity and 4.8

Re: Review Request 119534: take defaults from a plasma look and feel package, if available

2014-07-29 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119534/ --- (Updated July 29, 2014, 1:25 p.m.) Review request for KDE Frameworks and

Review Request 119535: Move QML bindings for KUser to kdeclarative

2014-07-29 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119535/ --- Review request for Plasma. Repository: kdeclarative Description ---

Re: Review Request 116898: Get rid of unnecessary Q_INVOKABLE declarations

2014-07-29 Thread Shantanu Tushar
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116898/ --- (Updated July 29, 2014, 1:19 p.m.) Status -- This change has been di

Re: Review Request 111849: custom first week for plasmaclock.

2014-07-29 Thread Hu Zheng
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/111849/ --- (Updated July 29, 2014, 12:57 p.m.) Status -- This change has been d

Re: Review Request 119175: Create internal copy of kxmlrpcclient to get drkonqi to report bugs

2014-07-29 Thread Rohan Garg
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119175/ --- (Updated July 29, 2014, 12:54 p.m.) Status -- This change has been m

Re: Review Request 114055: Include translatoins sub-directory to CMakeLists.txt , Fedora Packaging fails searching for translations

2014-07-29 Thread Siddharth Sharma
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114055/ --- (Updated July 29, 2014, 12:53 p.m.) Status -- This change has been d

Re: Reviews

2014-07-29 Thread Bhushan Shah
On Tue, Jul 29, 2014 at 5:15 PM, Bhushan Shah wrote: > Following PMC reviews needs to be discarded, Some more, https://git.reviewboard.kde.org/r/114055/ - code is already in repo Non PMC, https://git.reviewboard.kde.org/r/117681/ - no review so far https://git.reviewboard.kde.org/r/119175/ -

Re: Review Request 116898: Get rid of unnecessary Q_INVOKABLE declarations

2014-07-29 Thread Bhushan Shah
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116898/#review63432 --- Ping, I think this can be closed. - Bhushan Shah On March 1

Re: Review Request 114428: Replaced Text {} by Label {} using PlasmaComponents in mediaelements

2014-07-29 Thread Bhushan Shah
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114428/#review63431 --- Ping, whats status on this? can this be submitted? - Bhushan

Re: Review Request 118866: Start playing after Play All is used

2014-07-29 Thread Shantanu Tushar
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118866/ --- (Updated July 29, 2014, 12:35 p.m.) Review request for Plasma. Changes

Review Request 119534: take defaults from a plasma look and feel package, if available

2014-07-29 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119534/ --- Review request for KDE Frameworks and Plasma. Repository: frameworkintegr

Re: Review Request 111087: widget-taskbar: vertical text layout

2014-07-29 Thread Greg T
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/111087/ --- (Updated July 29, 2014, 12:16 p.m.) Status -- This change has been d

Re: Review Request 115865: Adds new components for different sized labels

2014-07-29 Thread Abhishek Shivanna
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115865/ --- (Updated July 29, 2014, 12:11 p.m.) Status -- This change has been d

Re: Review Request 116731: Bug Fix for Music Stats Labels (Bug 331882)

2014-07-29 Thread Atul Dubey
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116731/ --- (Updated July 29, 2014, 12:10 p.m.) Status -- This change has been d

Re: Review Request 116804: Bug Fix for the Footer time

2014-07-29 Thread Atul Dubey
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116804/ --- (Updated July 29, 2014, 12:10 p.m.) Status -- This change has been d

Re: Review Request 116460: Footer clock fix

2014-07-29 Thread Maulik Kotadia
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116460/ --- (Updated July 29, 2014, 12:10 p.m.) Status -- This change has been d

Re: Review Request 118866: Start playing after Play All is used

2014-07-29 Thread Bhushan Shah
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118866/#review63427 --- ping? - Bhushan Shah On June 21, 2014, 11:13 p.m., Shantanu

Re: Reviews

2014-07-29 Thread Shantanu Tushar Jha
This one needs to be discarded as well, https://git.reviewboard.kde.org/r/115865/ On Tue, Jul 29, 2014 at 5:15 PM, Bhushan Shah wrote: > Hello, > > On Tue, Jul 29, 2014 at 3:37 PM, David Edmundson > wrote: > > > > There are a /lot/ of Plasma Media Centre reviews open (about half are > > PMC),

Re: Review Request 117139: Make menu strings conform to KDE's usability guidelines. Capitalize menu words.

2014-07-29 Thread Bhushan Shah
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117139/#review63426 --- Ping, what is status on this? - Bhushan Shah On March 28, 2

Re: Reviews

2014-07-29 Thread Bhushan Shah
Hello, On Tue, Jul 29, 2014 at 3:37 PM, David Edmundson wrote: > > There are a /lot/ of Plasma Media Centre reviews open (about half are > PMC), I'm not sure what the state of those is, are they awaiting > reviews from the non-media centre devs, or just no longer relevant. If > someone from PMC p

Re: Review Request 118539: I needed this patch in order to succesfully compile a 20140603 git snapshot of plasma-desktop on top of KDE Frameworks 4.100.0

2014-07-29 Thread Bhushan Shah
> On June 5, 2014, 1:58 a.m., Marco Martin wrote: > > what is the stuff that still needs kdelibs4support? it shouldn't depend on > > it anymore > > Eric Hameleers wrote: > Files in the subdirectories of kcms/kfintinst/ contain includes for stuff > that I can only find in kdelibs4support. L

Re: Review Request 112789: Enable searchlaunch engine on KF5

2014-07-29 Thread Bhushan Shah
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/112789/ --- (Updated July 29, 2014, 4:54 p.m.) Status -- This change has been di

Re: Review Request 119404: Use full libexec location

2014-07-29 Thread Hrvoje Senjan
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119404/ --- (Updated July 29, 2014, 11:05 a.m.) Status -- This change has been m

Re: Reviews

2014-07-29 Thread Marco Martin
On Tuesday 29 July 2014, David Edmundson wrote: > Sorry for flooding the mailing list. > > I've spent the morning cleaning out some of Plasma's review requests. > One was nearly 4 years old. good stuff. on the list of reviews you posted, i commented on them, separing those that i think could be

Re: Review Request 109124: qml port currentappcontrol

2014-07-29 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/109124/#review63418 --- This should definitely be ported, since i've seen many people

Re: Review Request 114260: Port mouse dataengine

2014-07-29 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114260/#review63416 --- Ship it! fine to go - Marco Martin On Feb. 21, 2014, 6:54

Re: Review Request 112789: Enable searchlaunch engine on KF5

2014-07-29 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/112789/#review63415 --- this engine was mostly to expose a service to send queries fro

Re: Review Request 105779: plasma calendar - order events and todos by start date

2014-07-29 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/105779/#review63414 --- this would need more testing at this point before eventually p

Re: Review Request 114910: Patch for bug 317066 ("systray leaves garbage on the panel when resizing ")

2014-07-29 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114910/#review63413 --- this would require some testing before pushing to 4.x, too del

Re: Review Request 113697: Return focus to input widget after pressing alt key in the screen locker.

2014-07-29 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/113697/#review63412 --- Ship it! may be pushed to 4.x - Marco Martin On Nov. 27, 2

Re: Review Request 109780: Enable following links/urls from the plasma notifications popup applet

2014-07-29 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/109780/#review63411 --- Ship it! pushing this to 4.x would be fine - Marco Martin

Re: Review Request 109711: Fixes a bug in the KDE dataengine to use the POST method instead of GET which allows large text to be sent to the server

2014-07-29 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/109711/#review63410 --- Ship it! this should be done for both 4.x and the 5.x port -

Re: Reviews

2014-07-29 Thread Vishesh Handa
On Tue, Jul 29, 2014 at 12:07 PM, David Edmundson < da...@davidedmundson.co.uk> wrote: > There are a /lot/ of Plasma Media Centre reviews open (about half are > PMC), I'm not sure what the state of those is, are they awaiting > reviews from the non-media centre devs, or just no longer relevant. If

Re: qml controls and documentation

2014-07-29 Thread David Edmundson
There are .tags file made for most of Qt but not for qtquickcontrols. In order to make it work automatically we'd have to fix QtDoc first. :( ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 107869: Add a real konquerorsessions plugin for krunner

2014-07-29 Thread Sebastian Kügler
> On July 29, 2014, 9:17 a.m., Vishesh Handa wrote: > > File Attachment: the patch - > > 0002-Add-a-real-konquerorsessions-plugin_1.patch > > > > > > I don't really understand the whole "kate" comment. I think the code was originally c

Re: Review Request 107881: Rename krunner plugin konsolesessions to konsoleprofiles

2014-07-29 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/107881/#review63407 --- Ping. Jekyll, could you please rename the directory as Aaron

Re: Review Request 107868: Rename krunner plugin konquerorsessions to konquerorprofiles to match what it really does

2014-07-29 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/107868/#review63408 --- Jekyll, ping? - Vishesh Handa On Dec. 31, 2012, 7:12 p.m.,

Re: Review Request 119515: Support per-activity favourites

2014-07-29 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119515/#review63406 --- applets/kickoff/core/krunnermodel.cpp

Reviews

2014-07-29 Thread David Edmundson
Sorry for flooding the mailing list. I've spent the morning cleaning out some of Plasma's review requests. One was nearly 4 years old. The following reviews are for 4.x but seem to be non-invasive bug fixes that I /think/ we should backport. I'd like a second opinion from people more familiar wit

Re: Review Request 118180: slideshow BUG patch fix

2014-07-29 Thread TOM Harrison
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118180/ --- (Updated 七月 29, 2014, 10:05 a.m.) Review request for kde-workspace and Pl

Re: Review Request 119524: Force OpenGLES if on Qt 5.4

2014-07-29 Thread Mark Gaiser
> On jul 28, 2014, 7:03 p.m., Mark Gaiser wrote: > > If there is one hardware combination that works best on linux, it's OpenGL > > + Intel. > > I find it hard to believe that GLES is better and in all cases. That must > > be a driver/mesa bug that should be investigated and fixed. > > > > If

Re: Review Request 118180: slideshow BUG patch fix

2014-07-29 Thread TOM Harrison
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118180/ --- (Updated 七月 29, 2014, 10:04 a.m.) Review request for kde-workspace and Pl

Re: Review Request 104015: A usable system monitor plasmoid

2014-07-29 Thread rhn rhn
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/104015/ --- (Updated July 29, 2014, 9:57 a.m.) Status -- This change has been di

Re: Review Request 110608: Add support for keyboard backlight handling to the powermanagement dataengine

2014-07-29 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/110608/#review63402 --- submitted with http://quickgit.kde.org/?p=kde-workspace.git&a

Re: Review Request 110608: Add support for keyboard backlight handling to the powermanagement dataengine

2014-07-29 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/110608/ --- (Updated July 29, 2014, 9:55 a.m.) Status -- This change has been ma

Re: Review Request 101321: Add QSocket-binding to the Plasma Javascript scriptengine

2014-07-29 Thread Sebastian Sauer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/101321/ --- (Updated July 29, 2014, 9:47 a.m.) Status -- This change has been di

Re: Review Request 104603: [KActivityManagerDaemon] Activity Changed On Screen Display

2014-07-29 Thread makis marimpis
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/104603/ --- (Updated July 29, 2014, 9:45 a.m.) Status -- This change has been di

Re: Review Request 118180: slideshow BUG patch fix

2014-07-29 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118180/#review63401 --- Reviewboard wasn't showing the patch, not sure why. We can't d

Re: Review Request 118180: slideshow BUG patch fix

2014-07-29 Thread TOM Harrison
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118180/ --- (Updated July 29, 2014, 9:43 a.m.) Status -- This change has been di

Re: Review Request 106448: replace old kickoff with kickoff-qml

2014-07-29 Thread Greg T
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/106448/ --- (Updated July 29, 2014, 9:42 a.m.) Status -- This change has been di

Re: Review Request 107428: make the DeviceNotifier Plasmoid scale with high-res screens

2014-07-29 Thread Michael Zanetti
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/107428/ --- (Updated July 29, 2014, 9:35 a.m.) Status -- This change has been di

Re: Review Request 105924: plasma calendar - event system config option

2014-07-29 Thread Greg T
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/105924/ --- (Updated July 29, 2014, 9:32 a.m.) Status -- This change has been di

Re: Review Request 106978: Fix Inconsistencies and Bugs in Activity Bar's Size Hinting

2014-07-29 Thread David Narváez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/106978/ --- (Updated July 29, 2014, 9:27 a.m.) Status -- This change has been di

Re: Review Request 102464: Add scrollbar support for the Web Slice plasmoid

2014-07-29 Thread Javier Llorente
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/102464/ --- (Updated July 29, 2014, 9:26 a.m.) Status -- This change has been di

Re: Review Request 107869: Add a real konquerorsessions plugin for krunner

2014-07-29 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/107869/#review63399 --- The coding style in the entire review is off. File Attachmen

Re: Review Request 102905: ensure activity resources exist

2014-07-29 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/102905/ --- (Updated July 29, 2014, 9:11 a.m.) Status -- This change has been di

Re: Review Request 119336: Convert FrameSvg to 9 textures: different approach

2014-07-29 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119336/ --- (Updated July 29, 2014, 9:10 a.m.) Status -- This change has been di

Re: Review Request 100743: Add a system tray option to always show all items

2014-07-29 Thread Jonathan Marten
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/100743/ --- (Updated July 29, 2014, 9:08 a.m.) Status -- This change has been di

Re: Review Request 115727: Deafult for not executing kwalletmanager once a wallet is open

2014-07-29 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115727/#review63398 --- What's the status of this. Can we at least merge this in 5.x?

Re: Review Request 101074: Chime Time Implementation

2014-07-29 Thread Sunny Sharma
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/101074/ --- (Updated July 29, 2014, 9:06 a.m.) Status -- This change has been di

Re: Review Request 119404: Use full libexec location

2014-07-29 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119404/#review63394 --- Ship it! - David Edmundson On July 22, 2014, 12:09 p.m., Hr

Re: Review Request 119336: Convert FrameSvg to 9 textures: different approach

2014-07-29 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119336/#review63396 --- Is this still useful? - David Edmundson On July 17, 2014, 8

Re: Review Request 119522: readlink fails whens the folder does not exist.

2014-07-29 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119522/#review63393 --- Ship it! Ship It! - David Edmundson On July 28, 2014, 5:17

  1   2   >