----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116898/#review63432 -----------------------------------------------------------
Ping, I think this can be closed. - Bhushan Shah On March 19, 2014, 6:19 p.m., Shantanu Tushar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/116898/ > ----------------------------------------------------------- > > (Updated March 19, 2014, 6:19 p.m.) > > > Review request for Plasma and Sujith Haridasan. > > > Repository: plasma-mediacenter > > > Description > ------- > > Methods supposed to be used as READ of Q_PROPERTY properties need not be > invokable. Same goes for slots. > > > Diffs > ----- > > libs/mpris2/mediaplayer2.h e68bc5c > libs/mpris2/mediaplayer2player.h 203d681 > libs/mpris2/mpris2.h 0df64f4 > libs/mpris2/mpris2.cpp a8ad3ef > shells/newshell/main.cpp bab6915 > shells/newshell/mainwindow.cpp d2d71d4 > > Diff: https://git.reviewboard.kde.org/r/116898/diff/ > > > Testing > ------- > > > Thanks, > > Shantanu Tushar > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel