> On July 29, 2014, 4:34 p.m., Bhushan Shah wrote: > > src/qmlcontrols/kcoreaddons/kcoreaddonsplugin.cpp, line 44 > > <https://git.reviewboard.kde.org/r/119535/diff/1/?file=294241#file294241line44> > > > > Maybe consider creating it a singleton type? > > Aleix Pol Gonzalez wrote: > Why? In fact, I think it's usually harder to deal with singletons and > less explicit. > > Bhushan Shah wrote: > I think, It will be lot cleaner to use, > > Image { > id: faceIcon > source: KCoreAddons.KUser.faceIconPath > [...] > } > > instead of, > > KCoreAddons.KUser { > id: kuser > } > > Image { > id: faceIcon > source: kuser.faceIconPath > [...] > } > > More cleaner API and we will save creating objects. (ver few but yes)
I personally prefer explicit as well. I can change it, but I don't see it having any advantage. - Sebastian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119535/#review63453 ----------------------------------------------------------- On July 29, 2014, 2:31 p.m., Sebastian Kügler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119535/ > ----------------------------------------------------------- > > (Updated July 29, 2014, 2:31 p.m.) > > > Review request for KDE Frameworks and Plasma. > > > Repository: kdeclarative > > > Description > ------- > > Move QML bindings for KUser to kdeclarative > > This code has already been released, but privately inside Kickoff. As it is > not strictly related (or limited to) Kickoff, I'd like to move it into > kdeclarative. There are already other bindings for classes from KCoreAddons > there, so this seems like a nice fit. > > The class is useful as public API since it allows customization of apps, > making the user feel more familiar with the program at hand. I want to use > the name and face icon of the user in more places (systemsettings redesign > comes to mind), so it'd be useful to have it shared. > > > Diffs > ----- > > src/qmlcontrols/kcoreaddons/CMakeLists.txt 597cc2c > src/qmlcontrols/kcoreaddons/kcoreaddonsplugin.cpp 3c1a96e > src/qmlcontrols/kcoreaddons/kuserproxy.h PRE-CREATION > src/qmlcontrols/kcoreaddons/kuserproxy.cpp PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/119535/diff/ > > > Testing > ------- > > Ported an (unreleased) app using this class to the new location, works as > expected, no regressions encountered. > > > Thanks, > > Sebastian Kügler > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
