Re: Review Request 118851: Kde-baseapps- KF5 replace generic soversion.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118851/ --- (Updated June 20, 2014, 1:14 p.m.) Status -- This change has been ma

Re: Review Request 118851: Kde-baseapps- KF5 replace generic soversion.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118851/#review60620 --- Ship it! Ship It! - Alex Merry On June 20, 2014, 6:44 p.m.

Re: Review Request 118851: Kde-baseapps- KF5 replace generic soversion.

> On June 20, 2014, 12:02 p.m., Alex Merry wrote: > > CMakeLists.txt, line 23 > > > > > > But now you'll want to put an actual version number in here (or remove > > the variable use altogether). I removed it all

Re: Review Request 118851: Kde-baseapps- KF5 replace generic soversion.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118851/#review60618 --- CMakeLists.txt

Re: Review Request 118851: Kde-baseapps- KF5 replace generic soversion.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118851/ --- (Updated June 20, 2014, 11:44 a.m.) Review request for Dolphin, KDE Base

Re: Review Request 118851: Kde-baseapps- KF5 replace generic soversion.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118851/#review60617 --- CMakeLists.txt

Review Request 118851: Kde-baseapps- KF5 replace generic soversion.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118851/ --- Review request for Dolphin, KDE Base Apps, Plasma, and Jonathan Riddell.

Re: Review Request 118845: Apply some settings to KDE4 if possible

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118845/ --- (Updated June 20, 2014, 3:55 p.m.) Status -- This change has been ma

Re: Review Request 118845: Apply some settings to KDE4 if possible

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118845/#review60613 --- This review has been submitted with commit ccb12703c93972c8ce

Re: Review Request 118845: Apply some settings to KDE4 if possible

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118845/#review60610 --- Ship it! - David Edmundson On June 20, 2014, 3:26 p.m., Mar

Re: Review Request 118845: Apply some settings to KDE4 if possible

> On June 20, 2014, 12:45 p.m., David Edmundson wrote: > > kcms/krdb/krdb.cpp, line 616 > > > > > > Is the goal of this patch is to have it so it syncs the settings the > > user just selected? If so, we don't wa

Re: Review Request 118845: Apply some settings to KDE4 if possible

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118845/ --- (Updated June 20, 2014, 3:26 p.m.) Review request for Plasma. Repositor

Re: Review Request 118849: AppletQuickItem: Do not remember the popup dialog size

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118849/#review60608 --- This review has been submitted with commit d3de99eb1e59c30a7e

Re: Review Request 118849: AppletQuickItem: Do not remember the popup dialog size

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118849/ --- (Updated June 20, 2014, 3:24 p.m.) Status -- This change has been ma

Re: Review Request 118849: AppletQuickItem: Do not remember the popup dialog size

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118849/#review60607 --- Ship it! well, let's remove it for now - Marco Martin On J

Re: Review Request 118849: AppletQuickItem: Do not remember the popup dialog size

> On June 20, 2014, 2:56 p.m., Marco Martin wrote: > > this could maybe fix > > https://bugs.kde.org/show_bug.cgi?id=336070 > > > > but i'm a bit on the fence. > > To me kida seems that to be really "correct", one would allow either > > manually resizing popups xor allowing applets to resize t

Re: Review Request 118849: AppletQuickItem: Do not remember the popup dialog size

> On June 20, 2014, 2:56 p.m., Marco Martin wrote: > > this could maybe fix > > https://bugs.kde.org/show_bug.cgi?id=336070 > > > > but i'm a bit on the fence. > > To me kida seems that to be really "correct", one would allow either > > manually resizing popups xor allowing applets to resize t

Re: Review Request 118845: Apply some settings to KDE4 if possible

> On June 20, 2014, 12:45 p.m., David Edmundson wrote: > > kcms/krdb/krdb.cpp, line 616 > > > > > > Is the goal of this patch is to have it so it syncs the settings the > > user just selected? If so, we don't wa

Re: Review Request 118849: AppletQuickItem: Do not remember the popup dialog size

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118849/#review60604 --- this could maybe fix https://bugs.kde.org/show_bug.cgi?id=336

Review Request 118849: AppletQuickItem: Do not remember the popup dialog size

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118849/ --- Review request for Plasma. Repository: plasma-framework Description ---

Jenkins build is back to normal : plasma-desktop_master_qt5 #344

See ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 118796: [notifications] Introduce a list of apps that are limited to single notification only

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118796/ --- (Updated June 20, 2014, 1:28 p.m.) Status -- This change has been ma

Re: Review Request 118796: [notifications] Introduce a list of apps that are limited to single notification only

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118796/#review60600 --- This review has been submitted with commit 299ba613208897be49

Re: Review Request 118847: Fix disappearing icons when adding panel in "Folder" layout

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118847/ --- (Updated June 20, 2014, 1:22 p.m.) Status -- This change has been ma

Re: Review Request 118847: Fix disappearing icons when adding panel in "Folder" layout

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118847/#review60599 --- This review has been submitted with commit e11e9c7c6c1836c28b

Re: Review Request 118847: Fix disappearing icons when adding panel in "Folder" layout

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118847/#review60598 --- Ship it! Ship It! - Marco Martin On June 20, 2014, 1:05 p.

Review Request 118847: Fix disappearing icons when adding panel in "Folder" layout

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118847/ --- Review request for Plasma and Eike Hein. Bugs: 336376 https://bugs.kd

Jenkins build is back to normal : plasma-workspace_master_qt5 #499

See ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 118845: Apply some settings to KDE4 if possible

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118845/ --- (Updated June 20, 2014, 12:57 p.m.) Review request for Plasma. Reposito

Re: Review Request 118845: Apply some settings to KDE4 if possible

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118845/#review60596 --- kcms/krdb/krdb.cpp

Re: Review Request 118796: [notifications] Introduce a list of apps that are limited to single notification only

> On June 20, 2014, 2:33 p.m., Aleix Pol Gonzalez wrote: > > Wouldn't it make more sense having Clementine in the config file, rather > > than hardcoded? Depends; I'd like to absolutely avoid situations where user by any means looses that config file and those notifications become unusable. At

Re: Review Request 118796: [notifications] Introduce a list of apps that are limited to single notification only

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118796/#review60594 --- Ship it! Wouldn't it make more sense having Clementine in the

Re: Review Request 118796: [notifications] Introduce a list of apps that are limited to single notification only

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118796/ --- (Updated June 20, 2014, 2:21 p.m.) Review request for Plasma. Changes -

Re: Review Request 118840: kde-baseapps frameworks dolphin with snapshot frameworks branch baloo/baloo-widgets path fixes.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118840/ --- (Updated June 20, 2014, 4:36 a.m.) Status -- This change has been ma

Review Request 118845: Apply some settings to KDE4 if possible

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118845/ --- Review request for Plasma. Repository: plasma-desktop Description -

Re: Review Request 118731: AbstractRunner: Add an iconForCategory virtual function

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118731/ --- (Updated June 20, 2014, 11:19 a.m.) Status -- This change has been m

Build failed in Jenkins: plasma-workspace_master_qt5 #498

See Changes: [me] KRunner: Fix compile -- [...truncated 1217 lines...] Generating remotedirnotifymodule.moc Generating moc_remotedirnotify.cpp Generating moc_remotedirnotifymodule.cpp [ 18%

Build failed in Jenkins: plasma-workspace_master_qt5 #497

See Changes: [me] KRunner: Remove initializeStartupNotification [me] PowerManagementJob: The krunner switchUser function is back -- [...truncated 1201 lines...] Generating moc_devicesignal

Build failed in Jenkins: plasma-workspace_master_qt5 #496

See Changes: [kde] Don't ignore null images -- [...truncated 1221 lines...] Generating moc_statusnotifieritemjob.cpp Generating moc_statusnotifieritemservice.cpp Generating moc_statusnotifi

Re: Review Request 118842: Add reset function to QImageItem image property

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118842/#review60584 --- This review has been submitted with commit 542d1b8534d56b7278

Re: Review Request 118842: Add reset function to QImageItem image property

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118842/ --- (Updated June 20, 2014, 10:41 a.m.) Status -- This change has been m

Build failed in Jenkins: plasma-desktop_master_qt5 #343

See Changes: [mgraesslin] [kcms/launch] Fix reconfigure of startupfeedback effect -- [...truncated 779 lines...] Scanning dependencies of target kcm_fontinst_automoc [ 21%] [ 21%] [ 21%] [ 21

Build failed in Jenkins: plasma-workspace_master_qt5 #495

See Changes: [jr] REVIEW:118724 -- [...truncated 1212 lines...] Automatic moc for target kde Scanning dependencies of target drkonqi_automoc [ 18%] Automatic moc for target drkonqi Generati

Re: Review Request 118724: rename .directory files to kf5 prefix to prevent clashes with kde-runtime files

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118724/ --- (Updated June 20, 2014, 9:49 a.m.) Status -- This change has been ma

Re: Review Request 118724: rename .directory files to kf5 prefix to prevent clashes with kde-runtime files

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118724/#review60582 --- This review has been submitted with commit 53eccfad474f399ff5

Re: Review Request 118257: explicit dependency on kpty as needed by kdesu

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118257/ --- (Updated June 20, 2014, 9:42 a.m.) Status -- This change has been di

Build failed in Jenkins: plasma-workspace_master_qt5 #494

See Changes: [scripty] SVN_SILENT made messages (.desktop file) [jr] Add xsession file for Plasma -- [...truncated 1221 lines...] Generating moc_remotedirnotify.cpp Generating moc_remotedi

Re: Review Request 117856: do not install cursors, they clash with kde-runtime from KDE 4 and breeze now installs new cursor theme

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117856/ --- (Updated June 20, 2014, 9:32 a.m.) Status -- This change has been di

Re: Review Request 118732: Add xsession file for Plasma

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118732/ --- (Updated June 20, 2014, 9:32 a.m.) Status -- This change has been ma

Re: Review Request 118732: Add xsession file for Plasma

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118732/#review60581 --- This review has been submitted with commit cd4dbbca57e1483954

Build failed in Jenkins: plasma-desktop_master_qt5 #342

See Changes: [scripty] SVN_SILENT made messages (.desktop file) -- [...truncated 766 lines...] Generating moc_applicationmodel.cpp Generating moc_favoritesmodel.cpp Generating moc_itemhandler

Build failed in Jenkins: plasma-workspace_master_qt5 #493

See -- [...truncated 1226 lines...] Generating moc_statusnotifieritemsource.cpp [ 18%] Built target plasma_engine_statusnotifieritem_automoc Generating backtraceparser.moc

Re: Re: Re: which product to use for bugreport?

ah ok, I got it :) ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Re: Re: which product to use for bugreport?

On Friday 20 June 2014 11:27:07 Damian Ivanov wrote: > >no, if KWindowSystem implies SkipTaskbar if the window type is e.g. Splash > >the taskbar does not need any adjustments. > > Sorry, maybe I'm misunderstanding :) > Does that mean that KWindowSystem adds SkipTaskbar to these windows? no, I'm

Re: Review Request 118842: Add reset function to QImageItem image property

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118842/#review60578 --- Ship it! Ship It! - Marco Martin On June 20, 2014, 12:26 a

Re: Re: which product to use for bugreport?

>no, if KWindowSystem implies SkipTaskbar if the window type is e.g. Splash the >taskbar does not need any adjustments. Sorry, maybe I'm misunderstanding :) Does that mean that KWindowSystem adds SkipTaskbar to these windows? If you have non KDE applications that don't have skipTaskbar set, but do

Re: Re: which product to use for bugreport?

On Friday 20 June 2014 11:17:41 Damian Ivanov wrote: > >Given the high regression potential (windows which used to be included > >aren't shown any more - yes the one user's bug is the other user's > >feature) I would highly recommend to not change the behavior in 4.11. > > Sure. I notice because f

Re: which product to use for bugreport?

>Given the high regression potential (windows which used to be included aren't >shown any more - yes the one user's bug is the other user's feature) I would >highly recommend to not change the behavior in 4.11. Sure. I notice because for example xfce desktop and panel do not set SkipTaskbar, they r

Re: which product to use for bugreport?

On Friday 20 June 2014 10:49:48 Damian Ivanov wrote: > KDE 4.11.5 as well as newer KDE's show the same behavior (couldn't > test Plasma 2 but I'm quite confident it applies also there). > > The plasma plugins like taskbar do not respect NETWM_Type Property: > The plugins properly omit windows that

which product to use for bugreport?

KDE 4.11.5 as well as newer KDE's show the same behavior (couldn't test Plasma 2 but I'm quite confident it applies also there). The plasma plugins like taskbar do not respect NETWM_Type Property: The plugins properly omit windows that have NETWM::SkipTaskbar set, but as per netwm spec: http://sta

Re: Review Request 118734: Added MPRIS specifications Tracklist Interface

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118734/ --- (Updated June 20, 2014, 7:10 a.m.) Status -- This change has been ma

Re: Review Request 118734: Added MPRIS specifications Tracklist Interface

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118734/#review60575 --- This review has been submitted with commit 1edd44ee0b9a476b10