> On June 20, 2014, 2:33 p.m., Aleix Pol Gonzalez wrote: > > Wouldn't it make more sense having Clementine in the config file, rather > > than hardcoded?
Depends; I'd like to absolutely avoid situations where user by any means looses that config file and those notifications become unusable. At this point, we know for sure we need at least those two apps in there, the config file should then serve only as an additional way of adding another apps (and I wouldn't mind extending the hardcoded list for other apps, presumably media players). - Martin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118796/#review60594 ----------------------------------------------------------- On June 20, 2014, 2:21 p.m., Martin Klapetek wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118796/ > ----------------------------------------------------------- > > (Updated June 20, 2014, 2:21 p.m.) > > > Review request for Plasma. > > > Repository: plasma-workspace > > > Description > ------- > > This prevents some apps to spam lots of notifications when all it needs is > actually just one single notification. > > Imagine you're switching songs in your playlist quickly and each song change > sends new notification, but when > you get to the tenth song, you still see the notification from the 3rd song > (because timeouts) and you don't > really care about all those songs changes still in the queue as you see it in > the playlist anyway. > > So this patch limits certain apps to have only one single notification which > is always updated. So far > Clementine and Spotify is there. Switching songs or changing playback status > creates only one single popup. > > > Diffs > ----- > > applets/notifications/package/contents/ui/NotificationPopup.qml d07ee32 > applets/notifications/plugin/notificationshelper.cpp c5a1082 > dataengines/notifications/notificationsengine.h df0d3ca > dataengines/notifications/notificationsengine.cpp aaf6079 > > Diff: https://git.reviewboard.kde.org/r/118796/diff/ > > > Testing > ------- > > > Thanks, > > Martin Klapetek > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
