----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118842/#review60584 -----------------------------------------------------------
This review has been submitted with commit 542d1b8534d56b7278ec239236feecd942ec4dfe by David Edmundson to branch master. - Commit Hook On June 20, 2014, 12:26 a.m., David Edmundson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118842/ > ----------------------------------------------------------- > > (Updated June 20, 2014, 12:26 a.m.) > > > Review request for KDE Frameworks and Plasma. > > > Repository: kdeclarative > > > Description > ------- > > Add reset function to QImageItem > > This allows > > QImageItem { > image: undefined > } > > without warnings. > > This is useful as otherwise it's impossible to unset a set QImageItem as > QImage is uncreatable from within QML. > > The immediate usage is to fix a bug in notifications where sometimes an image > from a previous notification "leaks" into our current notification. > > > Diffs > ----- > > src/qmlcontrols/kquickcontrolsaddons/qimageitem.h eef59bc > src/qmlcontrols/kquickcontrolsaddons/qimageitem.cpp ed20605 > src/qmlcontrols/kquickcontrolsaddons/qpixmapitem.h eee8189 > src/qmlcontrols/kquickcontrolsaddons/qpixmapitem.cpp fcc66b5 > > Diff: https://git.reviewboard.kde.org/r/118842/diff/ > > > Testing > ------- > > Wrote small qml file, code had warning before, now it doesn't. > Images are still displayed if set. > > > Thanks, > > David Edmundson > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
