Re: Review Request 118538: Add a property containing the real edge a dialog is shown on

> On June 17, 2014, 4:11 p.m., Kevin Ottens wrote: > > Marco, any chance for a second run of review on that patch? > > Marco Martin wrote: > i still not like this patch.. > > Kevin Ottens wrote: > Should be dropped then? Or it can get somewhere? > Feel free to drop it if you conside

Re: Review Request 118804: Register ksmserver as logind session leader

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118804/ --- (Updated June 17, 2014, 11:53 p.m.) Review request for Plasma. Changes

Re: Review Request 118733: Change installation path of sddm theme

> On June 13, 2014, 4:11 p.m., Aleix Pol Gonzalez wrote: > > CMakeLists.txt, line 118 > > > > > > Actually, shouldn't we have a find_package sddm and install it wherever > > it's installed? > > Bernd Steinhause

Re: Review Request 118799: Move BatteryIcon to org.kde.plasma.extras

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118799/ --- (Updated June 17, 2014, 10:47 p.m.) Status -- This change has been d

Re: Review Request 118733: Change installation path of sddm theme

> On June 13, 2014, 4:11 p.m., Aleix Pol Gonzalez wrote: > > CMakeLists.txt, line 118 > > > > > > Actually, shouldn't we have a find_package sddm and install it wherever > > it's installed? > > Bernd Steinhause

Review Request 118804: Register ksmserver as logind session leader

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118804/ --- Review request for Plasma. Bugs: 335390 https://bugs.kde.org/show_bug

Build failed in Jenkins: plasma-workspace_master_qt5 #461

See Changes: [notmart] delay sync of the screen a bit -- [...truncated 1244 lines...] Generating backtraceparser.moc

Re: Review Request 118799: Move BatteryIcon to org.kde.plasma.extras

> On June 17, 2014, 4:21 p.m., Marco Martin wrote: > > I'm not a fan of throwing random pieces in public api just because they are > > useful in 2 places, > > especially since the other place where that may be useful is the lock > > screen, and that had the possibility of adding directly plasmo

Re: Review Request 118668: Split the startDate property into today and displayedDate in calendar component

> On June 17, 2014, 6:16 p.m., Mark Gaiser wrote: > > No comments on most of the code change since that looks OK to me :) Besides > > setToday. > > Just a friendly explanation why i did it this way and why i (back then) > > thought it would be sufficient. > > > > I knew there was going to be a

Re: Review Request 118668: Split the startDate property into today and displayedDate in calendar component

> On June 17, 2014, 8:16 p.m., Mark Gaiser wrote: > > No comments on most of the code change since that looks OK to me :) Besides > > setToday. > > Just a friendly explanation why i did it this way and why i (back then) > > thought it would be sufficient. > > > > I knew there was going to be a

Re: Review Request 118668: Split the startDate property into today and displayedDate in calendar component

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118668/#review60307 --- No comments on most of the code change since that looks OK to

Re: Review Request 118724: rename .directory files to kf5 prefix to prevent clashes with kde-runtime files

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118724/#review60305 --- Ship it! Ship It! - David Faure On June 17, 2014, 4:16 p.m

Build failed in Jenkins: plasma-desktop_master_qt5 #325

See Changes: [hein] Derive default size from grid cell size. [hein] Set Layout.* sizes to fix tooltip rendering. -- [...truncated 806 lines...] Generating Viewer.moc

Build failed in Jenkins: plasma-workspace_master_qt5 #460

See Changes: [rohan] Port the webshortcuts runner to Plasma 5 -- [...truncated 1226 lines...] Scanning dependencies of target drkonqi_backtrace_parser_automoc Built target plasma_engine_sta

Build failed in Jenkins: plasma-desktop_master_qt5 #324

See Changes: [aleixpol] Remove pointless commetns -- [...truncated 765 lines...] Generating moc_systemmodel.cpp Generating moc_urlitemlauncher.cpp [ 14%] [ 14%] Built target kfontinst_automoc

Re: Review Request 118791: (Need opinions) KRunner: Avoid having a scroll area

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118791/ --- (Updated June 17, 2014, 4:46 p.m.) Review request for Plasma. Changes -

Re: Review Request 118797: Port webshortcuts runner

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118797/ --- (Updated June 17, 2014, 4:44 p.m.) Status -- This change has been ma

Re: Review Request 118797: Port webshortcuts runner

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118797/#review60299 --- This review has been submitted with commit abc0214dd1561256cb

Re: Review Request 118538: Add a property containing the real edge a dialog is shown on

> On June 17, 2014, 4:11 p.m., Kevin Ottens wrote: > > Marco, any chance for a second run of review on that patch? > > Marco Martin wrote: > i still not like this patch.. > > Kevin Ottens wrote: > Should be dropped then? Or it can get somewhere? > Feel free to drop it if you conside

Re: Review Request 118797: Port webshortcuts runner

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118797/#review60295 --- Ship it! Looks good. Just remove the unnecessary libraries.

Re: Review Request 118538: Add a property containing the real edge a dialog is shown on

> On June 17, 2014, 4:11 p.m., Kevin Ottens wrote: > > Marco, any chance for a second run of review on that patch? > > Marco Martin wrote: > i still not like this patch.. Should be dropped then? Or it can get somewhere? Feel free to drop it if you consider it a dead end. I prefer that to op

Re: Review Request 118799: Move BatteryIcon to org.kde.plasma.extras

> On June 17, 2014, 4:21 p.m., Marco Martin wrote: > > I'm not a fan of throwing random pieces in public api just because they are > > useful in 2 places, > > especially since the other place where that may be useful is the lock > > screen, and that had the possibility of adding directly plasmo

Re: Review Request 118716: New Translations KCM

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118716/ --- (Updated June 17, 2014, 4:26 p.m.) Review request for Plasma, Chusslove I

Re: Review Request 118799: Move BatteryIcon to org.kde.plasma.extras

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118799/#review60284 --- I'm not a fan of throwing random pieces in public api just bec

Re: Review Request 118538: Add a property containing the real edge a dialog is shown on

> On June 17, 2014, 4:11 p.m., Kevin Ottens wrote: > > Marco, any chance for a second run of review on that patch? i still not like this patch.. - Marco --- This is an automatically generated e-mail. To reply, visit: https://git.reviewb

Re: Review Request 118724: rename .directory files to kf5 prefix to prevent clashes with kde-runtime files

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118724/ --- (Updated June 17, 2014, 4:16 p.m.) Review request for Plasma and David Fa

Re: Review Request 118724: rename .directory files to kf5 prefix to prevent clashes with kde-runtime files

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118724/#review60280 --- Looks fine to me, I'd like David's opinion though. - Kevin Ot

Re: Review Request 118538: Add a property containing the real edge a dialog is shown on

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118538/#review60277 --- Marco, any chance for a second run of review on that patch? -

Re: Review Request 118155: adapt to ecm_add_tests so that tests can be found

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118155/#review60275 --- Patrick, this patch got two ship it, any reason why it's not c

Review Request 118799: Move BatteryIcon to org.kde.plasma.extras

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118799/ --- Review request for Plasma and Solid. Repository: plasma-framework Descr

Build failed in Jenkins: plasma-workspace_master_qt5 #459

See Changes: [mklapetek] Switch the timedate applets to "DateTime" property only -- [...truncated 1194 lines...] [ 14%] Generating phononbackend.json Generating taskwindowservice.moc

Build failed in Jenkins: plasma-desktop_master_qt5 #323

See Changes: [notmart] check for item existence -- [...truncated 766 lines...] Generating ktimerdialog.moc

Re: Review Request 118798: Add icon size "tiny"

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118798/ --- (Updated June 17, 2014, 3:13 p.m.) Status -- This change has been ma

Re: Review Request 118798: Add icon size "tiny"

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118798/#review60269 --- This review has been submitted with commit b44e0205bc72048179

Re: Review Request 118796: [notifications] Introduce a list of apps that are limited to single notification only

> On June 17, 2014, 4:55 p.m., Martin Gräßlin wrote: > > dataengines/notifications/notificationsengine.cpp, lines 38-48 > > > > > > suggestion - C++11-ify: > > , m_alwaysReplaceAppsList({QStringLiteral("Clemen

Review Request 118798: Add icon size "tiny"

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118798/ --- Review request for Plasma. Repository: plasma-framework Description ---

Build failed in Jenkins: plasma-workspace_master_qt5 #458

See Changes: [kde] Use icon size tiny in window pin [kde] Use iconSize tiny in Calendar view -- [...truncated 1222 lines...] Generating progresslistmodel.moc

Re: Review Request 118796: [notifications] Introduce a list of apps that are limited to single notification only

> On June 17, 2014, 2:55 p.m., Martin Gräßlin wrote: > > dataengines/notifications/notificationsengine.cpp, lines 38-48 > > > > > > suggestion - C++11-ify: > > , m_alwaysReplaceAppsList({QStringLiteral("Clemen

Re: Review Request 118798: Add icon size "tiny"

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118798/#review60268 --- Ship it! Ship It! - Marco Martin On June 17, 2014, 3:09 p.

Re: Build failed in Jenkins: plasma-workspace_master_qt5 #457

#include not found. It seems it's missing kservice across all of these failures. I just wiped all my install directory and updated frameworks, everything still builds fine here. I suspect Jenkins is at fault here. David ___ Plasma-devel mailing list

Re: Review Request 118797: Port webshortcuts runner

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118797/#review60263 --- runners/webshortcuts/CMakeLists.txt

Review Request 118797: Port webshortcuts runner

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118797/ --- Review request for Plasma. Repository: plasma-workspace Description ---

Re: Review Request 118796: [notifications] Introduce a list of apps that are limited to single notification only

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118796/#review60260 --- dataengines/notifications/notificationsengine.h

Re: Build failed in Jenkins: plasma-workspace_master_qt5 #457

On Tue, Jun 17, 2014 at 4:56 PM, David Edmundson wrote: > #include not found. > > It seems it's missing kservice across all of these failures. > > I just wiped all my install directory and updated frameworks, > everything still builds fine here. > I suspect Jenkins is at fault here. > > David >

Re: Review Request 118796: [notifications] Introduce a list of apps that are limited to single notification only

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118796/#review60261 --- dataengines/notifications/notificationsengine.cpp

Build failed in Jenkins: plasma-workspace_master_qt5 #457

See -- [...truncated 1181 lines...] Generating moc_devicesignalmapmanager.cpp Generating moc_devicesignalmapper.cpp Generating moc_hddtemp.cpp Generating moc_soliddeviceengine.cpp Generating moc_sol

Review Request 118796: [notifications] Introduce a list of apps that are limited to single notification only

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118796/ --- Review request for Plasma. Repository: plasma-workspace Description ---

Build failed in Jenkins: plasma-workspace_master_qt5 #456

See Changes: [aleixpol] Actually look for the screen instead of doing things without any semantic sense [lukas] i18n fixes -- [...truncated 1214 lines...] Automatic moc for target drkonqi

Build failed in Jenkins: plasma-workspace_master_qt5 #455

See Changes: [mklapetek] [notifications]Fix codestyle -- [...truncated 1225 lines...] [ 14%] [ 14%] Automatic moc for target backtraceparsertest Automatic moc for target crashtest Generatin

Build failed in Jenkins: plasma-workspace_master_qt5 #454

See Changes: [kde] Use standard icon sizes [notmart] e smallSpacing instead of largeSpacing/4 [notmart] better layout -- [...truncated 1247 lines...] [ 14%] Generating fakebacktracegenera

Build failed in Jenkins: plasma-workspace_master_qt5 #453

See Changes: [lukas] set the correct translation domain -- [...truncated 1194 lines...] Generating progresslistdelegate.moc

Build failed in Jenkins: plasma-workspace_master_qt5 #452

See Changes: [aleixpol] Recursively figure out the screen a containment is in [aleixpol] Use the screen geometry to figure out the containment's screen -- [...truncated 1200 lines...] Gene

Build failed in Jenkins: plasma-workspace_master_qt5 #451

See Changes: [lukas] i18n fixes -- [...truncated 1191 lines...] Generating moc_remotedirnotifymodule.cpp Generating moc_shareengine.cpp Generating moc_shareprovider.cpp Generating moc_share

[plasmashell] [Bug 328593] Dual screen has regressed in plasma-shell

https://bugs.kde.org/show_bug.cgi?id=328593 Bug 328593 depends on bug 334500, which changed state. Bug 334500 Summary: plasmoid.screen returns -1 in multiscreen setup https://bugs.kde.org/show_bug.cgi?id=334500 What|Removed |Added --

Build failed in Jenkins: plasma-workspace_master_qt5 #450

See Changes: [notmart] round every size potentially not integer -- [...truncated 1232 lines...] [ 14%] Generating backtracegenerator.moc

Build failed in Jenkins: plasma-desktop_master_qt5 #322

See Changes: [notmart] ve priority to saved size -- [...truncated 781 lines...] Scanning dependencies of target kfontinst_bin_automoc Scanning dependencies of target kfontview_bin_automoc [ 1

Build failed in Jenkins: plasma-workspace_master_qt5 #449

See Changes: [kde] Use forceActiveFocus rather than focus=true to select password box [kde] Show error on failed login [kde] Update test sddm to pretend to fail every login -- [...truncat

Build failed in Jenkins: plasma-workspace_master_qt5 #448

See Changes: [notmart] fire adaptToScreen only once -- [...truncated 1251 lines...] [ 14%] Generating backtraceparserkdbgwin.moc

Re: Review Request 118793: Remove old display KCM

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118793/ --- (Updated June 17, 2014, 1:11 p.m.) Status -- This change has been ma

Re: Review Request 118792: PowerDevil: Show the brightness OSD on pressing the brightness key

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118792/ --- (Updated June 17, 2014, 1:16 p.m.) Status -- This change has been ma

Re: Review Request 118792: PowerDevil: Show the brightness OSD on pressing the brightness key

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118792/#review60246 --- This review has been submitted with commit 8b607a73e23c5ccd9c

Build failed in Jenkins: plasma-workspace_master_qt5 #447

See Changes: [kde] Update dummydata SDDM file to have all properties -- [...truncated 1213 lines...]

Re: Review Request 118792: PowerDevil: Show the brightness OSD on pressing the brightness key

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118792/#review60243 --- Ship it! Good to go, please be extra careful making sure the

Build failed in Jenkins: plasma-desktop_master_qt5 #321

See Changes: [mail] Remove old display KCM in favor of kscreen's KCM. -- [...truncated 782 lines...] Scanning dependencies of target kfontprint_bin_automoc Scanning dependencies of target kfo

Re: Review Request 118793: Remove old display KCM

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118793/#review60244 --- This review has been submitted with commit 7edf073609bf420c25

Re: Review Request 118791: (Need opinions) KRunner: Avoid having a scroll area

> On June 17, 2014, 11:31 a.m., Marco Martin wrote: > > as gut feeling, i think results pages that show too many things at once > > could be overwhelming, but it can be tried and see how it works, just one > > thing tough.. > > I don't think you can be completely sure that the results will fit

Re: Review Request 118793: Remove old display KCM

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118793/#review60240 --- Ship it! Ship It! - Sebastian Kügler On June 17, 2014, 12:

Review Request 118793: Remove old display KCM

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118793/ --- Review request for Plasma. Repository: plasma-desktop Description -

Build failed in Jenkins: plasma-workspace_master_qt5 #446

See Changes: [aleixpol] Wasn't meant to commit this -- [...truncated 1202 lines...] Generating moc_ktimezonedbase.cpp Generating moc_ktimezoned.cpp [ 14%] Built target kded_ktimezoned_autom

Re: Review Request 118792: PowerDevil: Show the brightness OSD on pressing the brightness key

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118792/#review60235 --- Ship it! Ship It! - Sebastian Kügler On June 17, 2014, 11:

Build failed in Jenkins: plasma-workspace_master_qt5 #445

See Changes: [aleixpol] Remove deprecated TODO statement [aleixpol] Display error messages on the display screen -- [...truncated 1214 lines...] Automatic moc for target kded_solidautoejec

Re: Review Request 118791: (Need opinions) KRunner: Avoid having a scroll area

> On June 17, 2014, 11:31 a.m., Marco Martin wrote: > > as gut feeling, i think results pages that show too many things at once > > could be overwhelming, but it can be tried and see how it works, just one > > thing tough.. > > I don't think you can be completely sure that the results will fit

Re: Review Request 118791: (Need opinions) KRunner: Avoid having a scroll area

> On June 17, 2014, 11:31 a.m., Marco Martin wrote: > > as gut feeling, i think results pages that show too many things at once > > could be overwhelming, but it can be tried and see how it works, just one > > thing tough.. > > I don't think you can be completely sure that the results will fit

Build failed in Jenkins: plasma-workspace_master_qt5 #444

See Changes: [kde] i18n -> i18nd [kde] Add missing i18n -- [...truncated 1215 lines...] Generating wallpaperpackage.moc

Build failed in Jenkins: plasma-desktop_master_qt5 #320

See Changes: [lukas] rename the catalogs so that they match the QML part -- [...truncated 788 lines...] [ 19%] Automatic moc for target fontinst_bin Automatic moc for target kcm_fontinst [ 19

Re: Review Request 118791: (Need opinions) KRunner: Avoid having a scroll area

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118791/#review60230 --- as gut feeling, i think results pages that show too many thing

Build failed in Jenkins: plasma-workspace_master_qt5 #443

See Changes: [aleixpol] Make it possible to get back to the main lock screen when pressing escape -- [...truncated 1247 lines...]

Review Request 118792: PowerDevil: Show the brightness OSD on pressing the brightness key

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118792/ --- Review request for Plasma, Solid and Àlex Fiestas. Repository: powerdevil

Build failed in Jenkins: plasma-desktop_master_qt5 #317

See Changes: [lukas] rename to plasma_applet_foo -- [...truncated 762 lines...] Generating componentchooserwm.moc

Review Request 118791: (Need opinions) KRunner: Avoid having a scroll area

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118791/ --- Review request for Plasma. Repository: plasma-workspace Description ---

Build failed in Jenkins: plasma-workspace_master_qt5 #442

See Changes: [aleixpol] Polished the output sorting function -- [...truncated 1201 lines...] :0:

Build failed in Jenkins: plasma-desktop_master_qt5 #319

See Changes: [notmart] i18nd -- [...truncated 770 lines...] Generating moc_leavemodel.cpp Generating moc_processrunner.cpp Generating moc_recentapplications.cpp Generating moc_recentlyusedmod

Build failed in Jenkins: plasma-desktop_master_qt5 #318

See Changes: [notmart] proper i18nc -- [...truncated 762 lines...] Generating moc_main.cpp Generating moc_icons.cpp Generating moc_iconthemes.cpp [ 18%] [ 18%] Generating moc_caldialog.cpp Ge

Build failed in Jenkins: plasma-workspace_master_qt5 #441

See Changes: [scripty] SVN_SILENT made messages (.desktop file) -- [...truncated 1202 lines...] :

Re: Ship with Aurorae and Qtcurve or not...

On Thu, May 29, 2014 at 3:09 PM, Marco Martin wrote: > On Thursday 15 May 2014 11:39:00 Jens Reuterberg wrote: > > Ok so after the feedback from the Beta Release an issue that we knew was > > coming have happened. Visuals being the most easily accessible bit of > > anything technical, people have

Re: Review Request 118668: Split the startDate property into today and displayedDate in calendar component

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118668/ --- (Updated June 17, 2014, 8:44 a.m.) Status -- This change has been ma

Re: Review Request 118668: Split the startDate property into today and displayedDate in calendar component

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118668/#review60224 --- This review has been submitted with commit 3188b417f4b898d416