----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118797/#review60295 -----------------------------------------------------------
Ship it! Looks good. Just remove the unnecessary libraries. runners/webshortcuts/CMakeLists.txt <https://git.reviewboard.kde.org/r/118797/#comment42034> Is DBus being used? runners/webshortcuts/CMakeLists.txt <https://git.reviewboard.kde.org/r/118797/#comment42035> Ditto - Vishesh Handa On June 17, 2014, 2:53 p.m., Rohan Garg wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118797/ > ----------------------------------------------------------- > > (Updated June 17, 2014, 2:53 p.m.) > > > Review request for Plasma. > > > Repository: plasma-workspace > > > Description > ------- > > See title > > > Diffs > ----- > > runners/CMakeLists.txt ded1fcb > runners/webshortcuts/CMakeLists.txt b97a7c5 > runners/webshortcuts/webshortcutrunner.h 73339c4 > runners/webshortcuts/webshortcutrunner.cpp cae2dec > > Diff: https://git.reviewboard.kde.org/r/118797/diff/ > > > Testing > ------- > > Seems to work with the kde: , qt: and youtube: keywords > > > Thanks, > > Rohan Garg > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
