> On June 17, 2014, 4:11 p.m., Kevin Ottens wrote: > > Marco, any chance for a second run of review on that patch? > > Marco Martin wrote: > i still not like this patch.. > > Kevin Ottens wrote: > Should be dropped then? Or it can get somewhere? > Feel free to drop it if you consider it a dead end. I prefer that to open > patches lingering on forever.
I don't seem to be able to do so. are permissions for doing so to be asked somewhere? - Marco ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118538/#review60277 ----------------------------------------------------------- On June 4, 2014, 10:43 p.m., David Edmundson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118538/ > ----------------------------------------------------------- > > (Updated June 4, 2014, 10:43 p.m.) > > > Review request for KDE Frameworks and Plasma. > > > Repository: plasma-framework > > > Description > ------- > > Add a property containing the real edge a dialog is shown on. > > If a dialog is meant to be shown on the left of an item, if there is not > enough space it will be shown on the right. > > We need to keep track of where we're actually shown in order to show the > correct borders and perform the animation in the correct direction. > > It is exposed as a property in case the dialog itself needs to know > which side of the parent item it is, for example if needs to show an > arrow to the parent. > > -- > > Fixed some serious copy + paste fails in the hitting the bottom edge of > the screen check. > > > Diffs > ----- > > src/plasmaquick/dialog.cpp 2f8227c > src/plasmaquick/dialog.h 4009222 > > Diff: https://git.reviewboard.kde.org/r/118538/diff/ > > > Testing > ------- > > Ran dialog_positioning.qml in all 8 combinations of edges + preferred > locations. > (i.e placed near left edge, showed item with location set to both left and > right) > > > Thanks, > > David Edmundson > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
