Re: Review Request 118387: Bump systemsettingsview SOVERSION to 5

2014-06-15 Thread Ben Cooksley
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118387/#review60161 --- As systemsettingsview is unlikely to break BC any further in t

Re: Review Request 118387: Bump systemsettingsview SOVERSION to 5

2014-06-15 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118387/#review60158 --- What's the status here? - Sebastian Kügler On May 28, 2014,

Re: Review Request 118693: [ksmserver/screenlocker] Use ScreenSaver key as shortcut

2014-06-15 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118693/#review60157 --- Ship it! Ship It! - Sebastian Kügler On June 12, 2014, 11:

Re: Review Request 118696: Remove unused dependencies.

2014-06-15 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118696/#review60156 --- Ship it! Nice! - Sebastian Kügler On June 12, 2014, 2:45 p

Re: Review Request 118668: Split the startDate property into today and displayedDate in calendar component

2014-06-15 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118668/#review60155 --- Ship it! Nice improvement. src/declarativeimports/calendar/

Re: Review Request 118732: Add xsession file for Plasma

2014-06-15 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118732/#review60154 --- Ship it! Ship It! - Sebastian Kügler On June 13, 2014, 2:2

Re: Review Request 118753: Handle mouse wheel in PlasmaComponents.Slider

2014-06-15 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118753/#review60153 --- Ship it! Ship It! - Sebastian Kügler On June 15, 2014, 12:

Re: Review Request 118716: New Translations KCM

2014-06-15 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118716/ --- (Updated June 16, 2014, 12:58 a.m.) Review request for KDE Frameworks, Pl

Re: Review Request 118716: New Translations KCM

2014-06-15 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118716/ --- (Updated June 16, 2014, 12:57 a.m.) Review request for KDE Frameworks, Pl

Re: Review Request 118716: New Translations KCM

2014-06-15 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118716/ --- (Updated June 16, 2014, 12:45 a.m.) Review request for KDE Frameworks, Pl

Re: Review Request 118678: [ki18n] Allow querying for translations of a specific domain

2014-06-15 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118678/ --- (Updated June 16, 2014, 12:01 a.m.) Review request for Plasma, Chusslove

Re: Review Request 118769: Use RotationAnimator in BusyIndicator

2014-06-15 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118769/#review60136 --- This review has been submitted with commit 60ddc9f25d75686b56

Re: Review Request 118769: Use RotationAnimator in BusyIndicator

2014-06-15 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118769/ --- (Updated June 15, 2014, 8:30 p.m.) Status -- This change has been ma

Re: Review Request 118769: Use RotationAnimator in BusyIndicator

2014-06-15 Thread Kai Uwe Broulik
> On June 15, 2014, 8:08 p.m., David Edmundson wrote: > > src/declarativeimports/plasmacomponents/qml/BusyIndicator.qml, line 57 > > > > > > I'm not 100% sure this will still work as now the rotation property > >

Re: Review Request 118769: Use RotationAnimator in BusyIndicator

2014-06-15 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118769/#review60134 --- Ship it! +100. I have something I'd like you to check first t

Review Request 118769: Use RotationAnimator in BusyIndicator

2014-06-15 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118769/ --- Review request for Plasma, David Edmundson, Elias Probst, and Jan Grulich.

Re: Ideas around Highlight

2014-06-15 Thread Marco Martin
On Sunday 15 June 2014, Shantanu Tushar Jha wrote: > > [1] > commits.kde.org/plasma-mediacenter/1e77bc1e19fb9f59ebb82aad9e95ff7ad966f130 > [2] http://i.imgur.com/DO5cCA3.jpg > [3] http://i.imgur.com/CNxPWiz.jpg the problem of the second may be inconsistency with the rest, as color, rounding rad

Re: Review Request 118767: Fix for "Bug 328532 - Remember the playlist I was using when I closed PMC last time"

2014-06-15 Thread R.Harish Navnit
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118767/#review60131 --- Right now, when you play a song from a playlist and wish to vi

Review Request 118767: Fix for "Bug 328532 - Remember the playlist I was using when I closed PMC last time"

2014-06-15 Thread Ashish Madeti
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118767/ --- Review request for Plasma, Bhushan Shah, Nikolaos Chatzidakis, Shantanu Tus

Re: Review Request 118759: Add a separator to the path where PMC stores playlist file

2014-06-15 Thread Ashish Madeti
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118759/ --- (Updated June 15, 2014, 4:21 p.m.) Status -- This change has been ma

Re: Review Request 118759: Add a separator to the path where PMC stores playlist file

2014-06-15 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118759/#review60129 --- This review has been submitted with commit de7de9be9bf3984b96

Re: Ideas around Highlight

2014-06-15 Thread Thomas Pfeiffer
On Sunday 15 June 2014 19:23:35 Bhushan Shah wrote: > On Sun, Jun 15, 2014 at 6:50 PM, Bhushan Shah wrote: > > This is KDE4 version and yes I have tried my port to Plasma Next with > > breeze theme but due to dark background it does not look very well on > > breeze theme.. Though breeze dark theme

Re: Ideas around Highlight

2014-06-15 Thread Bhushan Shah
On Sun, Jun 15, 2014 at 6:50 PM, Bhushan Shah wrote: > This is KDE4 version and yes I have tried my port to Plasma Next with > breeze theme but due to dark background it does not look very well on > breeze theme.. Though breeze dark theme looks good.. :) Here is how it looks with breeze theme, (D

Re: Ideas around Highlight

2014-06-15 Thread R.Harish Navnit
Hello all, Stating my opinion here. The second one much more sharp and does look different, but I'm sure the previous one would have it's supporters too :) Perspective really IMHO. On Sun, Jun 15, 2014 at 6:45 PM, Thomas Pfeiffer wrote: > > Btw: Have you tried PMC with the Breeze theme yet? It

Re: Ideas around Highlight

2014-06-15 Thread Bhushan Shah
On Sun, Jun 15, 2014 at 6:45 PM, Thomas Pfeiffer wrote: > I'd say they're both okay from a usability perspective (the new one offers the > better contrast, though). > For design feedback, I've CC'd Andrew Lake (author of the Breeze Plasma > theme). > Btw: Have you tried PMC with the Breeze theme y

Re: Ideas around Highlight

2014-06-15 Thread Thomas Pfeiffer
On Sunday 15 June 2014 18:12:43 Sinny Kumari wrote: > On Sun, Jun 15, 2014 at 4:48 PM, Akshay Ratan wrote: > > Hello, > > > > In my opinion, second highlight looks more crisp and sharp and hence > > preferable. :) > > > > + 1 > > But I am not usability expert I'd say they're both okay from a u

Re: Ideas around Highlight

2014-06-15 Thread Sinny Kumari
On Sun, Jun 15, 2014 at 4:48 PM, Akshay Ratan wrote: > Hello, > > In my opinion, second highlight looks more crisp and sharp and hence > preferable. :) > > + 1 But I am not usability expert > > On Sun, Jun 15, 2014 at 3:54 PM, Shantanu Tushar Jha > wrote: > >> Hey folks, >> >> I recently added

Re: Review Request 118759: Add a separator to the path where PMC stores playlist file

2014-06-15 Thread Shantanu Tushar
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118759/#review60126 --- Ship it! Ship It! - Shantanu Tushar On June 15, 2014, 12:3

Re: Review Request 118759: Add a separator to the path where PMC stores playlist file

2014-06-15 Thread Ashish Madeti
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118759/ --- (Updated June 15, 2014, 6 p.m.) Review request for Plasma, Shantanu Tusha

Re: Review Request 118759: Add a separator to the path where PMC stores playlist file

2014-06-15 Thread Shantanu Tushar
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118759/#review60125 --- libs/mediacenter/playlistmodel.cpp

Re: statusNotifier hide behaviour inconsistent

2014-06-15 Thread Damian Ivanov
Thanks Martin for the answer. >The long term plan for the strange parts like klipper and kmix is to transform >them to a Plasmoid. > I hope this won't happen any time soon, I use them in not plasma (their StatusNotifiers) :) So general question: Should the StatusNotifier or the StatusNotifierHos

Re: Ideas around Highlight

2014-06-15 Thread Akshay Ratan
Hello, In my opinion, second highlight looks more crisp and sharp and hence preferable. :) On Sun, Jun 15, 2014 at 3:54 PM, Shantanu Tushar Jha wrote: > Hey folks, > > I recently added a visual highlight in the All Music mode to help the user > follow the current focus[1]. > > I am wondering i

Re: Ideas around Highlight

2014-06-15 Thread Sinny Kumari
CC'ing Thomas as well On Sun, Jun 15, 2014 at 3:54 PM, Shantanu Tushar Jha wrote: > Hey folks, > > I recently added a visual highlight in the All Music mode to help the user > follow the current focus[1]. > > I am wondering if the simple highlight looks better than > PlasmaComponents.Highlight,

Ideas around Highlight

2014-06-15 Thread Shantanu Tushar Jha
Hey folks, I recently added a visual highlight in the All Music mode to help the user follow the current focus[1]. I am wondering if the simple highlight looks better than PlasmaComponents.Highlight, and I need your opinion. Please try the patch at http://paste.ubuntu.com/7647243 and see which on

Re: Review Request 118759: Add a separator to the path where PMC stores playlist file

2014-06-15 Thread Ashish Madeti
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118759/ --- (Updated June 15, 2014, 3:44 p.m.) Review request for Plasma, Shantanu Tu

Review Request 118759: Add a separator to the path where PMC stores playlist file

2014-06-15 Thread Ashish Madeti
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118759/ --- Review request for Plasma, Shantanu Tushar and Sinny Kumari. Repository:

Re: statusNotifier hide behaviour inconsistent

2014-06-15 Thread Martin Gräßlin
On Sunday 15 June 2014 06:48:06 Damian Ivanov wrote: > Hi, > > I implemented the StatusNotifier standard and I have one observation: > eg. > klipper: you left click it - it shows up - you click inside another > window - klipper hides > > kmix & others - you left click it - it shows up - you click

Re: Request to MacBook users

2014-06-15 Thread Giorgos Tsiapaliokas
Hello, On Friday 13 of June 2014 09:02:55 Martin Gräßlin wrote: > What I see on my old MacBook is: > * Expose: XF86LaunchA > * Dashboard: XF86LaunchB It's the same here in MacoBook Pro 11.1(2013) -- Giorgos Tsiapaliokas terietor.org ___ Plasma-devel